Skip to content

Commit 390a1df

Browse files
klaramargrethehelgemo[Klara Margrethe Helgemo]
andauthored
TK-38 Forbedringer kvalitetssikring-14a. Nye ikoner, overskrift tar m… (#37)
* TK-38 Forbedringer kvalitetssikring-14a. Nye ikoner, overskrift tar mindre plass, midtstilling av innhold når skjermstørrelse er over maks bredde. * TK-38 Forbedringer kvalitetssikring-14a. Har fjernet Filters, samt .less-filene for bruker-filter og status-dropdown. Styling lagt inn i filters.less. Tittel har nå samme venstre marg som tabellen. Feilretting som etterspurt i PR. Co-authored-by: [Klara Margrethe Helgemo] <[[email protected]]>
1 parent 5ce2c98 commit 390a1df

File tree

16 files changed

+134
-101
lines changed

16 files changed

+134
-101
lines changed

package-lock.json

Lines changed: 9 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
],
3535
"dependencies": {
3636
"@craco/craco": "^5.6.4",
37+
"@navikt/ds-icons": "^0.3.3",
3738
"@navikt/fnrvalidator": "^1.1.3",
3839
"@navikt/frontendlogger": "^2.0.0",
3940
"@navikt/navspa": "^1.1.1",
@@ -47,7 +48,7 @@
4748
"nav-frontend-alertstriper-style": "^2.0.17",
4849
"nav-frontend-chevron": "^1.0.13",
4950
"nav-frontend-chevron-style": "^0.3.5",
50-
"nav-frontend-core": "^5.0.1",
51+
"nav-frontend-core": "^5.1.1",
5152
"nav-frontend-etiketter": "^2.0.8",
5253
"nav-frontend-etiketter-style": "^1.0.3",
5354
"nav-frontend-ikoner-assets": "^2.0.3",
@@ -80,6 +81,7 @@
8081
"@types/react-select": "^3.0.19",
8182
"cross-env": "^7.0.2",
8283
"faker": "^5.1.0",
84+
"file-loader": "^4.3.0",
8385
"husky": "^4.3.0",
8486
"lint-staged": "^10.4.0",
8587
"prettier": "^2.1.2",

src/app.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React from 'react';
22
import StoreProvider from './stores/store-provider';
3-
import { Header } from './components/header/header';
3+
44
import { InternflateDecorator } from './components/internflate-decorator/internflate-decorator';
55
import { Hovedside } from './hovedside/hovedside';
66
import { DataFetcher } from './components/datafetcher';
@@ -24,7 +24,6 @@ function Innhold() {
2424

2525
return harTilgang ? (
2626
<>
27-
<Header />
2827
<Hovedside />
2928
</>
3029
) : (

src/components/filters/bruker-filter/bruker-filter.less

Lines changed: 0 additions & 7 deletions
This file was deleted.

src/components/filters/bruker-filter/bruker-filter.tsx

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
import React from 'react';
2-
import { Element } from 'nav-frontend-typografi';
32
import { Checkbox } from 'nav-frontend-skjema';
43
import { useSokStore } from '../../../stores/sok-store';
5-
import './bruker-filter.less';
4+
import '../../filters/filters.less';
65

76
export const BrukerFilter = () => {
87
const { filters, setVisMineBrukere } = useSokStore();
@@ -12,12 +11,10 @@ export const BrukerFilter = () => {
1211
}
1312

1413
return (
15-
<div className="bruker-filter">
16-
<Element>Bruker</Element>
14+
<div>
1715
<Checkbox
18-
aria-label="Filtrer mine brukere"
1916
label="Mine brukere"
20-
className="bruker-filter__checkbox"
17+
aria-label="Filtrer mine brukere"
2118
checked={filters.visMineBrukere}
2219
onChange={handleOnVisMineBrukereChanged}
2320
/>

src/components/filters/filters.less

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,14 @@
1919
margin-left: 2rem;
2020
}
2121
}
22+
}
23+
24+
.status-dropdown {
25+
display: flex;
26+
flex-grow: 2;
27+
width: 300px;
28+
}
29+
30+
.bruker-filter {
31+
margin: 0 1rem;
2232
}

src/components/filters/filters.tsx

Lines changed: 0 additions & 20 deletions
This file was deleted.

src/components/filters/status-dropwdown/status-dropdown.tsx renamed to src/components/filters/status-dropdown/status-dropdown.tsx

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import React from 'react';
22
import Select from 'react-select';
3-
import { Element } from 'nav-frontend-typografi';
43
import { DropdownOption } from '../enhet-dropdown/enhet-dropdown';
54
import { UtkastStatus } from '../../../rest/data/bruker';
65
import { mapBrukerStatusTilTekst } from '../../../utils';
76
import { useSokStore } from '../../../stores/sok-store';
8-
import './status-dropdown.less';
7+
import '../../filters/filters.less';
8+
99

1010
export function mapStatusTilDropdownOption(status: UtkastStatus): DropdownOption {
1111
return { value: status, label: mapBrukerStatusTilTekst(status) };
@@ -22,13 +22,15 @@ export const StatusDropdown = () => {
2222
const value = filters.status ? mapStatusTilDropdownOption(filters.status) : null;
2323

2424
function handleOnStatusSelectedChanged(selectedOption: DropdownOption | null) {
25-
const nyStatus = selectedOption ? selectedOption.value as UtkastStatus : undefined;
26-
setStatusFilter(nyStatus)
25+
const nyStatus = selectedOption ? (selectedOption.value as UtkastStatus) : undefined;
26+
setStatusFilter(nyStatus);
2727
}
2828

2929
return (
30-
<div className="status-dropdown">
31-
<Element>Status</Element>
30+
<>
31+
<label className="typo-element" htmlFor="status-filter">
32+
Status
33+
</label>
3234
<Select
3335
aria-label="Filtrer på status"
3436
inputId="status-filter"
@@ -39,6 +41,6 @@ export const StatusDropdown = () => {
3941
options={statusOptions}
4042
onChange={handleOnStatusSelectedChanged as any}
4143
/>
42-
</div>
44+
</>
4345
);
4446
};

src/components/filters/status-dropwdown/status-dropdown.less

Lines changed: 0 additions & 3 deletions
This file was deleted.

src/components/header/header.less

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
1-
21
.header {
3-
padding: 2rem;
4-
background-color: white;
5-
}
2+
background-color: white;
3+
display: grid;
4+
grid-template-columns: 30% 15% 5% 20%;
5+
align-items: center;
6+
padding: 0.5rem 2rem 1rem 2rem;
7+
margin-bottom: 1rem;
8+
max-width: 1900px;
9+
}

0 commit comments

Comments
 (0)