Skip to content

Commit 40ebb5d

Browse files
committed
Bruk frontendlogger npm pakke istedenfor å hente det inn runtime
1 parent 4e6b688 commit 40ebb5d

File tree

8 files changed

+42
-91
lines changed

8 files changed

+42
-91
lines changed

package-lock.json

Lines changed: 21 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,14 @@
3535
"dependencies": {
3636
"@craco/craco": "^5.6.4",
3737
"@navikt/fnrvalidator": "^1.1.3",
38+
"@navikt/frontendlogger": "^2.0.0",
3839
"@navikt/navspa": "^1.1.1",
3940
"classnames": "^2.2.6",
4041
"constate": "^3.0.1",
4142
"craco-less": "^1.17.0",
4243
"dayjs": "^1.8.36",
43-
"lodash.throttle": "^4.1.1",
4444
"lodash.debounce": "^4.0.8",
45+
"lodash.throttle": "^4.1.1",
4546
"nav-frontend-alertstriper": "^3.0.23",
4647
"nav-frontend-alertstriper-style": "^2.0.17",
4748
"nav-frontend-chevron": "^1.0.13",

public/index.html

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,6 @@
66
<meta http-equiv="X-UA-Compatible" content="IE=edge">
77
<title>Beslutteroversikt</title>
88

9-
<script>
10-
window.frontendlogger = {info: function(){}, warn: function(){}, error: function(){}, event: function(){}};
11-
window.frontendlogger.appname = 'beslutteroversikt';
12-
</script>
13-
14-
<script type="application/javascript" src="/frontendlogger/logger.js"></script>
15-
169
<link rel="stylesheet" href="/internarbeidsflatedecorator/v2.1/static/css/main.css" />
1710
<script src="/internarbeidsflatedecorator/v2.1/static/js/head.v2.min.js"></script>
1811
</head>

src/components/sok-sync.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ import { lagBeslutterOversiktSok } from '../utils/sok-utils';
44
import { useSokStore } from '../stores/sok-store';
55
import { hasFinishedWithData } from '../rest/utils';
66
import { usePrevious } from '../utils';
7-
import { frontendlogger } from '../utils/frontend-logger';
87
import { BeslutteroversiktSok } from '../rest/api';
98
import { PTO_VEDTAKSSTOTTE_PILOT } from '../rest/feature';
9+
import { logMetrikk } from '../utils/logger';
1010

1111
function logSokMetrikker(sok: BeslutteroversiktSok, currentPage: number): void {
1212
const filterMetrikker: any = {};
@@ -18,7 +18,7 @@ function logSokMetrikker(sok: BeslutteroversiktSok, currentPage: number): void {
1818
filterMetrikker.visMineBrukere = sok.filter.visMineBrukere || false;
1919
}
2020

21-
frontendlogger.logMetrikk('sok', {
21+
logMetrikk('sok', {
2222
page: currentPage,
2323
orderByField: sok.orderByField,
2424
orderByDirection: sok.orderByDirection,

src/rest/use-fetch.ts

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,19 @@
11
import { useCallback, useMemo, useState } from 'react';
22
import { FetchInfo, FetchState, FetchStatus } from './utils';
3-
import { logger } from '../utils/logger';
43

54
export interface Fetch<D = any, FP = any> extends FetchState<D> {
65
fetch: (fetchParams: FP, onFinished?: (fetchState: FetchState<D>) => void) => void;
76
reset: () => void;
87
}
98

10-
const createInitialFetchState = (): FetchState<any> => ({
9+
const createInitialFetchState = (): FetchState => ({
1110
status: FetchStatus.NOT_STARTED,
1211
error: null,
1312
data: null as any,
1413
httpCode: -1
1514
});
1615

17-
const createPendingFetchState = (): FetchState<any> => ({
16+
const createPendingFetchState = (): FetchState => ({
1817
status: FetchStatus.PENDING,
1918
error: null,
2019
data: null as any,
@@ -59,10 +58,6 @@ const useFetch = <D = {}, FP = any>(createFetchInfo: (fetchParams: FP) => FetchI
5958
return createFinishedFetchState(null as any, error, -1);
6059
})
6160
.then(state => {
62-
if (state.httpCode >= 400) {
63-
logger.error('API kall feilet', state);
64-
}
65-
6661
if (onFinished) {
6762
onFinished(state);
6863
}

src/rest/utils.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { frontendlogger } from '../utils/frontend-logger';
1+
import { logError } from '../utils/logger';
22

33
export type FetchInfo = RequestInit & { url: string };
44

@@ -62,7 +62,7 @@ export const fetchWithInfo = (fetchInfo: FetchInfo) => {
6262
res.clone()
6363
.text()
6464
.then(txt => {
65-
frontendlogger.logError({ error: txt });
65+
logError({ error: txt });
6666
})
6767
.catch();
6868

src/utils/frontend-logger.ts

Lines changed: 0 additions & 42 deletions
This file was deleted.

src/utils/logger.ts

Lines changed: 13 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,18 @@
1-
import env from './environment';
2-
import { frontendlogger } from './frontend-logger';
1+
import {
2+
createFrontendLogger,
3+
createMockFrontendLogger,
4+
DEFAULT_FRONTENDLOGGER_API_URL
5+
} from '@navikt/frontendlogger/lib';
6+
import { APP_NAME } from './constants';
37

4-
export const log = (...args: any[]): void => {
5-
if (env.isDevelopment) {
6-
console.log(...args); // tslint:disable-line
7-
}
8-
};
9-
10-
export const warn = (...args: any[]): void => {
11-
if (env.isDevelopment) {
12-
console.warn(...args); // tslint:disable-line
13-
}
14-
};
15-
16-
export const info = (...args: any[]): void => {
17-
if (env.isDevelopment) {
18-
console.info(...args); // tslint:disable-line
19-
}
20-
};
8+
export const logger = process.env.REACT_APP_DEV
9+
? createMockFrontendLogger(APP_NAME)
10+
: createFrontendLogger(APP_NAME, DEFAULT_FRONTENDLOGGER_API_URL);
2111

22-
export const error = (...args: any[]): void => {
23-
if (env.isDevelopment) {
24-
console.error(...args); // tslint:disable-line
25-
} else if (env.isProduction) {
26-
frontendlogger.logError({ error: JSON.stringify(args) });
27-
}
12+
export const logError = (fields?: {}, tags?: {}): void => {
13+
logger.event(`${APP_NAME}.error`, fields, tags);
2814
};
2915

30-
export const logger = {
31-
log,
32-
error,
33-
warn,
34-
info
16+
export const logMetrikk = (metrikkNavn: string, fields?: {}, tags?: {}): void => {
17+
logger.event(`${APP_NAME}.metrikker.${metrikkNavn}`, fields, tags);
3518
};

0 commit comments

Comments
 (0)