Added Problem and handling of missing access and not found.

Author: flexable777

build.gradle.kts

@@ -6,6 +6,7 @@ val springVersion = "2.5.5"
 val testContainersVersion = "1.17.3"
 val springDocVersion = "1.6.11"
 val tokenValidationVersion = "2.1.4"
+val problemSpringWebStartVersion = "0.27.0"
 
 repositories {
     mavenCentral()
@@ -30,6 +31,8 @@ dependencies {
     implementation("org.springframework.boot:spring-boot-starter-data-jpa")
     implementation("org.springframework.boot:spring-boot-starter-validation")
 
+    implementation("org.zalando:problem-spring-web-starter:$problemSpringWebStartVersion")
+
     implementation("no.nav.security:token-validation-spring:$tokenValidationVersion")
 
     implementation("org.springdoc:springdoc-openapi-ui:$springDocVersion")

src/main/kotlin/no/nav/klage/document/config/ProblemHandlingControllerAdvice.kt

@@ -0,0 +1,38 @@
+package no.nav.klage.document.config
+
+import no.nav.klage.document.exceptions.MissingAccessException
+import no.nav.klage.document.util.getLogger
+import org.springframework.http.ResponseEntity
+import org.springframework.web.bind.annotation.ControllerAdvice
+import org.springframework.web.bind.annotation.ExceptionHandler
+import org.springframework.web.context.request.NativeWebRequest
+import org.zalando.problem.Problem
+import org.zalando.problem.Status
+import org.zalando.problem.spring.web.advice.AdviceTrait
+import org.zalando.problem.spring.web.advice.ProblemHandling
+import javax.persistence.EntityNotFoundException
+
+@ControllerAdvice
+class ProblemHandlingControllerAdvice : OurOwnExceptionAdviceTrait, ProblemHandling
+
+interface OurOwnExceptionAdviceTrait : AdviceTrait {
+
+    companion object {
+        @Suppress("JAVA_CLASS_ON_COMPANION")
+        private val logger = getLogger(javaClass.enclosingClass)
+    }
+
+    @ExceptionHandler
+    fun handleEntityNotFound(
+        ex: EntityNotFoundException,
+        request: NativeWebRequest
+    ): ResponseEntity<Problem> =
+        create(Status.NOT_FOUND, ex, request)
+
+    @ExceptionHandler
+    fun handleMissingAccess(
+        ex: MissingAccessException,
+        request: NativeWebRequest
+    ): ResponseEntity<Problem> =
+        create(Status.FORBIDDEN, ex, request)
+}

src/main/kotlin/no/nav/klage/document/exceptions/Exceptions.kt

@@ -0,0 +1,3 @@
+package no.nav.klage.document.exceptions
+
+class MissingAccessException(msg: String) : RuntimeException(msg)

src/main/kotlin/no/nav/klage/document/service/CommentService.kt

@@ -1,6 +1,7 @@
 package no.nav.klage.document.service
 
 import no.nav.klage.document.domain.Comment
+import no.nav.klage.document.exceptions.MissingAccessException
 import no.nav.klage.document.repositories.CommentRepository
 import org.springframework.stereotype.Service
 import org.springframework.transaction.annotation.Transactional
@@ -57,7 +58,7 @@ class CommentService(private val commentRepository: CommentRepository) {
     fun setCommentText(commentId: UUID, text: String, loggedInIdent: String): Comment {
         val comment = commentRepository.getReferenceById(commentId)
         if (comment.authorIdent != loggedInIdent) {
-            throw RuntimeException("Not allowed to modify others comment")
+            throw MissingAccessException("Not allowed to modify others comment")
         }
         comment.text = text
         comment.modified = LocalDateTime.now()
@@ -67,7 +68,7 @@ class CommentService(private val commentRepository: CommentRepository) {
     fun deleteComment(commentId: UUID, loggedInIdent: String) {
         val comment = commentRepository.getReferenceById(commentId)
         if (comment.authorIdent != loggedInIdent) {
-            throw RuntimeException("Not allowed to delete others comment")
+            throw MissingAccessException("Not allowed to delete others comment")
         }
         commentRepository.delete(comment)
     }