Skip to content

Commit f303fd8

Browse files
committed
Fjerner mer logikk rundt innlogging.
1 parent 266f2ce commit f303fd8

File tree

8 files changed

+10
-190
lines changed

8 files changed

+10
-190
lines changed

src/main/kotlin/no/nav/tms/statistikk/api/StatistikkContent.kt

Lines changed: 0 additions & 34 deletions
This file was deleted.

src/main/kotlin/no/nav/tms/statistikk/api/routes.kt

Lines changed: 0 additions & 34 deletions
This file was deleted.

src/main/kotlin/no/nav/tms/statistikk/application.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import no.nav.tms.statistikk.database.Flyway
55
import no.nav.tms.statistikk.database.PostgresDatabase
66
import no.nav.tms.statistikk.eksternVarsling.EksternVarslingRepository
77
import no.nav.tms.statistikk.eksternVarsling.EksternVarslingSubscriber
8-
import no.nav.tms.statistikk.login.LoginRepository
98
import no.nav.tms.statistikk.microfrontends.MicrofrontendRepository
109
import no.nav.tms.statistikk.microfrontends.MicrofrontendSubscriber
1110
import no.nav.tms.statistikk.utkast.*
@@ -23,7 +22,6 @@ private fun startRapid(
2322
) {
2423
val database = PostgresDatabase(environment)
2524

26-
val loginRepository = LoginRepository(database)
2725
val varselRepository = VarselRepository(database)
2826
val eksternVarslingRepository = EksternVarslingRepository(database)
2927
val utkastRespository = UtkastRespository(database)
@@ -40,7 +38,7 @@ private fun startRapid(
4038
}
4139

4240
ktorModule {
43-
statistikkApi(loginRepository)
41+
statistikkApi()
4442
}
4543

4644
subscribers(

src/main/kotlin/no/nav/tms/statistikk/login/LoginRepository.kt

Lines changed: 0 additions & 49 deletions
This file was deleted.
Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,11 @@
11
package no.nav.tms.statistikk.login
22

33
import io.ktor.http.*
4-
import io.ktor.server.application.*
5-
import io.ktor.server.request.*
64
import io.ktor.server.response.*
75
import io.ktor.server.routing.*
86

9-
fun Route.loginApi(loginRepository: LoginRepository) {
7+
fun Route.loginApi() {
108
post("/innlogging") {
11-
// val login: Login = call.receive()
12-
// loginRepository.registerLogin(login.ident)
139
call.respond(HttpStatusCode.NoContent)
1410
}
1511
}
16-
17-
private data class Login(val ident: String)

src/main/kotlin/no/nav/tms/statistikk/statistikkApi.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,12 @@ import io.ktor.server.plugins.statuspages.*
1010
import io.ktor.server.response.*
1111
import io.ktor.server.routing.*
1212
import io.github.oshai.kotlinlogging.KotlinLogging
13-
import no.nav.tms.statistikk.login.LoginRepository
1413
import no.nav.tms.statistikk.login.loginApi
1514
import no.nav.tms.token.support.azure.validation.azure
1615
import java.io.IOException
1716
import java.text.DateFormat
1817

1918
fun Application.statistikkApi(
20-
loginRepository: LoginRepository,
2119
installAuthenticatorsFunction: Application.() -> Unit = installAuth(),
2220
) {
2321
installAuthenticatorsFunction()
@@ -55,7 +53,7 @@ fun Application.statistikkApi(
5553
}
5654
routing {
5755
authenticate {
58-
loginApi(loginRepository)
56+
loginApi()
5957
}
6058
}
6159
}

src/test/kotlin/no/nav/tms/statistikk/StatistikkApiTest.kt

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import io.ktor.server.application.*
1010
import io.ktor.server.auth.*
1111
import io.ktor.server.testing.*
1212
import kotliquery.queryOf
13-
import no.nav.tms.statistikk.login.LoginRepository
1413
import no.nav.tms.token.support.azure.validation.mock.azureMock
1514
import org.junit.jupiter.api.BeforeEach
1615
import org.junit.jupiter.api.Test
@@ -20,7 +19,6 @@ import org.junit.jupiter.api.TestInstance
2019
class StatistikkApiTest {
2120

2221
private val db = LocalPostgresDatabase.cleanDb()
23-
private val loginRepository = LoginRepository(db)
2422

2523
@BeforeEach
2624
fun cleanDb(){
@@ -30,7 +28,7 @@ class StatistikkApiTest {
3028
@Test
3129
fun `lagrer ikke data om innlogging`() = testApplication {
3230
application {
33-
statistikkApi(loginRepository, authorized)
31+
statistikkApi(authorized)
3432
}
3533

3634
client.post("/innlogging") {
@@ -60,18 +58,13 @@ class StatistikkApiTest {
6058
it.int("total")
6159
}.asSingle
6260
} shouldBe 0
63-
}
64-
65-
@Test
66-
fun `csv innlogging nedlasting`() = testApplication {
6761

68-
loginRepository.registerLogin("1234576512")
69-
loginRepository.registerLogin("1234576515")
70-
loginRepository.registerLogin("1234576516")
71-
72-
application {
73-
statistikkApi(loginRepository, unauthorized)
74-
}
62+
db.query {
63+
queryOf("SELECT COUNT(ident) as total FROM innlogging_etter_eksternt_varsel")
64+
.map {
65+
it.int("total")
66+
}.asSingle
67+
} shouldBe 0
7568
}
7669

7770
private val authorized: Application.() -> Unit = {

src/test/kotlin/no/nav/tms/statistikk/login/LoginRepositoryTest.kt

Lines changed: 0 additions & 46 deletions
This file was deleted.

0 commit comments

Comments
 (0)