Remove argument immutability in order to avoid complexity at this stage.

Author: Rajesh Jinaga

src/Simpleflow/CodeGenerator/ArgumentImmutabilityCheck.cs

@@ -146,24 +146,8 @@ private Expression VisitPartialSet(SimpleflowParser.SetStmtContext context, Expr
                                  (propInfo, valueExp) =>
                                         propExpressions.Add(Expression.Assign(Expression.Property(variable, propInfo), valueExp)));
 
-            /*
-             *  Check for script argument immutability, exception case: if a function change property of script arg, 
-             *  simppleflow does not control.
-             */
-            var referenceProperties = new List<Expression>();
-            var checkForSameReference = Expression.Call(null,
-                                                    typeof(ArgumentImmutabilityCheck).GetMethod(nameof(ArgumentImmutabilityCheck.CheckForSameReference)),
-                                                    arg0: InputParam,
-                                                    arg1: variable);
-
-            return
-            Expression.IfThenElse(
-                    Expression.Or(
-                           Expression.IsTrue(Expression.Property(ScriptHelperContextParam, nameof(ScriptHelperContext.IsArgumentMutable))),
-                           Expression.IsFalse(checkForSameReference)),
-                    Expression.Block(propExpressions),
-                    Expression.Throw(Expression.New(typeof(ArgumentImmutableExeception))) 
-                );
+            return Expression.Block(propExpressions);
+                   
         }
     }
 }

src/Simpleflow/CodeGenerator/SimpleflowCodeVisitor.VistitSet.cs

@@ -7,11 +7,6 @@ namespace Simpleflow
     /// <inheritdoc />
     public class FlowOptions : IOptions
     {
-        /// <summary>
-        /// Gets or sets AllowArgumentToMutate
-        /// </summary>
-        public bool AllowArgumentToMutate { get; set; } 
-
         /// <summary>
         /// Gets or sets AllowFunctions
         /// </summary>

src/Simpleflow/Exceptions/ArgumentImmutableExeception.cs

@@ -8,11 +8,6 @@ namespace Simpleflow
     /// </summary>
     public interface IOptions
     {
-        /// <summary>
-        /// Gets or sets AllowArgumentToMutate
-        /// </summary>
-        bool AllowArgumentToMutate { get;  }
-
         /// <summary>
         /// Gets or sets AllowFunctions
         /// </summary>

src/Simpleflow/FlowOptions.cs

@@ -12,14 +12,12 @@ public sealed class ScriptHelperContext
 
         private ScriptHelperContext() { }
 
-        internal ScriptHelperContext(FlowOutput flowOutput, bool isArgumentMutable, CancellationToken token)
+        internal ScriptHelperContext(FlowOutput flowOutput,  CancellationToken token)
         {
             _flowOutput = flowOutput;
             _token = token;
-            IsArgumentMutable = isArgumentMutable;
         }
-
-        public bool IsArgumentMutable { get; }
+        
         public bool HasErrors => _flowOutput.Errors.Count > 0;
         public bool HasMessages => _flowOutput.Messages.Count > 0;
         public bool HasOutputs => _flowOutput.Output.Count > 0;

src/Simpleflow/IOptions.cs

@@ -36,7 +36,6 @@ public void Run<TArg>(FlowContext<TArg> context, NextPipelineService<TArg> next)
             context.Trace?.CreateNewTracePoint(nameof(ExecutionService));
 
             var scriptHelperContext = new ScriptHelperContext(context.Output,
-                                                             (context.Options?.AllowArgumentToMutate ?? _options?.AllowArgumentToMutate) ?? true,
                                                              context.Options?.CancellationToken ?? default);
 
             context.Internals.CompiledScript?.Invoke(context.Argument, context.Output, scriptHelperContext);

src/Simpleflow/ScriptHelperContext.cs

@@ -3,7 +3,7 @@
     <TargetFrameworks>netcoreapp3.1;net5.0;net6.0</TargetFrameworks>
     <PackageIcon>PackageIcon.png</PackageIcon>
     <VersionPrefix>1.0.4</VersionPrefix>
-    <VersionSuffix>beta3</VersionSuffix>
+    <VersionSuffix></VersionSuffix>
     <PackageReadmeFile>README.md</PackageReadmeFile>
   </PropertyGroup>
 

src/Simpleflow/Services/ExecutionService.cs

@@ -21,7 +21,7 @@ output x
 
             // Act 
             var result = SimpleflowEngine.Run(script, new object());
-            var scriptHelperContext = new ScriptHelperContext(result, true, System.Threading.CancellationToken.None);
+            var scriptHelperContext = new ScriptHelperContext(result, System.Threading.CancellationToken.None);
 
             // Assert
             Assert.True(scriptHelperContext.HasErrors);
@@ -41,7 +41,7 @@ public void HasNoErrorsMessagesOutput()
 
             // Act 
             var result = SimpleflowEngine.Run(script, new object());
-            var scriptHelperContext = new ScriptHelperContext(result, true, System.Threading.CancellationToken.None);
+            var scriptHelperContext = new ScriptHelperContext(result, System.Threading.CancellationToken.None);
 
             // Assert
             Assert.False(scriptHelperContext.HasErrors);