Skip to content

Commit e0e7103

Browse files
author
Rajesh Jinaga
committed
Remove unimplemented attribute
1 parent faf49b0 commit e0e7103

File tree

6 files changed

+8
-21
lines changed

6 files changed

+8
-21
lines changed

build/Build.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ class Build : NukeBuild
113113
.SetPackageProjectUrl("https://github.com/navtech-io/Simpleflow")
114114
.AddProperty("PackageLicenseExpression", "Apache-2.0")
115115
.SetIncludeSymbols(true)
116-
.SetVersion("0.1.0-beta03" /*NuGetVersionCustom*/)
116+
.SetVersion("0.1.0-beta04" /*NuGetVersionCustom*/)
117117
.SetDescription("Lightweight rule engine")
118118
.SetPackageTags("Simpleflow.NET Workflow RuleEngine DynamicExpressionEvaluator")
119119
.SetNoDependencies(true)

src/Simpleflow/FlowOptions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ public class FlowOptions : IOptions
1010
/// <summary>
1111
/// Gets or sets AllowArgumentToMutate
1212
/// </summary>
13-
public bool AllowArgumentToMutate { get; set; }
13+
// public bool AllowArgumentToMutate { get; set; } // Implement in next release
1414

1515
/// <summary>
1616
/// Gets or sets AllowFunctions

src/Simpleflow/IOptions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public interface IOptions
1111
/// <summary>
1212
/// Gets or sets AllowArgumentToMutate
1313
/// </summary>
14-
bool AllowArgumentToMutate { get; }
14+
//bool AllowArgumentToMutate { get; } // Implement in next release Check CacheService related impl
1515

1616
/// <summary>
1717
/// Gets or sets AllowFunctions

src/Simpleflow/Services/CacheService.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,16 +105,17 @@ protected virtual string GetScriptUniqueId(string script)
105105

106106
private string GetFlowContextOptionsId(IContextOptions options)
107107
{
108-
if (options.AllowArgumentToMutate == false
109-
&& (options.AllowFunctions == null || options.AllowFunctions.Length == 0)
108+
if (
109+
//options.AllowArgumentToMutate == false &&
110+
(options.AllowFunctions == null || options.AllowFunctions.Length == 0)
110111
&& (options.DenyFunctions == null || options.DenyFunctions.Length == 0)
111112
)
112113
{
113114
return string.Empty;
114115
}
115116

116117
StringBuilder sb = new StringBuilder();
117-
sb.Append(string.Join(' ', options.AllowArgumentToMutate));
118+
//sb.Append(string.Join(' ', options.AllowArgumentToMutate));
118119

119120
if (options.AllowFunctions != null && options.AllowFunctions.Length > 0)
120121
{

src/Simpleflow/Simpleflow.xml

Lines changed: 0 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/Simpleflow.Tests/Infrastructure/FlowContextOptionsTest.cs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,7 @@ message d
7575

7676
// Act & Assert
7777
Assert.Throws<AccessDeniedException>(
78-
() => new SimpleflowPipelineBuilder()
79-
.AddCorePipelineServices(FunctionRegister.Default)
80-
.AddPipelineServices(new LoggingService())
81-
.Build()
82-
.Run(script, new object(), options));
78+
() => SimpleflowEngine.Run(script, new object(), options));
8379
}
8480

8581
[Fact]

0 commit comments

Comments
 (0)