fixed tests

Author: ytake

.hhconfig

@@ -12,4 +12,4 @@ disable_lval_as_an_expression = true
 new_inference_lambda = true
 error_php_lambdas = true
 allowed_decl_fixme_codes=2053,4045,4047
-allowed_fixme_codes_strict=2011,2049,2050,2053,2083,3004,3084,4027,4045,4047,4104,4106,4108,4110,4119,4128,4135,4188,4223,4240,4248,4323,4200
+allowed_fixme_codes_strict=2011,2049,2050,2053,2083,3004,3084,4027,4045,4047,4104,4106,4107,4108,4110,4119,4128,4135,4188,4223,4240,4248,4323,4200

tests/EmitterStackTest.hack

@@ -20,7 +20,7 @@ final class EmitterStackTest extends HackTest {
   public function testShouldEmitTrue(): void {
     $sapiEmmiter = new SapiEmitter();
     $this->stack->push($sapiEmmiter);
-    list($readHandle, $writeHandle) = IO\pipe_nd();
+    list($readHandle, $writeHandle) = IO\pipe();
     $writeHandle->write('testing');
     ob_start();
     $result = $this->stack->emit(
@@ -34,7 +34,7 @@ final class EmitterStackTest extends HackTest {
   public function testShouldReturnMessageBody(): void {
     $sapiEmmiter = new SapiEmitter();
     $this->stack->push($sapiEmmiter);
-    list($readHandle, $writeHandle) = IO\pipe_nd();
+    list($readHandle, $writeHandle) = IO\pipe();
     $writeHandle->write('content');
     ob_start();
     $_ = $this->stack->emit(
@@ -49,7 +49,7 @@ final class EmitterStackTest extends HackTest {
   public function testEmitsResponseHeaders(): void {
     $sapiEmmiter = new OverrideSapiEmitter();
     $this->stack->push($sapiEmmiter);
-    list($readHandle, $writeHandle) = IO\pipe_nd();
+    list($readHandle, $writeHandle) = IO\pipe();
     $writeHandle->write('content');
     $response = new TextResponse($writeHandle, StatusCode::OK);
     ob_start();
@@ -66,9 +66,9 @@ final class EmitterStackTest extends HackTest {
 
   public async function testMultipleSetCookieHeadersAreNotReplaced(): Awaitable<void> {
     $sapiEmmiter = new OverrideSapiEmitter();
-    list($readHandle, $writeHandle) = IO\pipe_nd();
+    list($readHandle, $writeHandle) = IO\pipe();
     await $writeHandle->writeAsync('');
-    await $writeHandle->closeAsync();
+    $writeHandle->close();
     $sapiEmmiter->emit($readHandle, (new Response($writeHandle))
       ->withStatus(200)
       ->withAddedHeader('Set-Cookie', vec['foo=bar', 'bar=baz']));
@@ -81,9 +81,9 @@ final class EmitterStackTest extends HackTest {
 
   public async function testDoesNotLetResponseCodeBeOverriddenByHack(): Awaitable<void> {
     $sapiEmmiter = new OverrideSapiEmitter();
-    list($readHandle, $writeHandle) = IO\pipe_nd();
+    list($readHandle, $writeHandle) = IO\pipe();
     await $writeHandle->writeAsync('');
-    await $writeHandle->closeAsync();
+    $writeHandle->close();
     $response = (new Response($writeHandle))
       ->withStatus(StatusCode::ACCEPTED)
       ->withAddedHeader('Location', vec['http://api.my-service.com/12345678'])
@@ -104,9 +104,9 @@ final class EmitterStackTest extends HackTest {
     $sapiEmmiter = new SapiEmitter();
     $this->stack->push($sapiEmmiter);
     $this->stack->push($sapiEmmiter);
-    list($readHandle, $writeHandle) = IO\pipe_nd();
+    list($readHandle, $writeHandle) = IO\pipe();
     await $writeHandle->writeAsync('content');
-    await $writeHandle->closeAsync();
+    $writeHandle->close();
     ob_start();
     await $this->stack->emitAsync(
       $readHandle,

tests/MockAsyncRequestHandler.hack

@@ -14,7 +14,7 @@ final class MockAsyncRequestHandler implements AsyncRequestHandlerInterface {
     ServerRequestInterface $_request
   ): Awaitable<ResponseInterface> {
     if($handle is IO\CloseableHandle) {
-      await $handle->closeAsync();
+      $handle->close();
     }
     return new Response($handle, StatusCode::OK);
   }

tests/RequestHandleExecutorTest.hack

@@ -13,7 +13,7 @@ final class RequestHandleExecutorTest extends HackTest {
   public function testShouldReturnNullStackEmitter(): void {
     $stack = new EmitterStack();
     $stack->push(new OverrideSapiEmitter());
-    list($readHandle, $writeHandle) = IO\pipe_nd();
+    list($readHandle, $writeHandle) = IO\pipe();
     $executor = new RequestHandleExecutor(
       $readHandle,
       $writeHandle,
@@ -28,7 +28,7 @@ final class RequestHandleExecutorTest extends HackTest {
   }
 
   public function testShouldReturnNullSapiEmitter(): void {
-    list($readHandle, $writeHandle) = IO\pipe_nd();
+    list($readHandle, $writeHandle) = IO\pipe();
     $executor = new RequestHandleExecutor(
       $readHandle,
       $writeHandle,

tests/SapiEmitterTest.hack

@@ -11,9 +11,9 @@ final class SapiEmitterTest extends HackTest {
 
   public async function testShouldAsync(): Awaitable<void> {
     $sapi = new SapiEmitter();
-    list($readHandle, $writeHandle) = IO\pipe_nd();
+    list($readHandle, $writeHandle) = IO\pipe();
     await $writeHandle->writeAsync('async content');
-    await $writeHandle->closeAsync();
+    $writeHandle->close();
     ob_start();
     await $sapi->emitAsync($readHandle, new Response($writeHandle, StatusCode::OK));
     $out = ob_get_contents();