-
Notifications
You must be signed in to change notification settings - Fork 3
Description
Hi @andersy005 - @jhamman showed me this repo earlier, and I've just had a look through it.
Obviously xcollection is similar to datatree, but the one-level dictionary-like design is also close to Arviz's InferenceData class (which datatree aims to replace, see arviz-devs/arviz#2015).
There are some things in xcollection that would be good inspiration for datatree, in particular:
-
filterandchoosemethods:
Implementing something similar toxcollections' existingfilterandchoosemethods could solve API for filtering / subsetting xarray-contrib/datatree#79 (alsofilter_by_attrsAdd an equivalent method toDataset.filter_by_attrs#4 ) -
plotting
I also would like to adding some plotting functionality, but I'm also unsure what that should return (ref Add plot() function #13 and Plotting methods xarray-contrib/datatree#47) -
weighted
DataTree should have all the same xarray aggregations (e.g.weighted) but I haven't got around to implementing that yet. I don't think I've made an issue for it either yet.
Beyond those methods I think datatree supplants xcollection.
If anyone here is interested in contributing to datatree at all then that would be great! The idea is to build it out in xarray-contrib before merging it upstream into xarray.