Minor fixes for parse/handling paths #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

alistairewj wants to merge 2 commits into ncbi-nlp:master from alistairewj:master

Contributor

alistairewj commented Feb 20, 2019

if the code could not parse the sentence, it would return None, but should return None, None to be consistent
Using a pathlib2 path for model_dir throws an error as pathlib2 doesn't fully replicate behaviour with os functions in python 3

alistairewj added 2 commits

February 20, 2019 13:19


          fix return on bad parse to be None, None

d62b5b8


          fix os.expanduser not handling pathlib2 path properly

38ef8fa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet