release always-open-on-active-screen v2.4

Author: nclarius

always-open-on-active-screen/CHANGELOG.bbcode

@@ -0,0 +1,32 @@
+[h2]v2.4[/h2]
+[list]
+[*] make script automatically enabled after install
+[*] update package structure
+[*] add install/uninstall scripts
+[*] add changelog in BB Code format
+[/list]
+
+[h2]v2.3[/h2]
+[list]
+[*] fix incorrect geometry computation
+[/list]
+
+[h2]v2.2[/h2]
+[list]
+[*] ensure adjusting window to screen dimensions is possible
+[/list]
+
+[h2]v2.1[/h2]
+[list]
+[*] fix an error with fit window on screen
+[*] add Dutch and German translations of metadata
+
+[h1]v2.0[/h1]
+[list]
+[*] adjust window dimensions to fit on screen (credits to @joedefen)
+[/list]
+
+[h1]v1.0[/h1]
+[list]
+[*] initial release
+[/list]

always-open-on-active-screen/CHANGELOG.md

@@ -1,3 +1,9 @@
+## v2.4
+- make script automatically enabled after install
+- update package structure
+- add install/uninstall scripts
+- add changelog in BB Code format
+
 ## v2.3
 
 - fix incorrect geometry computation
@@ -18,4 +24,3 @@
 # v1.0
 
 - initial release
-

always-open-on-active-screen/CHANGELOG.txt

@@ -0,0 +1,4 @@
+- make script automatically enabled after install
+- update package structure
+- add install/uninstall scripts
+- add changelog in BB Code format

always-open-on-active-screen/README.md

@@ -11,35 +11,37 @@ Extension for KDE’s window manager to make new windows always open on the moni
 
 ### Dependencies
 
-`kwin` (tested with v5.22 - v5.23 on X11).
+`kwin` (tested with v5.22 - v5.24 on X11).
 
-### Method 1: via graphical interface
+### Installation via graphical interface
 
-1. Install the script via *System Settings* > *Window Management* > *KWin Scripts* > *Get New Scripts …* > search for *Always Open on Active Screen* > *Install*.
-2. Activate the script by selecting the checkbox in the respective entry.
+*System Settings* > *Window Management* > *KWin Scripts* > *Get New Scripts …* > search for *Always Open on Active Screen* > *Install*.
 
-### Method 2: via command line
+### Installation via command line
 
 ```bash
 git clone https://github.com/nclarius/KWin-window-positioning-scripts.git
-plasmapkg2 --type kwinscript -i KWin-window-positioning-scripts/always-open-on-active-screen
-kwriteconfig5 --file kwinrc --group Plugins --key alwaysopenonactivescreenEnabled true
-qdbus org.kde.KWin /KWin reconfigure
+cd KWin-window-positioning-scripts/always-open-on-active-screen
+./install.sh
 ```
 
 
 
 ## Set-up
 
-- In order for the script to work, you need to have *Active screen follows mouse* set to enabled:  
-  - Via graphical interface:   
-    *System Settings* > *Window Management* > *Window Behavior* > *Focus* > *Multiscreen Behavor* > *Active screen follows mouse* (the option shows only when multiple monitors are currently connected).  
-  - Or by editing the config file:  
-    `~/.config/kwinrc`: 
-    ```
-    [Windows]
-    ActiveMouseScreen=true
-    ```
+In order for the script to work, you need to have *Active screen follows mouse* set to enabled.
+
+### Set-up via graphical interface
+
+*System Settings* > *Window Management* > *Window Behavior* > *Focus* > *Multiscreen Behavor* > *Active screen follows mouse* (the option shows only when multiple monitors are currently connected).  
+
+### Set-up via command line
+
+```bash
+kwriteconfig5 --file kwinrc --group Windows --key ActiveMouseScreen true
+ActiveMouseScreen=true
+qdbus org.kde.KWin /KWin reconfigure
+```
 
 
 

always-open-on-active-screen/install.sh

@@ -0,0 +1,3 @@
+#!/bin/bash
+kpackagetool5 --type=KWin/Script --install package || kpackagetool5 --type=KWin/Script --upgrade package
+qdbus org.kde.KWin /KWin reconfigure

always-open-on-active-screen/package.sh

@@ -0,0 +1,45 @@
+#/bin/bash
+
+# get plugin info
+name=$(basename "$PWD")
+version=$(grep -oP '(?<=X-KDE-PluginInfo-Version=).*' package/metadata.desktop)
+echo "$name v$version"
+
+# generate changelog in markdown format
+heading_md=$([[ $version == *.0 ]] && echo "#" || echo "##")
+caption_md="${heading_md} v${version}"
+changes_md=$(cat CHANGELOG.txt)
+echo "$caption_md"$'\n'"$changes_md"$'\n\n'"$(cat CHANGELOG.md)" > "CHANGELOG.md"
+echo "generated changelog markdown"
+
+# generate changelog in bbcode format
+heading_bb=$([[ $version == *.0 ]] && echo "h1" || echo "h2")
+caption_bb="[$heading_bb]v$version[/$heading_bb]"
+changes_bb=$'[list]\n'"$(cat CHANGELOG.txt | sed "s/- /[*] /g")"$'\n[/list]'
+echo "$caption_bb"$'\n'"$changes_bb"$'\n\n'"$(cat CHANGELOG.bbcode)" > "CHANGELOG.bbcode"
+echo "generated changelog bbcode"
+
+# generate GitHub release
+gh release create "${name}_v${version}" -F CHANGELOG.txt
+echo "generated GitHub release"
+
+# generate KDE store release
+find . -name "*.kwinscript" -type f -delete
+zip -rq "${name}_v${version}.kwinscript"  \
+	package \
+    install.sh \
+    uninstall.sh \
+    README.md \
+    README.bbcode \
+	CHANGELOG.md \
+	CHANGELOG.bbcode \
+	LICENSE
+echo "generated KDE Store release"
+
+# commit changes to GitHub
+git add *
+git commit -q -m "release $name v$version"
+git push -q
+echo "commited changes to git"
+
+echo "done"

always-open-on-active-screen/contents/code/main.js renamed to always-open-on-active-screen/package/contents/code/main.js

@@ -6,12 +6,15 @@ GNU General Public License v3.0
 
 // when a client is added
 workspace.clientAdded.connect(function(client) {
+    activeScreen = workspace.activeScreen;
     // move client to active screen
     if (client == null || client.desktopWindow || client.dock) return;
-    workspace.sendClientToScreen(client, workspace.activeScreen);
+    if (client.screen == activeScreen) return;
+    console.debug("sending client", client.caption, "to active screen", activeScreen);
+    workspace.sendClientToScreen(client, activeScreen);
 
     // clip and move client into bounds of screen dimensions
-    if (! (client.moveable && client.resizeable)) return;
+    if (!(client.moveable && client.resizeable)) return;
     area = workspace.clientArea(KWin.MaximizeArea, client);
     // window width/height maximally screen width/height
     client.geometry.width = Math.min(client.width, area.width);

always-open-on-active-screen/metadata.desktop renamed to always-open-on-active-screen/package/metadata.desktop

@@ -12,17 +12,17 @@ Comment[nl]=Opent nieuwe vensters altijd op het scherm met de cursor]
 Icon=preferences-system-windows
 
 X-KDE-PluginInfo-Name=alwaysopenonactivescreen
-X-KDE-PluginInfo-Version=2.3
+X-KDE-PluginInfo-Version=2.4
 X-KDE-PluginInfo-Author=Natalie Clarius
 X-KDE-PluginInfo-Email[email protected]
 X-KDE-PluginInfo-License=GPL v3.0
 X-KDE-PluginInfo-Website=https://store.kde.org/p/1617640/
 
 Type=Service
-X-KDE-ServiceTypes=KWin/Script,KCModule
 X-Plasma-API=javascript
 X-Plasma-MainScript=code/main.js
-
-X-KDE-Library=kwin/effects/configs/kcm_kwin4_genericscripted
+X-KDE-ServiceTypes=KWin/Script,KCModule
+X-KDE-ConfigModule=kwin/effects/configs/kcm_kwin4_genericscripted
 X-KDE-PluginKeyword=alwaysopenonactivescreen
 X-KDE-ParentComponents=alwaysopenonactivescreen
+X-KDE-PluginInfo-EnabledByDefault=true

always-open-on-active-screen/uninstall.sh

@@ -0,0 +1,3 @@
+#!/bin/bash
+kpackagetool5 --type=KWin/Script --remove package
+qdbus org.kde.KWin /KWin reconfigure