remode old function and adds another test

Author: ncode

pkg/tagit/tagit.go

@@ -147,34 +147,6 @@ func (t *TagIt) parseScriptOutput(output []byte) []string {
 	return tags
 }
 
-// CleanupServiceTags cleans up the service tags added by tagit.
-func (t *TagIt) CleanupServiceTags() error {
-	service, err := t.getService()
-	if err != nil {
-		return err
-	}
-	registration := t.copyServiceToRegistration(service)
-	log.WithFields(log.Fields{
-		"service": t.ServiceID,
-		"tags":    registration.Tags,
-	}).Info("current service tags")
-
-	filteredTags, tagged := t.excludeTagged(registration.Tags)
-	if tagged {
-		log.WithFields(log.Fields{
-			"service": t.ServiceID,
-			"tags":    filteredTags,
-		}).Info("updating service tags")
-		registration.Tags = filteredTags
-		err = t.client.Agent().ServiceRegister(registration)
-		if err != nil {
-			return err
-		}
-	}
-
-	return err
-}
-
 // Copy *api.AgentService to *api.AgentServiceRegistration
 func (t *TagIt) copyServiceToRegistration(service *api.AgentService) *api.AgentServiceRegistration {
 	return &api.AgentServiceRegistration{

pkg/tagit/tagit_test.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"reflect"
 	"slices"
+	"strings"
 	"testing"
 	"time"
 
@@ -519,3 +520,45 @@ func TestNewConsulAPIWrapper(t *testing.T) {
 	_, isConsulAgent := wrapper.Agent().(ConsulAgent)
 	assert.True(t, isConsulAgent, "Wrapper's Agent method does not return a ConsulAgent")
 }
+
+func TestCmdExecutor_Execute(t *testing.T) {
+	tests := []struct {
+		name        string
+		command     string
+		wantOutput  string
+		expectError bool
+	}{
+		{
+			name:        "Echo Command",
+			command:     "echo test",
+			wantOutput:  "test\n",
+			expectError: false,
+		},
+		{
+			name:        "Invalid Command",
+			command:     "invalidcommand",
+			expectError: true,
+		},
+	}
+
+	executor := &CmdExecutor{}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			output, err := executor.Execute(tt.command)
+
+			if tt.expectError {
+				if err == nil {
+					t.Errorf("Expected an error for command: %s, but got none", tt.command)
+				}
+			} else {
+				if err != nil {
+					t.Errorf("Did not expect an error for command: %s, but got: %v", tt.command, err)
+				}
+				if strings.TrimSpace(string(output)) != strings.TrimSpace(tt.wantOutput) {
+					t.Errorf("Unexpected output for command: %s. Expected: %s, got: %s", tt.command, tt.wantOutput, string(output))
+				}
+			}
+		})
+	}
+}