Simplify tests.

ncruces · ncruces · commit 63938d570532 · 2024-04-04T01:25:52.000+01:00
diff --git a/driver/driver_test.go b/driver/driver_test.go
@@ -153,7 +153,7 @@ func Test_BeginTx(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	_, err = tx1.Exec(`CREATE TABLE IF NOT EXISTS test (col)`)
+	_, err = tx1.Exec(`CREATE TABLE test (col)`)
 	if err == nil {
 		t.Error("want error")
 	}
@@ -310,7 +310,7 @@ func Test_time(t *testing.T) {
 
 			twosday := time.Date(2022, 2, 22, 22, 22, 22, 0, time.UTC)
 
-			_, err = db.Exec(`CREATE TABLE IF NOT EXISTS test (at DATETIME)`)
+			_, err = db.Exec(`CREATE TABLE test (at DATETIME)`)
 			if err != nil {
 				t.Fatal(err)
 			}
diff --git a/driver/json_test.go b/driver/json_test.go
@@ -18,7 +18,7 @@ func Example_json() {
 	defer db.Close()
 
 	_, err = db.Exec(`
-		CREATE TABLE IF NOT EXISTS orders (
+		CREATE TABLE orders (
 			cart_id INTEGER PRIMARY KEY,
 			user_id INTEGER NOT NULL,
 			cart    TEXT
diff --git a/driver/savepoint_test.go b/driver/savepoint_test.go
@@ -16,7 +16,7 @@ func ExampleSavepoint() {
 	}
 	defer db.Close()
 
-	_, err = db.Exec(`CREATE TABLE IF NOT EXISTS users (id INT, name VARCHAR(10))`)
+	_, err = db.Exec(`CREATE TABLE users (id INT, name VARCHAR(10))`)
 	if err != nil {
 		log.Fatal(err)
 	}
diff --git a/example_test.go b/example_test.go
@@ -16,7 +16,7 @@ func Example() {
 		log.Fatal(err)
 	}
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS users (id INT, name VARCHAR(10))`)
+	err = db.Exec(`CREATE TABLE users (id INT, name VARCHAR(10))`)
 	if err != nil {
 		log.Fatal(err)
 	}
diff --git a/ext/blobio/blob_test.go b/ext/blobio/blob_test.go
@@ -27,7 +27,7 @@ func Example() {
 	}
 	defer db.Close()
 
-	_, err = db.Exec(`CREATE TABLE IF NOT EXISTS test (col)`)
+	_, err = db.Exec(`CREATE TABLE test (col)`)
 	if err != nil {
 		log.Fatal(err)
 	}
@@ -79,8 +79,8 @@ func Test_readblob(t *testing.T) {
 	}
 
 	err = db.Exec(`
-		CREATE TABLE IF NOT EXISTS test1 (col);
-		CREATE TABLE IF NOT EXISTS test2 (col);
+		CREATE TABLE test1 (col);
+		CREATE TABLE test2 (col);
 		INSERT INTO test1 VALUES (x'cafe');
 		INSERT INTO test2 VALUES (x'babe');
 	`)
@@ -139,8 +139,8 @@ func Test_openblob(t *testing.T) {
 	}
 
 	err = db.Exec(`
-		CREATE TABLE IF NOT EXISTS test1 (col);
-		CREATE TABLE IF NOT EXISTS test2 (col);
+		CREATE TABLE test1 (col);
+		CREATE TABLE test2 (col);
 		INSERT INTO test1 VALUES (x'cafe');
 		INSERT INTO test2 VALUES (x'babe');
 	`)
diff --git a/ext/csv/csv_test.go b/ext/csv/csv_test.go
@@ -20,7 +20,7 @@ func Example() {
 	csv.Register(db)
 
 	err = db.Exec(`
-		CREATE VIRTUAL TABLE IF NOT EXISTS eurofxref USING csv(
+		CREATE VIRTUAL TABLE eurofxref USING csv(
 			filename = 'testdata/eurofxref.csv',
 			header   = YES,
 			columns  = 42,
diff --git a/ext/stats/stats_test.go b/ext/stats/stats_test.go
@@ -20,7 +20,7 @@ func TestRegister_variance(t *testing.T) {
 
 	stats.Register(db)
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS data (x)`)
+	err = db.Exec(`CREATE TABLE data (x)`)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -92,7 +92,7 @@ func TestRegister_covariance(t *testing.T) {
 
 	stats.Register(db)
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS data (y, x)`)
+	err = db.Exec(`CREATE TABLE data (y, x)`)
 	if err != nil {
 		t.Fatal(err)
 	}
diff --git a/ext/unicode/unicode_test.go b/ext/unicode/unicode_test.go
@@ -81,7 +81,7 @@ func TestRegister_collation(t *testing.T) {
 
 	Register(db)
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS words (word VARCHAR(10))`)
+	err = db.Exec(`CREATE TABLE words (word VARCHAR(10))`)
 	if err != nil {
 		t.Fatal(err)
 	}
diff --git a/func_test.go b/func_test.go
@@ -18,7 +18,7 @@ func ExampleConn_CreateCollation() {
 	}
 	defer db.Close()
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS words (word VARCHAR(10))`)
+	err = db.Exec(`CREATE TABLE words (word VARCHAR(10))`)
 	if err != nil {
 		log.Fatal(err)
 	}
@@ -66,7 +66,7 @@ func ExampleConn_CreateFunction() {
 	}
 	defer db.Close()
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS words (word VARCHAR(10))`)
+	err = db.Exec(`CREATE TABLE words (word VARCHAR(10))`)
 	if err != nil {
 		log.Fatal(err)
 	}
@@ -111,7 +111,7 @@ func ExampleContext_SetAuxData() {
 	}
 	defer db.Close()
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS words (word VARCHAR(10))`)
+	err = db.Exec(`CREATE TABLE words (word VARCHAR(10))`)
 	if err != nil {
 		log.Fatal(err)
 	}
diff --git a/func_win_test.go b/func_win_test.go
@@ -16,7 +16,7 @@ func ExampleConn_CreateWindowFunction() {
 	}
 	defer db.Close()
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS words (word VARCHAR(10))`)
+	err = db.Exec(`CREATE TABLE words (word VARCHAR(10))`)
 	if err != nil {
 		log.Fatal(err)
 	}
diff --git a/tests/backup_test.go b/tests/backup_test.go
@@ -20,7 +20,7 @@ func TestBackup(t *testing.T) {
 		}
 		defer db.Close()
 
-		err = db.Exec(`CREATE TABLE IF NOT EXISTS users (id INT, name VARCHAR(10))`)
+		err = db.Exec(`CREATE TABLE users (id INT, name VARCHAR(10))`)
 		if err != nil {
 			t.Fatal(err)
 		}
diff --git a/tests/blob_test.go b/tests/blob_test.go
@@ -22,7 +22,7 @@ func TestBlob(t *testing.T) {
 	}
 	defer db.Close()
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS test (col)`)
+	err = db.Exec(`CREATE TABLE test (col)`)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -97,7 +97,7 @@ func TestBlob_large(t *testing.T) {
 	}
 	defer db.Close()
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS test (col)`)
+	err = db.Exec(`CREATE TABLE test (col)`)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -158,7 +158,7 @@ func TestBlob_overflow(t *testing.T) {
 	}
 	defer db.Close()
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS test (col)`)
+	err = db.Exec(`CREATE TABLE test (col)`)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -217,7 +217,7 @@ func TestBlob_invalid(t *testing.T) {
 	}
 	defer db.Close()
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS test (col)`)
+	err = db.Exec(`CREATE TABLE test (col)`)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -242,7 +242,7 @@ func TestBlob_Write_readonly(t *testing.T) {
 	}
 	defer db.Close()
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS test (col)`)
+	err = db.Exec(`CREATE TABLE test (col)`)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -273,7 +273,7 @@ func TestBlob_Read_expired(t *testing.T) {
 	}
 	defer db.Close()
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS test (col)`)
+	err = db.Exec(`CREATE TABLE test (col)`)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -309,7 +309,7 @@ func TestBlob_Seek(t *testing.T) {
 	}
 	defer db.Close()
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS test (col)`)
+	err = db.Exec(`CREATE TABLE test (col)`)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -358,7 +358,7 @@ func TestBlob_Reopen(t *testing.T) {
 	}
 	defer db.Close()
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS test (col)`)
+	err = db.Exec(`CREATE TABLE test (col)`)
 	if err != nil {
 		t.Fatal(err)
 	}
diff --git a/tests/driver_test.go b/tests/driver_test.go
@@ -27,7 +27,7 @@ func TestDriver(t *testing.T) {
 	defer conn.Close()
 
 	res, err := conn.ExecContext(ctx,
-		`CREATE TABLE IF NOT EXISTS users (id INT, name VARCHAR(10))`)
+		`CREATE TABLE users (id INT, name VARCHAR(10))`)
 	if err != nil {
 		t.Fatal(err)
 	}
diff --git a/tests/func_test.go b/tests/func_test.go
@@ -196,7 +196,7 @@ func TestAnyCollationNeeded(t *testing.T) {
 	}
 	defer db.Close()
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS users (id INT, name VARCHAR(10))`)
+	err = db.Exec(`CREATE TABLE users (id INT, name VARCHAR(10))`)
 	if err != nil {
 		t.Fatal(err)
 	}
diff --git a/tests/json_test.go b/tests/json_test.go
@@ -31,7 +31,7 @@ func TestJSON(t *testing.T) {
 	}
 	defer conn.Close()
 
-	_, err = conn.ExecContext(ctx, `CREATE TABLE IF NOT EXISTS test (col)`)
+	_, err = conn.ExecContext(ctx, `CREATE TABLE test (col)`)
 	if err != nil {
 		t.Fatal(err)
 	}
diff --git a/tests/stmt_test.go b/tests/stmt_test.go
@@ -19,7 +19,7 @@ func TestStmt(t *testing.T) {
 	}
 	defer db.Close()
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS test (col)`)
+	err = db.Exec(`CREATE TABLE test (col)`)
 	if err != nil {
 		t.Fatal(err)
 	}
diff --git a/tests/time_test.go b/tests/time_test.go
@@ -146,8 +146,7 @@ func TestTimeFormat_Scanner(t *testing.T) {
 	}
 	defer conn.Close()
 
-	_, err = conn.ExecContext(ctx,
-		`CREATE TABLE IF NOT EXISTS test (col)`)
+	_, err = conn.ExecContext(ctx, `CREATE TABLE test (col)`)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -178,7 +177,7 @@ func TestDB_timeCollation(t *testing.T) {
 	}
 	defer db.Close()
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS times (tstamp COLLATE TIME)`)
+	err = db.Exec(`CREATE TABLE times (tstamp COLLATE TIME)`)
 	if err != nil {
 		t.Fatal(err)
 	}
diff --git a/tests/txn_test.go b/tests/txn_test.go
@@ -22,7 +22,7 @@ func TestConn_Transaction_exec(t *testing.T) {
 	db.CommitHook(func() bool { return true })
 	db.UpdateHook(func(sqlite3.AuthorizerActionCode, string, string, int64) {})
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS test (col)`)
+	err = db.Exec(`CREATE TABLE test (col)`)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -95,7 +95,7 @@ func TestConn_Transaction_panic(t *testing.T) {
 	}
 	defer db.Close()
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS test (col)`)
+	err = db.Exec(`CREATE TABLE test (col)`)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -153,7 +153,7 @@ func TestConn_Transaction_interrupt(t *testing.T) {
 	}
 	defer db.Close()
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS test (col)`)
+	err = db.Exec(`CREATE TABLE test (col)`)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -255,7 +255,7 @@ func TestConn_Transaction_rollback(t *testing.T) {
 	}
 	defer db.Close()
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS test (col)`)
+	err = db.Exec(`CREATE TABLE test (col)`)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -301,7 +301,7 @@ func TestConn_Savepoint_exec(t *testing.T) {
 	}
 	defer db.Close()
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS test (col)`)
+	err = db.Exec(`CREATE TABLE test (col)`)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -369,7 +369,7 @@ func TestConn_Savepoint_panic(t *testing.T) {
 	}
 	defer db.Close()
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS test (col)`)
+	err = db.Exec(`CREATE TABLE test (col)`)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -426,7 +426,7 @@ func TestConn_Savepoint_interrupt(t *testing.T) {
 	}
 	defer db.Close()
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS test (col)`)
+	err = db.Exec(`CREATE TABLE test (col)`)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -506,7 +506,7 @@ func TestConn_Savepoint_rollback(t *testing.T) {
 	}
 	defer db.Close()
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS test (col)`)
+	err = db.Exec(`CREATE TABLE test (col)`)
 	if err != nil {
 		t.Fatal(err)
 	}
diff --git a/vfs/memdb/memdb_test.go b/vfs/memdb/memdb_test.go
@@ -21,7 +21,7 @@ func Test_wal(t *testing.T) {
 	}
 	defer db.Close()
 
-	err = db.Exec(`CREATE TABLE IF NOT EXISTS users (id INT, name VARCHAR(10))`)
+	err = db.Exec(`CREATE TABLE users (id INT, name VARCHAR(10))`)
 	if err != nil {
 		t.Fatal(err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ func Test_BeginTx(t *testing.T) {`
`153`	`153`	`t.Fatal(err)`
`154`	`154`	`}`
`155`	`155`
`156`		- _, err = tx1.Exec(`CREATE TABLE IF NOT EXISTS test (col)`)
	`156`	+ _, err = tx1.Exec(`CREATE TABLE test (col)`)
`157`	`157`	`if err == nil {`
`158`	`158`	`t.Error("want error")`
`159`	`159`	`}`
`@@ -310,7 +310,7 @@ func Test_time(t *testing.T) {`
`310`	`310`
`311`	`311`	`twosday := time.Date(2022, 2, 22, 22, 22, 22, 0, time.UTC)`
`312`	`312`
`313`		- _, err = db.Exec(`CREATE TABLE IF NOT EXISTS test (at DATETIME)`)
	`313`	+ _, err = db.Exec(`CREATE TABLE test (at DATETIME)`)
`314`	`314`	`if err != nil {`
`315`	`315`	`t.Fatal(err)`
`316`	`316`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ func ExampleSavepoint() {`
`16`	`16`	`}`
`17`	`17`	`defer db.Close()`
`18`	`18`
`19`		- _, err = db.Exec(`CREATE TABLE IF NOT EXISTS users (id INT, name VARCHAR(10))`)
	`19`	+ _, err = db.Exec(`CREATE TABLE users (id INT, name VARCHAR(10))`)
`20`	`20`	`if err != nil {`
`21`	`21`	`log.Fatal(err)`
`22`	`22`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ func Example() {`
`16`	`16`	`log.Fatal(err)`
`17`	`17`	`}`
`18`	`18`
`19`		- err = db.Exec(`CREATE TABLE IF NOT EXISTS users (id INT, name VARCHAR(10))`)
	`19`	+ err = db.Exec(`CREATE TABLE users (id INT, name VARCHAR(10))`)
`20`	`20`	`if err != nil {`
`21`	`21`	`log.Fatal(err)`
`22`	`22`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ func TestRegister_variance(t *testing.T) {`
`20`	`20`
`21`	`21`	`stats.Register(db)`
`22`	`22`
`23`		- err = db.Exec(`CREATE TABLE IF NOT EXISTS data (x)`)
	`23`	+ err = db.Exec(`CREATE TABLE data (x)`)
`24`	`24`	`if err != nil {`
`25`	`25`	`t.Fatal(err)`
`26`	`26`	`}`
`@@ -92,7 +92,7 @@ func TestRegister_covariance(t *testing.T) {`
`92`	`92`
`93`	`93`	`stats.Register(db)`
`94`	`94`
`95`		- err = db.Exec(`CREATE TABLE IF NOT EXISTS data (y, x)`)
	`95`	+ err = db.Exec(`CREATE TABLE data (y, x)`)
`96`	`96`	`if err != nil {`
`97`	`97`	`t.Fatal(err)`
`98`	`98`	`}`
Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ func TestRegister_collation(t *testing.T) {`
`81`	`81`
`82`	`82`	`Register(db)`
`83`	`83`
`84`		- err = db.Exec(`CREATE TABLE IF NOT EXISTS words (word VARCHAR(10))`)
	`84`	+ err = db.Exec(`CREATE TABLE words (word VARCHAR(10))`)
`85`	`85`	`if err != nil {`
`86`	`86`	`t.Fatal(err)`
`87`	`87`	`}`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ func ExampleConn_CreateCollation() {`
`18`	`18`	`}`
`19`	`19`	`defer db.Close()`
`20`	`20`
`21`		- err = db.Exec(`CREATE TABLE IF NOT EXISTS words (word VARCHAR(10))`)
	`21`	+ err = db.Exec(`CREATE TABLE words (word VARCHAR(10))`)
`22`	`22`	`if err != nil {`
`23`	`23`	`log.Fatal(err)`
`24`	`24`	`}`
`@@ -66,7 +66,7 @@ func ExampleConn_CreateFunction() {`
`66`	`66`	`}`
`67`	`67`	`defer db.Close()`
`68`	`68`
`69`		- err = db.Exec(`CREATE TABLE IF NOT EXISTS words (word VARCHAR(10))`)
	`69`	+ err = db.Exec(`CREATE TABLE words (word VARCHAR(10))`)
`70`	`70`	`if err != nil {`
`71`	`71`	`log.Fatal(err)`
`72`	`72`	`}`
`@@ -111,7 +111,7 @@ func ExampleContext_SetAuxData() {`
`111`	`111`	`}`
`112`	`112`	`defer db.Close()`
`113`	`113`
`114`		- err = db.Exec(`CREATE TABLE IF NOT EXISTS words (word VARCHAR(10))`)
	`114`	+ err = db.Exec(`CREATE TABLE words (word VARCHAR(10))`)
`115`	`115`	`if err != nil {`
`116`	`116`	`log.Fatal(err)`
`117`	`117`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ func ExampleConn_CreateWindowFunction() {`
`16`	`16`	`}`
`17`	`17`	`defer db.Close()`
`18`	`18`
`19`		- err = db.Exec(`CREATE TABLE IF NOT EXISTS words (word VARCHAR(10))`)
	`19`	+ err = db.Exec(`CREATE TABLE words (word VARCHAR(10))`)
`20`	`20`	`if err != nil {`
`21`	`21`	`log.Fatal(err)`
`22`	`22`	`}`