Don't panic on memory commit failure. (#154)

ncruces · web-flow · commit b5adcacec4b6 · 2024-10-06T00:06:43.000+01:00
diff --git a/internal/alloc/alloc_unix.go b/internal/alloc/alloc_unix.go
@@ -47,7 +47,7 @@ func (m *mmappedMemory) Reallocate(size uint64) []byte {
 		// Commit additional memory up to new bytes.
 		err := unix.Mprotect(m.buf[com:new], unix.PROT_READ|unix.PROT_WRITE)
 		if err != nil {
-			panic(err)
+			return nil
 		}
 
 		// Update committed memory.
diff --git a/internal/alloc/alloc_windows.go b/internal/alloc/alloc_windows.go
@@ -56,7 +56,7 @@ func (m *virtualMemory) Reallocate(size uint64) []byte {
 		// Commit additional memory up to new bytes.
 		_, err := windows.VirtualAlloc(m.addr, uintptr(new), windows.MEM_COMMIT, windows.PAGE_READWRITE)
 		if err != nil {
-			panic(err)
+			return nil
 		}
 
 		// Update committed memory.

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ func (m *mmappedMemory) Reallocate(size uint64) []byte {`
`47`	`47`	`// Commit additional memory up to new bytes.`
`48`	`48`	`err := unix.Mprotect(m.buf[com:new], unix.PROT_READ\|unix.PROT_WRITE)`
`49`	`49`	`if err != nil {`
`50`		`- panic(err)`
	`50`	`+ return nil`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`// Update committed memory.`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ func (m *virtualMemory) Reallocate(size uint64) []byte {`
`56`	`56`	`// Commit additional memory up to new bytes.`
`57`	`57`	`_, err := windows.VirtualAlloc(m.addr, uintptr(new), windows.MEM_COMMIT, windows.PAGE_READWRITE)`
`58`	`58`	`if err != nil {`
`59`		`- panic(err)`
	`59`	`+ return nil`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`// Update committed memory.`