Skip to content

Commit 65ab8c8

Browse files
author
Nako Sung
committed
Merged from dev
1 parent 87838e7 commit 65ab8c8

File tree

4 files changed

+9
-4
lines changed

4 files changed

+9
-4
lines changed

Plugins/UnrealJS/Source/V8/Private/FunctionCall.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,14 @@
22
#include "Translator.h"
33
#include "Exception.h"
44
#include "Helpers.h"
5+
#include "JavascriptStats.h"
56

67
namespace v8
78
{
89
void CallJavascriptFunction(Handle<Context> context, Handle<Value> This, UFunction* SignatureFunction, Handle<Function> func, void* Parms)
910
{
11+
SCOPE_CYCLE_COUNTER(STAT_JavascriptFunctionCallToJavascript);
12+
1013
auto isolate = context->GetIsolate();
1114

1215
HandleScope handle_scope(isolate);

Plugins/UnrealJS/Source/V8/Private/JavascriptIsolate_Private.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1142,7 +1142,7 @@ class FJavascriptIsolateImplementation : public FJavascriptIsolate
11421142
template <typename Fn>
11431143
static Local<Value> CallFunction(Isolate* isolate, Local<Value> self, UFunction* Function, UObject* Object, Fn&& GetArg)
11441144
{
1145-
SCOPE_CYCLE_COUNTER(STAT_JavascriptFunctionCall);
1145+
SCOPE_CYCLE_COUNTER(STAT_JavascriptFunctionCallToEngine);
11461146

11471147
FIsolateHelper I(isolate);
11481148

Plugins/UnrealJS/Source/V8/Private/JavascriptStats.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ DECLARE_CYCLE_STAT_EXTERN(TEXT("Delegate"), STAT_JavascriptDelegate, STATGROUP_J
1111
DECLARE_CYCLE_STAT_EXTERN(TEXT("Proxy"), STAT_JavascriptProxy, STATGROUP_Javascript, V8_API);
1212
DECLARE_CYCLE_STAT_EXTERN(TEXT("get"), STAT_JavascriptPropertyGet, STATGROUP_Javascript, V8_API);
1313
DECLARE_CYCLE_STAT_EXTERN(TEXT("set"), STAT_JavascriptPropertySet, STATGROUP_Javascript, V8_API);
14-
DECLARE_CYCLE_STAT_EXTERN(TEXT("call"), STAT_JavascriptFunctionCall, STATGROUP_Javascript, V8_API);
14+
DECLARE_CYCLE_STAT_EXTERN(TEXT("<ue>"), STAT_JavascriptFunctionCallToEngine, STATGROUP_Javascript, V8_API);
15+
DECLARE_CYCLE_STAT_EXTERN(TEXT("<js>"), STAT_JavascriptFunctionCallToJavascript, STATGROUP_Javascript, V8_API);
1516

1617
DECLARE_CYCLE_STAT_EXTERN(TEXT("struct(naive)"), STAT_JavascriptReadOffStruct, STATGROUP_Javascript, V8_API);
1718

Plugins/UnrealJS/Source/V8/Private/V8Module.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ DEFINE_STAT(STAT_ProcessWeakCallbacks);
1313

1414
DEFINE_STAT(STAT_JavascriptPropertyGet);
1515
DEFINE_STAT(STAT_JavascriptPropertySet);
16-
DEFINE_STAT(STAT_JavascriptFunctionCall);
16+
DEFINE_STAT(STAT_JavascriptFunctionCallToEngine);
17+
DEFINE_STAT(STAT_JavascriptFunctionCallToJavascript);
1718
DEFINE_STAT(STAT_JavascriptReadOffStruct);
1819

1920
DEFINE_STAT(STAT_NewSpace);
@@ -45,7 +46,7 @@ class V8Module : public IV8
4546
V8::InitializePlatform(platform_);
4647
V8::Initialize();
4748

48-
auto v8flags = "--harmony --harmony-shipping --es-staging --expose-debug-as=v8debug --expose-gc --harmony_destructuring --harmony_simd --harmony_default_parameters ";
49+
auto v8flags = "--harmony --harmony-shipping --es-staging --expose-debug-as=v8debug --expose-gc --harmony_destructuring --harmony_simd --harmony_default_parameters";// --trace_deopt --trace_opt --trace_opt_verbose --code_comments";
4950
V8::SetFlagsFromString(v8flags, strlen(v8flags));
5051
}
5152

0 commit comments

Comments
 (0)