profiling...

Author: nakosung

Plugins/UnrealJS/Source/V8/Private/JavascriptIsolate_Private.cpp

@@ -86,6 +86,10 @@ class FJavascriptIsolateImplementation : public FJavascriptIsolate
 
 			if (IsValid(Object))
 			{
+				FScopeCycleCounterUObject ContextScope(Object);
+				FScopeCycleCounterUObject PropertyScope(Property);				
+				SCOPE_CYCLE_COUNTER(STAT_JavascriptPropertyGet);
+
 				if (auto p = Cast<UMulticastDelegateProperty>(Property))
 				{
 					return GetSelf(isolate)->Delegates->GetProxy(self, Object, p);
@@ -156,6 +160,10 @@ class FJavascriptIsolateImplementation : public FJavascriptIsolate
 
 			if (IsValid(Object))
 			{
+				FScopeCycleCounterUObject ContextScope(Object);
+				FScopeCycleCounterUObject PropertyScope(Property);
+				SCOPE_CYCLE_COUNTER(STAT_JavascriptPropertySet);
+
 				// Multicast delegate
 				if (auto p = Cast<UMulticastDelegateProperty>(Property))
 				{
@@ -545,8 +553,24 @@ class FJavascriptIsolateImplementation : public FJavascriptIsolate
 
 	void ReadOffStruct(Local<Object> v8_obj, UStruct* Struct, uint8* struct_buffer)
 	{
+		SCOPE_CYCLE_COUNTER(STAT_JavascriptReadOffStruct);
+		FScopeCycleCounterUObject StructContext(Struct);
+
 		FIsolateHelper I(isolate_);
 
+		/*
+		MaybeLocal<Array> _arr = v8_obj->GetOwnPropertyNames();
+		if (_arr.IsEmpty()) return;
+
+		auto arr = _arr.ToLocalChecked();
+
+		auto len = arr->Length();
+
+		for (decltype(len) Index = 0; Index < len; ++Index)
+		{
+		}
+		*/
+
 		for (TFieldIterator<UProperty> PropertyIt(Struct, EFieldIteratorFlags::IncludeSuper); PropertyIt; ++PropertyIt)
 		{
 			auto Property = *PropertyIt;
@@ -902,6 +926,7 @@ class FJavascriptIsolateImplementation : public FJavascriptIsolate
 			if (info.Length() == 1)
 			{				
 				auto Profile = profiler->StopProfiling(info[0].As<String>());
+				if (!Profile) return;
 
 				auto Out = Object::New(isolate);
 				Out->Set(I.Keyword("Root"), Visit(isolate, Profile->GetTopDownRoot()));
@@ -1117,6 +1142,8 @@ class FJavascriptIsolateImplementation : public FJavascriptIsolate
 	template <typename Fn>
 	static Local<Value> CallFunction(Isolate* isolate, Local<Value> self, UFunction* Function, UObject* Object, Fn&& GetArg) 
 	{
+		SCOPE_CYCLE_COUNTER(STAT_JavascriptFunctionCall);
+
 		FIsolateHelper I(isolate);
 
 		EscapableHandleScope handle_scope(isolate);

Plugins/UnrealJS/Source/V8/Private/JavascriptStats.h

@@ -9,6 +9,11 @@ DECLARE_CYCLE_STAT_EXTERN(TEXT("ProcessWeakCallbacks"), STAT_ProcessWeakCallback
 
 DECLARE_CYCLE_STAT_EXTERN(TEXT("Delegate"), STAT_JavascriptDelegate, STATGROUP_Javascript, V8_API);
 DECLARE_CYCLE_STAT_EXTERN(TEXT("Proxy"), STAT_JavascriptProxy, STATGROUP_Javascript, V8_API);
+DECLARE_CYCLE_STAT_EXTERN(TEXT("get"), STAT_JavascriptPropertyGet, STATGROUP_Javascript, V8_API);
+DECLARE_CYCLE_STAT_EXTERN(TEXT("set"), STAT_JavascriptPropertySet, STATGROUP_Javascript, V8_API);
+DECLARE_CYCLE_STAT_EXTERN(TEXT("call"), STAT_JavascriptFunctionCall, STATGROUP_Javascript, V8_API);
+
+DECLARE_CYCLE_STAT_EXTERN(TEXT("struct(naive)"), STAT_JavascriptReadOffStruct, STATGROUP_Javascript, V8_API);
 
 DECLARE_MEMORY_STAT_EXTERN(TEXT("NewSpace"), STAT_NewSpace, STATGROUP_Javascript, V8_API);
 DECLARE_MEMORY_STAT_EXTERN(TEXT("OldSpace"), STAT_OldSpace, STATGROUP_Javascript, V8_API);

Plugins/UnrealJS/Source/V8/Private/V8Module.cpp

@@ -11,6 +11,11 @@ DEFINE_STAT(STAT_MarkSweepCompact);
 DEFINE_STAT(STAT_IncrementalMarking);
 DEFINE_STAT(STAT_ProcessWeakCallbacks);
 
+DEFINE_STAT(STAT_JavascriptPropertyGet);
+DEFINE_STAT(STAT_JavascriptPropertySet);
+DEFINE_STAT(STAT_JavascriptFunctionCall);
+DEFINE_STAT(STAT_JavascriptReadOffStruct);
+
 DEFINE_STAT(STAT_NewSpace);
 DEFINE_STAT(STAT_OldSpace);
 DEFINE_STAT(STAT_CodeSpace);