phar: Avoid memory allocation in setAlias() error code

ndossche · ndossche · commit 0dd2da190cee · 2025-10-12T23:46:19.000+02:00
diff --git a/ext/phar/phar_object.c b/ext/phar/phar_object.c
@@ -2730,13 +2730,10 @@ PHP_METHOD(Phar, setAlias)
 		RETURN_TRUE;
 	}
 	if (NULL != (fd_ptr = zend_hash_find_ptr(&(PHAR_G(phar_alias_map)), new_alias))) {
-		spprintf(&error, 0, "alias \"%s\" is already used for archive \"%s\" and cannot be used for other archives", ZSTR_VAL(new_alias), fd_ptr->fname);
 		if (SUCCESS == phar_free_alias(fd_ptr, ZSTR_VAL(new_alias), ZSTR_LEN(new_alias))) {
-			efree(error);
 			goto valid_alias;
 		}
-		zend_throw_exception_ex(phar_ce_PharException, 0, "%s", error);
-		efree(error);
+		zend_throw_exception_ex(phar_ce_PharException, 0, "alias \"%s\" is already used for archive \"%s\" and cannot be used for other archives", ZSTR_VAL(new_alias), fd_ptr->fname);
 		RETURN_THROWS();
 	}
 	if (!phar_validate_alias(ZSTR_VAL(new_alias), ZSTR_LEN(new_alias))) {

Original file line number	Diff line number	Diff line change
`@@ -2730,13 +2730,10 @@ PHP_METHOD(Phar, setAlias)`
`2730`	`2730`	`RETURN_TRUE;`
`2731`	`2731`	`}`
`2732`	`2732`	`if (NULL != (fd_ptr = zend_hash_find_ptr(&(PHAR_G(phar_alias_map)), new_alias))) {`
`2733`		`- spprintf(&error, 0, "alias \"%s\" is already used for archive \"%s\" and cannot be used for other archives", ZSTR_VAL(new_alias), fd_ptr->fname);`
`2734`	`2733`	`if (SUCCESS == phar_free_alias(fd_ptr, ZSTR_VAL(new_alias), ZSTR_LEN(new_alias))) {`
`2735`		`- efree(error);`
`2736`	`2734`	`goto valid_alias;`
`2737`	`2735`	`}`
`2738`		`- zend_throw_exception_ex(phar_ce_PharException, 0, "%s", error);`
`2739`		`- efree(error);`
	`2736`	`+ zend_throw_exception_ex(phar_ce_PharException, 0, "alias \"%s\" is already used for archive \"%s\" and cannot be used for other archives", ZSTR_VAL(new_alias), fd_ptr->fname);`
`2740`	`2737`	`RETURN_THROWS();`
`2741`	`2738`	`}`
`2742`	`2739`	`if (!phar_validate_alias(ZSTR_VAL(new_alias), ZSTR_LEN(new_alias))) {`