Skip to content

Commit 1cb539d

Browse files
committed
Merge branch 'PHP-8.4' into PHP-8.5
* PHP-8.4: Fix arginfo/zpp violations when LIBXML_SCHEMAS_ENABLED is not available
2 parents bc76b3f + 990e05e commit 1cb539d

File tree

1 file changed

+10
-18
lines changed

1 file changed

+10
-18
lines changed

ext/xmlreader/php_xmlreader.c

Lines changed: 10 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -517,12 +517,7 @@ static void php_xmlreader_no_arg_string(INTERNAL_FUNCTION_PARAMETERS, xmlreader_
517517

518518
/* {{{ php_xmlreader_set_relaxng_schema */
519519
static void php_xmlreader_set_relaxng_schema(INTERNAL_FUNCTION_PARAMETERS, int type) {
520-
#ifdef LIBXML_SCHEMAS_ENABLED
521-
zval *id;
522520
size_t source_len = 0;
523-
int retval = -1;
524-
xmlreader_object *intern;
525-
xmlRelaxNGPtr schema = NULL;
526521
char *source;
527522

528523
if (zend_parse_parameters(ZEND_NUM_ARGS(), "p!", &source, &source_len) == FAILURE) {
@@ -533,11 +528,13 @@ static void php_xmlreader_set_relaxng_schema(INTERNAL_FUNCTION_PARAMETERS, int t
533528
zend_argument_must_not_be_empty_error(1);
534529
RETURN_THROWS();
535530
}
536-
537-
id = ZEND_THIS;
538-
539-
intern = Z_XMLREADER_P(id);
531+
532+
#ifdef LIBXML_SCHEMAS_ENABLED
533+
xmlreader_object *intern = Z_XMLREADER_P(ZEND_THIS);
540534
if (intern->ptr) {
535+
int retval = -1;
536+
xmlRelaxNGPtr schema = NULL;
537+
541538
if (source) {
542539
schema = _xmlreader_get_relaxNG(source, source_len, type, NULL, NULL);
543540
if (schema) {
@@ -1079,11 +1076,7 @@ PHP_METHOD(XMLReader, readString)
10791076
/* {{{ Use W3C XSD schema to validate the document as it is processed. Activation is only possible before the first Read(). */
10801077
PHP_METHOD(XMLReader, setSchema)
10811078
{
1082-
#ifdef LIBXML_SCHEMAS_ENABLED
1083-
zval *id;
10841079
size_t source_len = 0;
1085-
int retval = -1;
1086-
xmlreader_object *intern;
10871080
char *source;
10881081

10891082
if (zend_parse_parameters(ZEND_NUM_ARGS(), "p!", &source, &source_len) == FAILURE) {
@@ -1094,13 +1087,12 @@ PHP_METHOD(XMLReader, setSchema)
10941087
zend_argument_must_not_be_empty_error(1);
10951088
RETURN_THROWS();
10961089
}
1097-
1098-
id = ZEND_THIS;
1099-
1100-
intern = Z_XMLREADER_P(id);
1090+
1091+
#ifdef LIBXML_SCHEMAS_ENABLED
1092+
xmlreader_object *intern = Z_XMLREADER_P(ZEND_THIS);
11011093
if (intern && intern->ptr) {
11021094
PHP_LIBXML_SANITIZE_GLOBALS(schema);
1103-
retval = xmlTextReaderSchemaValidate(intern->ptr, source);
1095+
int retval = xmlTextReaderSchemaValidate(intern->ptr, source);
11041096
PHP_LIBXML_RESTORE_GLOBALS(schema);
11051097

11061098
if (retval == 0) {

0 commit comments

Comments
 (0)