Skip to content

Commit 4d1b0c7

Browse files
committed
Don't need get_gc probably
1 parent c50687e commit 4d1b0c7

File tree

1 file changed

+1
-30
lines changed

1 file changed

+1
-30
lines changed

ext/spl/spl_iterators.c

Lines changed: 1 addition & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -3203,35 +3203,6 @@ void spl_iterator_zip_rewind(zend_object_iterator *iter)
32033203
}
32043204
}
32053205

3206-
static HashTable *spl_iterator_zip_get_gc(zend_object_iterator *iter, zval **table, int *n)
3207-
{
3208-
spl_zip_iterator *zip_iterator = (spl_zip_iterator *) iter;
3209-
3210-
HashTable *ht_slot = NULL;
3211-
3212-
// TODO: there can only be one gc_buffer active at a time
3213-
3214-
for (uint32_t i = 0; i < zip_iterator->iterator_count; i++) {
3215-
// TODO: array ????
3216-
spl_zip_iterator_entry *current = &zip_iterator->iterators[i];
3217-
if (spl_zip_iterator_is_obj_entry(current)) {
3218-
if (current->obj_iter->funcs->get_gc) {
3219-
//HashTable *ht = current->obj_iter->funcs->get_gc(current->obj_iter, tmp_table, tmp_n);
3220-
if (ht_slot) {
3221-
3222-
} else {
3223-
//ht_slot = ht;
3224-
}
3225-
}
3226-
}
3227-
}
3228-
3229-
*table = NULL;
3230-
*n = 0;
3231-
3232-
return ht_slot;
3233-
}
3234-
32353206
static const zend_object_iterator_funcs spl_iterator_zip_funcs = {
32363207
spl_iterator_zip_dtor,
32373208
spl_iterator_zip_valid,
@@ -3240,7 +3211,7 @@ static const zend_object_iterator_funcs spl_iterator_zip_funcs = {
32403211
spl_iterator_zip_move_forward,
32413212
spl_iterator_zip_rewind,
32423213
NULL, /* invalidate_current */ // TODO ???
3243-
spl_iterator_zip_get_gc, /* get_gc */
3214+
NULL, /* get_gc */
32443215
};
32453216

32463217
// TODO: by ref support ??? (what happens now when we have a ref-returning generator?)

0 commit comments

Comments
 (0)