dom: Remove pointless checks when setting options

ndossche · ndossche · commit 571f119f1d63 · 2025-10-10T22:24:26.000+02:00
diff --git a/ext/dom/document.c b/ext/dom/document.c
@@ -1432,16 +1432,16 @@ xmlDocPtr dom_document_parser(zval *id, dom_load_mode mode, const char *source,
 		ctxt->sax->warning = php_libxml_ctx_warning;
 	}
 
-	if (validate && ! (options & XML_PARSE_DTDVALID)) {
+	if (validate) {
 		options |= XML_PARSE_DTDVALID;
 	}
-	if (resolve_externals && ! (options & XML_PARSE_DTDATTR)) {
+	if (resolve_externals) {
 		options |= XML_PARSE_DTDATTR;
 	}
-	if (substitute_ent && ! (options & XML_PARSE_NOENT)) {
+	if (substitute_ent) {
 		options |= XML_PARSE_NOENT;
 	}
-	if (keep_blanks == 0 && ! (options & XML_PARSE_NOBLANKS)) {
+	if (keep_blanks == 0) {
 		options |= XML_PARSE_NOBLANKS;
 	}
 	if (recover) {

Original file line number	Diff line number	Diff line change
`@@ -1432,16 +1432,16 @@ xmlDocPtr dom_document_parser(zval id, dom_load_mode mode, const char source,`
`1432`	`1432`	`ctxt->sax->warning = php_libxml_ctx_warning;`
`1433`	`1433`	`}`
`1434`	`1434`
`1435`		`- if (validate && ! (options & XML_PARSE_DTDVALID)) {`
	`1435`	`+ if (validate) {`
`1436`	`1436`	`options \|= XML_PARSE_DTDVALID;`
`1437`	`1437`	`}`
`1438`		`- if (resolve_externals && ! (options & XML_PARSE_DTDATTR)) {`
	`1438`	`+ if (resolve_externals) {`
`1439`	`1439`	`options \|= XML_PARSE_DTDATTR;`
`1440`	`1440`	`}`
`1441`		`- if (substitute_ent && ! (options & XML_PARSE_NOENT)) {`
	`1441`	`+ if (substitute_ent) {`
`1442`	`1442`	`options \|= XML_PARSE_NOENT;`
`1443`	`1443`	`}`
`1444`		`- if (keep_blanks == 0 && ! (options & XML_PARSE_NOBLANKS)) {`
	`1444`	`+ if (keep_blanks == 0) {`
`1445`	`1445`	`options \|= XML_PARSE_NOBLANKS;`
`1446`	`1446`	`}`
`1447`	`1447`	`if (recover) {`