Fix memory leak on error return of collation callback in pdo_sqlite

We should destroy it when it's not IS_LONG, not when it's IS_LONG.

Closes phpGH-18332.

Author: ndossche

NEWS

@@ -45,6 +45,9 @@ PHP                                                                        NEWS
   . Fixed GH-18276 - persistent connection - "zend_mm_heap corrupted"
     with setAttribute() (SakiTakamachi).
 
+- PDO Sqlite:
+  . Fix memory leak on error return of collation callback. (nielsdos)
+
 - SPL:
   . Fixed bug GH-18322 (SplObjectStorage debug handler mismanages memory).
     (nielsdos)

ext/pdo_sqlite/pdo_sqlite.c

@@ -352,14 +352,14 @@ static int php_sqlite_collation_callback(void *context, int string1_len, const v
 			zend_type_error("%s(): Return value of the callback must be of type int, %s returned",
 				ZSTR_VAL(func_name), zend_zval_value_name(&retval));
 			zend_string_release(func_name);
+			zval_ptr_dtor(&retval);
 			return FAILURE;
 		}
 		if (Z_LVAL(retval) > 0) {
 			ret = 1;
 		} else if (Z_LVAL(retval) < 0) {
 			ret = -1;
 		}
-		zval_ptr_dtor(&retval);
 	}
 
 	zval_ptr_dtor(&zargs[0]);