Remove pointless conversion from UNDEF to NULL

ndossche · ndossche · commit e21de85b9ffe · 2024-12-29T18:18:38.000+01:00
diff --git a/ext/simplexml/simplexml.c b/ext/simplexml/simplexml.c
@@ -268,7 +268,7 @@ static zval *sxe_prop_dim_read(zend_object *object, zval *member, bool elements,
 		}
 	}
 
-	ZVAL_UNDEF(rv);
+	ZVAL_NULL(rv);
 
 	if (node) {
 		if (attribs) {
@@ -338,10 +338,6 @@ static zval *sxe_prop_dim_read(zend_object *object, zval *member, bool elements,
 		zval_ptr_dtor_str(&tmp_zv);
 	}
 
-	if (Z_ISUNDEF_P(rv)) {
-		ZVAL_NULL(rv);
-	}
-
 	return rv;
 }
 /* }}} */

Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,7 @@ static zval sxe_prop_dim_read(zend_object object, zval *member, bool elements,`
`268`	`268`	`}`
`269`	`269`	`}`
`270`	`270`
`271`		`- ZVAL_UNDEF(rv);`
	`271`	`+ ZVAL_NULL(rv);`
`272`	`272`
`273`	`273`	`if (node) {`
`274`	`274`	`if (attribs) {`
`@@ -338,10 +338,6 @@ static zval sxe_prop_dim_read(zend_object object, zval *member, bool elements,`
`338`	`338`	`zval_ptr_dtor_str(&tmp_zv);`
`339`	`339`	`}`
`340`	`340`
`341`		`- if (Z_ISUNDEF_P(rv)) {`
`342`		`- ZVAL_NULL(rv);`
`343`		`- }`
`344`		`-`
`345`	`341`	`return rv;`
`346`	`342`	`}`
`347`	`343`	`/* }}} */`