forked from bytecodealliance/wasmtime
-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Description
Benchmarking requires functionality to print the names of Inst variants. This functionality should be re-used as pointed out by @nagisa in this comment:
[...] I think we should also consider reusing this for
print_with_stateto maintain consistent names across various places where we print these instructions. This shouldn't be too hard (although the diff will not be minimal) and can be achieved roughly through:let mut output = String::with_capacity(32); output.push_str(self.print_name()); match self { Inst::Udf { trap_code } => write!(&mut output, "##trap_code={trap_code}"), ... }This should also reveal that e.g.
Inst::Selectis actually considered multiple different instructions depending on atyfield. It might or might not be useful to split them out for histogram purposes as well.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels