review fixes

Author: nickpismenkov

crates/api/src/openapi.rs

@@ -102,6 +102,7 @@ use utoipa::OpenApi;
         crate::routes::agents::stop_instance,
         crate::routes::agents::restart_instance,
         crate::routes::agents::upgrade_instance,
+        crate::routes::agents::check_upgrade_available,
         crate::routes::admin::admin_create_backup,
         crate::routes::admin::admin_list_backups,
         crate::routes::admin::admin_get_backup,
@@ -188,6 +189,7 @@ use utoipa::OpenApi;
         crate::models::UsageResponse,
         crate::models::BalanceResponse,
         crate::models::UsageQueryParams,
+        crate::routes::agents::UpgradeAvailabilityResponse,
         // BI metrics (admin)
         crate::routes::admin::BiDeploymentQuery,
         crate::routes::admin::BiSummaryQuery,

crates/api/tests/agent_e2e_tests.rs

@@ -1,6 +1,6 @@
 mod common;
 
-use common::{create_test_server_and_db, mock_login, TestServerConfig};
+use common::{create_test_server_and_db, insert_test_subscription, mock_login, TestServerConfig};
 use serde_json::json;
 use uuid::Uuid;
 use wiremock::{matchers::method, Mock, MockServer, ResponseTemplate};
@@ -46,6 +46,9 @@ async fn test_agent_complete_workflow() {
     let _admin_token = mock_login(&server, admin_email).await;
     let user_token = mock_login(&server, user_email).await;
 
+    // Set up a test subscription for the user to avoid 402 errors
+    insert_test_subscription(&server, &db, user_email, false).await;
+
     // Get user_id for the regular user (needed for instance creation)
     let user_response = server
         .get("/v1/users/me")

crates/services/src/agent/service.rs

@@ -1457,9 +1457,8 @@ impl AgentService for AgentServiceImpl {
         // This handles cases where instance is not yet fully provisioned or synced
         if instance_resp.status() == reqwest::StatusCode::NOT_FOUND {
             tracing::warn!(
-                "Instance not found on Agent Manager: instance_id={}, instance_name={}. Blocking upgrade until instance is synced.",
-                instance_id,
-                instance.name
+                "Instance not found on Agent Manager: instance_id={}. Blocking upgrade until instance is synced.",
+                instance_id
             );
             return Ok(UpgradeAvailability {
                 has_upgrade: false,