Skip to content
This repository was archived by the owner on Dec 29, 2019. It is now read-only.

Commit 9304552

Browse files
committed
Possible fix for issues resulting from incorrectly using buffered streams.
1 parent 887b730 commit 9304552

File tree

5 files changed

+13
-14
lines changed

5 files changed

+13
-14
lines changed

src/main/java/com/peak/salut/BackgroundClientRegistrationJob.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,19 +51,18 @@ public void doOnBackground() {
5151
//TODO Use buffered streams.
5252
Log.v(Salut.TAG, "Sending client registration data to server...");
5353
String serializedClient = LoganSquare.serialize(salutInstance.thisDevice);
54-
BufferedOutputStream bufferedOut = new BufferedOutputStream(registrationSocket.getOutputStream());
55-
DataOutputStream toClient = new DataOutputStream(bufferedOut);
54+
DataOutputStream toClient = new DataOutputStream(registrationSocket.getOutputStream());
5655
toClient.writeUTF(serializedClient);
5756
toClient.flush();
5857

59-
Log.v(Salut.TAG, "Receiving server registration data...");
60-
BufferedInputStream bufferedInput = new BufferedInputStream(registrationSocket.getInputStream());
61-
DataInputStream fromServer = new DataInputStream(bufferedInput);
58+
DataInputStream fromServer = new DataInputStream(registrationSocket.getInputStream());
6259

6360
if(!salutInstance.thisDevice.isRegistered)
6461
{
62+
Log.v(Salut.TAG, "Receiving server registration data...");
6563
String serializedServer = fromServer.readUTF();
6664
SalutDevice serverDevice = LoganSquare.parse(serializedServer, SalutDevice.class);
65+
6766
serverDevice.serviceAddress = registrationSocket.getInetAddress().toString().replace("/", "");
6867
salutInstance.registeredHost = serverDevice;
6968

src/main/java/com/peak/salut/BackgroundDataJob.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import com.arasthel.asyncjob.AsyncJob;
55

66
import java.io.BufferedInputStream;
7+
import java.io.BufferedReader;
78
import java.io.DataInputStream;
89
import java.net.Socket;
910

@@ -27,8 +28,8 @@ public void doOnBackground() {
2728
{
2829
//If this code is reached, a client has connected and transferred data.
2930
Log.v(Salut.TAG, "A device is sending data...");
30-
BufferedInputStream bufferedRead = new BufferedInputStream(clientSocket.getInputStream());
31-
DataInputStream dataStreamFromOtherDevice = new DataInputStream(bufferedRead);
31+
32+
DataInputStream dataStreamFromOtherDevice = new DataInputStream(clientSocket.getInputStream());
3233
data = dataStreamFromOtherDevice.readUTF();
3334
dataStreamFromOtherDevice.close();
3435

src/main/java/com/peak/salut/BackgroundDataSendJob.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,7 @@ public void doOnBackground() {
4343

4444
//If this code is reached, a client has connected and transferred data.
4545
Log.d(Salut.TAG, "Connected, transferring data...");
46-
BufferedOutputStream bufferedOut = new BufferedOutputStream(dataSocket.getOutputStream());
47-
DataOutputStream dataStreamToOtherDevice = new DataOutputStream(bufferedOut);
46+
DataOutputStream dataStreamToOtherDevice = new DataOutputStream(dataSocket.getOutputStream());
4847
String dataToSend = LoganSquare.serialize(data);
4948
dataStreamToOtherDevice.writeUTF(dataToSend);
5049
dataStreamToOtherDevice.flush();

src/main/java/com/peak/salut/BackgroundServerRegistrationJob.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,16 @@ public void doOnBackground() {
2929
Log.d(Salut.TAG, "A device has connected to the server, transferring data...");
3030

3131
Log.v(Salut.TAG, "Receiving client registration data...");
32-
BufferedInputStream bufferInput = new BufferedInputStream(clientSocket.getInputStream());
33-
DataInputStream fromClient = new DataInputStream(bufferInput);
32+
DataInputStream fromClient = new DataInputStream(clientSocket.getInputStream());
3433
String serializedClient = fromClient.readUTF();
3534

35+
System.out.println(serializedClient);
36+
37+
3638
SalutDevice clientDevice = LoganSquare.parse(serializedClient, SalutDevice.class);
3739
clientDevice.serviceAddress = clientSocket.getInetAddress().toString().replace("/", "");
3840

39-
BufferedOutputStream bufferedOut = new BufferedOutputStream(clientSocket.getOutputStream());
40-
DataOutputStream toClient = new DataOutputStream(bufferedOut);
41+
DataOutputStream toClient = new DataOutputStream(clientSocket.getOutputStream());
4142

4243
if (!clientDevice.isRegistered) {
4344

src/main/java/com/peak/salut/SalutBroadcastReciever.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ public void onReceive(Context context, Intent intent) {
4646
NetworkInfo networkInfo = (NetworkInfo) intent.getParcelableExtra(WifiP2pManager.EXTRA_NETWORK_INFO);
4747

4848
if (networkInfo.isConnected() && networkInfo.getTypeName().equals("WIFI_P2P")) {
49-
5049
salutInstance.isConnectedToAnotherDevice = true;
5150
manager.requestConnectionInfo(channel, salutInstance);
5251

0 commit comments

Comments
 (0)