Fix POSIX compliance: replace echo -e with printf

Author: aktech

install.sh

@@ -47,15 +47,15 @@ timestamp() {
 }
 
 info() {
-    echo -e "$(timestamp) ${GREEN}INF${NC} $1"
+    printf "%s %bINF%b %s\n" "$(timestamp)" "${GREEN}" "${NC}" "$1"
 }
 
 warn() {
-    echo -e "$(timestamp) ${YELLOW}WRN${NC} $1"
+    printf "%s %bWRN%b %s\n" "$(timestamp)" "${YELLOW}" "${NC}" "$1"
 }
 
 error() {
-    echo -e "$(timestamp) ${RED}ERR${NC} $1"
+    printf "%s %bERR%b %s\n" "$(timestamp)" "${RED}" "${NC}" "$1"
     exit 1
 }
 
@@ -91,16 +91,16 @@ fetch_url() {
 
     case "$DOWNLOAD_TOOL" in
         curl)
-            curl -s "$url"
+            curl -sS -f "$url" 2>&1
             ;;
         wget)
-            wget -qO- "$url"
+            wget -qO- "$url" 2>&1
             ;;
         python3)
-            python3 -c "import urllib.request; import sys; response = urllib.request.urlopen('$url'); sys.stdout.buffer.write(response.read())"
+            python3 -c "import urllib.request; import sys; response = urllib.request.urlopen('$url'); sys.stdout.buffer.write(response.read())" 2>&1
             ;;
         python)
-            python -c "import urllib.request; import sys; response = urllib.request.urlopen('$url'); sys.stdout.buffer.write(response.read())"
+            python -c "import urllib.request; import sys; response = urllib.request.urlopen('$url'); sys.stdout.buffer.write(response.read())" 2>&1
             ;;
         *)
             error "No download tool available"
@@ -129,19 +129,29 @@ detect_arch() {
 # Get latest release version from GitHub API
 get_latest_version() {
     local version
+    local response
 
     # Try /releases/latest first
-    version=$(fetch_url "https://api.github.com/repos/${REPO}/releases/latest" | grep '"tag_name":' | sed -E 's/.*"([^"]+)".*/\1/')
+    response=$(fetch_url "https://api.github.com/repos/${REPO}/releases/latest" 2>&1)
+    if [ $? -ne 0 ]; then
+        warn "Failed to fetch from /releases/latest endpoint"
+        warn "Response: $response"
+    else
+        version=$(echo "$response" | grep '"tag_name":' | sed -E 's/.*"([^"]+)".*/\1/')
+    fi
 
     # If that fails, get the first non-draft, non-prerelease from /releases
     if [ -z "$version" ]; then
-        version=$(fetch_url "https://api.github.com/repos/${REPO}/releases" | \
-                  grep -m 1 '"tag_name":' | \
-                  sed -E 's/.*"([^"]+)".*/\1/')
+        response=$(fetch_url "https://api.github.com/repos/${REPO}/releases" 2>&1)
+        if [ $? -ne 0 ]; then
+            error "Failed to fetch from /releases endpoint. Response: $response"
+        else
+            version=$(echo "$response" | grep -m 1 '"tag_name":' | sed -E 's/.*"([^"]+)".*/\1/')
+        fi
     fi
 
     if [ -z "$version" ]; then
-        error "Failed to fetch latest version from GitHub"
+        error "Failed to parse version from GitHub API response"
     fi
 
     echo "$version"
@@ -188,7 +198,9 @@ parse_args() {
                 usage
                 ;;
             *)
-                error "Unknown option: $1\nRun '$0 --help' for usage"
+                printf "%s\n" "Unknown option: $1"
+                printf "%s\n" "Run '$0 --help' for usage"
+                exit 1
                 ;;
         esac
     done