Skip to content

Commit 012df8b

Browse files
Darshan808Darshan808
authored
Improve alignment of quick settings menu (#72)
* align-menu-right * fix-menu-alignment * fix-snapshot * fix-snapshot
1 parent 101cafe commit 012df8b

File tree

4 files changed

+241
-284
lines changed

4 files changed

+241
-284
lines changed

‎src/components/quick-settings.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,13 @@ export function QuickSettings(props: {
2626
let x, y;
2727
if (current) {
2828
const position = current.getBoundingClientRect();
29-
x = position.left;
29+
x = position.right;
3030
y = position.bottom;
3131
} else {
3232
x = event.clientX;
3333
y = event.clientY;
3434
}
35-
menu.open(x, y);
35+
menu.open(x, y, { horizontalAlignment: 'right' });
3636
};
3737

3838
return (

‎ui-tests/tests/jupyterlab_new_launcher.spec.ts-snapshots/launcher-open-quicksettings-linux.png‎

17.4 KB
Loading

‎ui-tests/yarn.lock‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ __metadata:
334334
"@jupyterlab/services": ^7.1.6
335335
"@jupyterlab/statedb": ^4.1.6
336336
"@jupyterlab/translation": ^4.1.6
337-
"@jupyterlab/ui-components": ^4.1.6
337+
"@jupyterlab/ui-components": ^4.4.0
338338
"@lumino/algorithm": ^2.0.1
339339
"@lumino/application": ^2.3.0
340340
"@lumino/commands": ^2.2.0
@@ -361,7 +361,7 @@ __metadata:
361361
"@jupyterlab/statedb": ^4.1.6
362362
"@jupyterlab/statusbar": ^4.1.6
363363
"@jupyterlab/translation": ^4.1.6
364-
"@jupyterlab/ui-components": ^4.1.6
364+
"@jupyterlab/ui-components": ^4.4.0
365365
"@lumino/algorithm": ^2.0.1
366366
"@lumino/commands": ^2.2.0
367367
"@lumino/coreutils": ^2.1.2
@@ -413,7 +413,7 @@ __metadata:
413413
"@jupyterlab/services": ^7.1.6
414414
"@jupyterlab/toc": ^6.1.6
415415
"@jupyterlab/translation": ^4.1.6
416-
"@jupyterlab/ui-components": ^4.1.6
416+
"@jupyterlab/ui-components": ^4.4.0
417417
"@lumino/algorithm": ^2.0.1
418418
"@lumino/coreutils": ^2.1.2
419419
"@lumino/domutils": ^2.0.1
@@ -440,7 +440,7 @@ __metadata:
440440
"@jupyterlab/observables": ^5.1.6
441441
"@jupyterlab/statusbar": ^4.1.6
442442
"@jupyterlab/translation": ^4.1.6
443-
"@jupyterlab/ui-components": ^4.1.6
443+
"@jupyterlab/ui-components": ^4.4.0
444444
"@lumino/coreutils": ^2.1.2
445445
"@lumino/disposable": ^2.1.2
446446
"@lumino/dragdrop": ^2.1.4
@@ -510,7 +510,7 @@ __metadata:
510510
"@jupyterlab/rendermime": ^4.1.6
511511
"@jupyterlab/services": ^7.1.6
512512
"@jupyterlab/translation": ^4.1.6
513-
"@jupyterlab/ui-components": ^4.1.6
513+
"@jupyterlab/ui-components": ^4.4.0
514514
"@lumino/coreutils": ^2.1.2
515515
"@lumino/disposable": ^2.1.2
516516
"@lumino/dragdrop": ^2.1.4
@@ -556,7 +556,7 @@ __metadata:
556556
"@jupyterlab/rendermime": ^4.1.6
557557
"@jupyterlab/services": ^7.1.6
558558
"@jupyterlab/translation": ^4.1.6
559-
"@jupyterlab/ui-components": ^4.1.6
559+
"@jupyterlab/ui-components": ^4.4.0
560560
"@lumino/algorithm": ^2.0.1
561561
"@lumino/commands": ^2.2.0
562562
"@lumino/coreutils": ^2.1.2
@@ -582,7 +582,7 @@ __metadata:
582582
"@jupyterlab/services": ^7.1.6
583583
"@jupyterlab/statusbar": ^4.1.6
584584
"@jupyterlab/translation": ^4.1.6
585-
"@jupyterlab/ui-components": ^4.1.6
585+
"@jupyterlab/ui-components": ^4.4.0
586586
"@lumino/algorithm": ^2.0.1
587587
"@lumino/coreutils": ^2.1.2
588588
"@lumino/disposable": ^2.1.2
@@ -608,7 +608,7 @@ __metadata:
608608
"@jupyterlab/rendermime-interfaces": ^3.9.6
609609
"@jupyterlab/services": ^7.1.6
610610
"@jupyterlab/translation": ^4.1.6
611-
"@jupyterlab/ui-components": ^4.1.6
611+
"@jupyterlab/ui-components": ^4.4.0
612612
"@lumino/algorithm": ^2.0.1
613613
"@lumino/coreutils": ^2.1.2
614614
"@lumino/disposable": ^2.1.2
@@ -627,7 +627,7 @@ __metadata:
627627
dependencies:
628628
"@jupyterlab/apputils": ^4.2.6
629629
"@jupyterlab/translation": ^4.1.6
630-
"@jupyterlab/ui-components": ^4.1.6
630+
"@jupyterlab/ui-components": ^4.4.0
631631
"@lumino/commands": ^2.2.0
632632
"@lumino/coreutils": ^2.1.2
633633
"@lumino/disposable": ^2.1.2
@@ -652,7 +652,7 @@ __metadata:
652652
"@jupyterlab/statedb": ^4.1.6
653653
"@jupyterlab/statusbar": ^4.1.6
654654
"@jupyterlab/translation": ^4.1.6
655-
"@jupyterlab/ui-components": ^4.1.6
655+
"@jupyterlab/ui-components": ^4.4.0
656656
"@lumino/algorithm": ^2.0.1
657657
"@lumino/coreutils": ^2.1.2
658658
"@lumino/disposable": ^2.1.2
@@ -683,7 +683,7 @@ __metadata:
683683
"@jupyterlab/statusbar": ^4.1.6
684684
"@jupyterlab/toc": ^6.1.6
685685
"@jupyterlab/translation": ^4.1.6
686-
"@jupyterlab/ui-components": ^4.1.6
686+
"@jupyterlab/ui-components": ^4.4.0
687687
"@lumino/commands": ^2.2.0
688688
"@lumino/coreutils": ^2.1.2
689689
"@lumino/messaging": ^2.0.1
@@ -774,7 +774,7 @@ __metadata:
774774
"@jupyterlab/statusbar": ^4.1.6
775775
"@jupyterlab/toc": ^6.1.6
776776
"@jupyterlab/translation": ^4.1.6
777-
"@jupyterlab/ui-components": ^4.1.6
777+
"@jupyterlab/ui-components": ^4.4.0
778778
"@lumino/algorithm": ^2.0.1
779779
"@lumino/coreutils": ^2.1.2
780780
"@lumino/disposable": ^2.1.2
@@ -910,7 +910,7 @@ __metadata:
910910
version: 4.1.6
911911
resolution: "@jupyterlab/statusbar@npm:4.1.6"
912912
dependencies:
913-
"@jupyterlab/ui-components": ^4.1.6
913+
"@jupyterlab/ui-components": ^4.4.0
914914
"@lumino/algorithm": ^2.0.1
915915
"@lumino/coreutils": ^2.1.2
916916
"@lumino/disposable": ^2.1.2
@@ -933,7 +933,7 @@ __metadata:
933933
"@jupyterlab/rendermime": ^4.1.6
934934
"@jupyterlab/rendermime-interfaces": ^3.9.6
935935
"@jupyterlab/translation": ^4.1.6
936-
"@jupyterlab/ui-components": ^4.1.6
936+
"@jupyterlab/ui-components": ^4.4.0
937937
"@lumino/coreutils": ^2.1.2
938938
"@lumino/disposable": ^2.1.2
939939
"@lumino/messaging": ^2.0.1

0 commit comments

Comments
 (0)