Skip to content

Conversation

@swastik959
Copy link
Contributor

@swastik959 swastik959 commented Nov 12, 2023

Reference Issues or PRs

#2023

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @swastik959, thanks for working on this! Unfortunately I believe the original issue is asking for control over the color for the nebari CLI: https://github.com/nebari-dev/nebari/tree/develop/src/_nebari/subcommands

I also believe some of the changes related to the Google Cloud python API made it into this PR. They should probably be removed from here since they seem to be captured in your other PR: #2083

@swastik959
Copy link
Contributor Author

@iameskild can you tell me where exactly is the color coding for the cli is

@viniciusdc
Copy link
Contributor

viniciusdc commented Jan 30, 2024

Hi @swastik959, the Nebari CLI is built using typer, which uses rich underlying to print the color and markup contents. I assume we could have an extra field --disable-color for the terminal command args, which could toggle the color_system feature for the Console object that's used across Nebari...

app = typer.Typer(
cls=OrderCommands,
help="Nebari CLI 🪴",
add_completion=False,
no_args_is_help=True,
rich_markup_mode="rich",
pretty_exceptions_show_locals=False,
context_settings={"help_option_names": ["-h", "--help"]},
)

If I am right, passing the Console object in theTyper class above is possible. Though I am not sure

@dcmcand dcmcand closed this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants