Merge pull request #81 from nebula-plugins/gmm

enable GMM and remove obsolete idea plugin

Author: wakingrufus

.github/workflows/nebula.yml

@@ -2,7 +2,7 @@ name: Nebula Build
 on:
   push:
     branches:
-      - '*'
+      - 'main'
     tags:
       - v*.*.*
       - v*.*.*-rc.*

src/main/groovy/nebula/plugin/netflixossproject/NetflixOssProjectPlugin.groovy

@@ -40,7 +40,6 @@ import org.gradle.api.plugins.JavaPluginExtension
 import org.gradle.api.publish.maven.tasks.PublishToMavenRepository
 import org.gradle.api.tasks.TaskProvider
 import org.gradle.plugins.ide.eclipse.EclipsePlugin
-import org.gradle.plugins.ide.idea.IdeaPlugin
 
 class NetflixOssProjectPlugin implements Plugin<Project> {
     @Override
@@ -125,7 +124,6 @@ class NetflixOssProjectPlugin implements Plugin<Project> {
             }
         }
         project.plugins.apply InfoPlugin
-        project.plugins.apply IdeaPlugin
         project.plugins.apply EclipsePlugin
 
 

src/main/groovy/nebula/plugin/netflixossproject/publishing/PublishingPlugin.groovy

@@ -15,13 +15,10 @@
  */
 package nebula.plugin.netflixossproject.publishing
 
-import nebula.plugin.netflixossproject.FeatureFlags
 import nebula.plugin.publishing.NebulaOssPublishingPlugin
-import org.gradle.api.Action
 import org.gradle.api.Plugin
 import org.gradle.api.Project
 import org.gradle.api.publish.maven.tasks.PublishToMavenRepository
-import org.gradle.api.publish.tasks.GenerateModuleMetadata
 
 class PublishingPlugin implements Plugin<Project> {
 
@@ -36,33 +33,8 @@ class PublishingPlugin implements Plugin<Project> {
             }
 
             project.rootProject.tasks.named('postRelease').configure {
-                it.dependsOn( project.tasks.withType(PublishToMavenRepository))
+                it.dependsOn(project.tasks.withType(PublishToMavenRepository))
             }
         }
-
-
-        project.plugins.withId('com.github.johnrengelman.shadow') {
-           configureGradleModuleMetadata(project)
-        }
-        project.plugins.withId('com.gradleup.shadow') {
-           configureGradleModuleMetadata(project)
-        }
-    }
-
-    private void configureGradleModuleMetadata(Project project) {
-        boolean gradleModuleMetadataPublishingForShadowPluginEnabled = FeatureFlags.isFeatureEnabled(project, FeatureFlags.GRADLE_METADATA_SHADOW_PUBLISHING_SUPPORT, false)
-        if(gradleModuleMetadataPublishingForShadowPluginEnabled) {
-            return
-        }
-        disableGradleModuleMetadataTask(project)
-    }
-
-    private void disableGradleModuleMetadataTask(Project project) {
-        project.tasks.withType(GenerateModuleMetadata).configureEach(new Action<GenerateModuleMetadata>() {
-            @Override
-            void execute(GenerateModuleMetadata generateModuleMetadataTask) {
-                generateModuleMetadataTask.enabled = false
-            }
-        })
     }
 }

src/test/groovy/nebula/plugin/netflixossproject/NetflixOssMultiProjectSpec.groovy

@@ -51,7 +51,6 @@ class NetflixOssMultiProjectSpec extends ProjectSpec {
         plugin | _
         NebulaOssPublishingPlugin | _
         InfoPlugin | _
-        IdeaPlugin | _
         EclipsePlugin | _
     }
 
@@ -65,7 +64,6 @@ class NetflixOssMultiProjectSpec extends ProjectSpec {
         plugin | _
         NebulaOssPublishingPlugin | _
         InfoPlugin | _
-        IdeaPlugin | _
         EclipsePlugin | _
         DependencyLockPlugin | _
         JavadocJarPlugin | _

src/test/groovy/nebula/plugin/netflixossproject/NetflixOssProjectPluginSpec.groovy

@@ -58,7 +58,6 @@ class NetflixOssProjectPluginSpec extends PluginProjectSpec {
         DependencyLockPlugin | _
         OssLicensePlugin | _
         EclipsePlugin | _
-        IdeaPlugin | _
     }
 
     def 'plugin sets default java version'() {