streamline publish action so it only needs 1 approval

Author: wakingrufus

.github/workflows/release.yml

@@ -6,39 +6,7 @@ on:
       - v*.*.*-rc.*
 
 jobs:
-  validatepluginpublication:
-    runs-on: ubuntu-latest
-    name: Gradle Plugin Publication Validation
-    environment:
-      name: Publish
-      url: "https://repo1.maven.org/maven2/com/netflix/nebula/gradle-nothing-plugin/"
-    env:
-      NETFLIX_OSS_SONATYPE_USERNAME: ${{ secrets.ORG_SONATYPE_USERNAME }}
-      NETFLIX_OSS_SONATYPE_PASSWORD: ${{ secrets.ORG_SONATYPE_PASSWORD }}
-    steps:
-      - uses: actions/checkout@v4
-      - name: Setup git user
-        run: |
-          git config --global user.name "Nebula Plugin Maintainers"
-          git config --global user.email "nebula-plugins-oss@netflix.com"
-      - name: Set up JDKs
-        uses: actions/setup-java@v4
-        with:
-          distribution: 'zulu'
-          java-version: |
-            17
-            21
-          java-package: jdk
-      - name: Setup Gradle
-        uses: gradle/actions/setup-gradle@v5
-        with:
-          cache-overwrite-existing: true
-      - name: Verify plugin publication
-        if: |
-          (!contains(github.ref, '-rc.'))
-        run: ./gradlew  --stacktrace -Dgradle.publish.key=${{ secrets.gradlePublishKey }} -Dgradle.publish.secret=${{ secrets.gradlePublishSecret }}  -Prelease.useLastTag=true final publishPlugin --validate-only -x check
   publish:
-    needs: validatepluginpublication
     runs-on: ubuntu-latest
     name: Gradle Build and Publish
     environment:
@@ -69,11 +37,12 @@ jobs:
         uses: gradle/actions/setup-gradle@v5
         with:
           cache-overwrite-existing: true
+      - name: Verify plugin publication
+        if: (!contains(github.ref, '-rc.'))
+        run: ./gradlew  --stacktrace -Dgradle.publish.key=${{ secrets.gradlePublishKey }} -Dgradle.publish.secret=${{ secrets.gradlePublishSecret }}  -Prelease.useLastTag=true final publishPlugin --validate-only -x check
       - name: Publish candidate
-        if: |
-          contains(github.ref, '-rc.')
+        if: contains(github.ref, '-rc.')
         run: ./gradlew --info --stacktrace -Prelease.useLastTag=true candidate
       - name: Publish release
-        if: |
-          (!contains(github.ref, '-rc.'))
+        if: (!contains(github.ref, '-rc.'))
         run: ./gradlew --stacktrace -Dgradle.publish.key=${{ secrets.gradlePublishKey }} -Dgradle.publish.secret=${{ secrets.gradlePublishSecret }} -Prelease.useLastTag=true final