Remove unused dependencyRulesApplied and make jackson object mapper lazy

Author: rpalcolea

src/main/kotlin/nebula/plugin/resolutionrules/json.kt

@@ -19,6 +19,8 @@ package nebula.plugin.resolutionrules
 import com.fasterxml.jackson.databind.*
 import com.fasterxml.jackson.module.kotlin.jacksonObjectMapper
 
-fun objectMapper(): ObjectMapper {
-    return jacksonObjectMapper()
-}
+/**
+ * Lazily initialized, shared ObjectMapper instance for JSON deserialization.
+ * Thread-safe singleton that is only created when first accessed.
+ */
+val objectMapper: ObjectMapper by lazy { jacksonObjectMapper() }

src/main/kotlin/nebula/plugin/resolutionrules/plugin.kt

@@ -107,7 +107,6 @@ class ResolutionRulesPlugin : Plugin<Project> {
                 return@configureEach
             }
 
-            var dependencyRulesApplied = false
             project.onExecute {
                 val ruleSet = extension.ruleSet()
                 when {
@@ -122,7 +121,6 @@ class ResolutionRulesPlugin : Plugin<Project> {
                         ruleSet.dependencyRulesPartTwo().forEach { rule ->
                             rule.apply(project, config, config.resolutionStrategy, extension)
                         }
-                        dependencyRulesApplied = true
                     }
                 }
             }
@@ -150,7 +148,7 @@ class ResolutionRulesPlugin : Plugin<Project> {
 abstract class NebulaResolutionRulesService : BuildService<NebulaResolutionRulesService.Params> {
     companion object {
         private val Logger: Logger = Logging.getLogger(NebulaResolutionRulesService::class.java)
-        private val Mapper = objectMapper()
+        private val Mapper = objectMapper
 
         fun registerService(project: Project): Provider<NebulaResolutionRulesService> {
             return project.gradle.sharedServices.registerIfAbsent(
@@ -174,7 +172,7 @@ abstract class NebulaResolutionRulesService : BuildService<NebulaResolutionRules
                         "jar", "zip" -> {
                             Logger.info("nebula.resolution-rules is using ruleset: {}", file.name)
                             val zipFile = ZipFile(file)
-                            Collections.list(zipFile.entries()).stream()
+                            zipFile.entries().toList().stream()
                                 .onClose(zipFile::close)
                                 .flatMap { entry ->
                                     val entryFile = File(entry.name)

src/test/groovy/nebula/plugin/resolutionrules/RulesTest.groovy

@@ -73,7 +73,7 @@ class RulesTest extends Specification {
     }
 
     static RuleSet parseJsonText(String json) {
-        def ruleSet = JsonKt.objectMapper().readValue(json, RuleSet)
+        def ruleSet = JsonKt.getObjectMapper().readValue(json, RuleSet)
         return RulesKt.withName(ruleSet, "dummy")
     }
 }