fix print summary to account for info flag (#56)

Author: emilyyuan03

nebula-archrules-gradle-plugin/src/main/kotlin/com/netflix/nebula/archrules/gradle/PrintConsoleReportTask.kt

@@ -46,7 +46,7 @@ abstract class PrintConsoleReportTask : DefaultTask() {
             .flatMap { ViolationsUtil.readDetails(it) }
             .toList()
         val byRule = ViolationsUtil.consolidatedFailures(list)
-        ViolationsUtil.printSummary(byRule, consoleOutput, summaryForPassingDisabled.get())
+        ViolationsUtil.printSummary(byRule, consoleOutput, summaryForPassingDisabled.get(), logger.isInfoEnabled)
         if (list.any {
                 it.status() == RuleResultStatus.FAIL
                         && !it.rule().priority().meetsThreshold(detailsThreshold.orNull)

nebula-archrules-gradle-plugin/src/main/kotlin/com/netflix/nebula/archrules/gradle/ViolationsUtil.kt

@@ -59,7 +59,7 @@ class ViolationsUtil {
         }
 
         @JvmStatic
-        fun printSummary(resultMap: Map<Rule, List<RuleResult>>, output: StyledTextOutput, skipPassing: Boolean) {
+        fun printSummary(resultMap: Map<Rule, List<RuleResult>>, output: StyledTextOutput, skipPassing: Boolean, infoLogging: Boolean) {
             output.style(StyledTextOutput.Style.Header).println("ArchRule Summary:")
             val indent = 4
             val maxRuleNameLength = resultMap.keys.maxOfOrNull { it.ruleName().length } ?: 1
@@ -69,7 +69,7 @@ class ViolationsUtil {
                     classMap.forEach { (rule, results) ->
                         val failures = results.filter { it.status() != RuleResultStatus.PASS }
                         if (failures.isEmpty()) {
-                            if (!skipPassing) {
+                            if (!skipPassing || infoLogging) {
                                 output.style(StyledTextOutput.Style.Success)
                                     .text(" ".repeat(indent))
                                     .text(rule.ruleName().padEnd(maxRuleNameLength + 1))
@@ -107,4 +107,4 @@ class ViolationsUtil {
                 .mapValues { it.value.filter { it.status() != RuleResultStatus.PASS } }
         }
     }
-}
+}

nebula-archrules-gradle-plugin/src/test/kotlin/com/netflix/nebula/archrules/gradle/ViolationsUtilTest.kt

@@ -12,7 +12,7 @@ internal class ViolationsUtilTest {
         val output = MockStyledTextOutput()
         val rule = Rule("RuleClass", "RuleName", "description", Priority.MEDIUM)
         val results = listOf(RuleResult(rule, "message", RuleResultStatus.PASS))
-        ViolationsUtil.printSummary(mapOf(rule to results), output, false)
+        ViolationsUtil.printSummary(mapOf(rule to results), output, false, false)
         assertThat(output.getOutput())
             .contains("RuleClass")
             .contains("RuleName  MEDIUM     (No failures)")
@@ -23,16 +23,27 @@ internal class ViolationsUtilTest {
         val output = MockStyledTextOutput()
         val rule = Rule("RuleClass", "RuleName", "description", Priority.MEDIUM)
         val results = listOf(RuleResult(rule, "message", RuleResultStatus.PASS))
-        ViolationsUtil.printSummary(mapOf(rule to results), output, true)
+        ViolationsUtil.printSummary(mapOf(rule to results), output, true, false)
         assertThat(output.getOutput())
             .contains("RuleClass")
             .doesNotContain("RuleName")
     }
 
+    @Test
+    fun `test printSummary skipPassing but infoLogging on`() {
+        val output = MockStyledTextOutput()
+        val rule = Rule("RuleClass", "RuleName", "description", Priority.MEDIUM)
+        val results = listOf(RuleResult(rule, "message", RuleResultStatus.PASS))
+        ViolationsUtil.printSummary(mapOf(rule to results), output, true, true)
+        assertThat(output.getOutput())
+            .contains("RuleClass")
+            .contains("RuleName  MEDIUM     (No failures)")
+    }
+
     @Test
     fun `test printSummary empty results`() {
         val output = MockStyledTextOutput()
-        ViolationsUtil.printSummary(mapOf(), output, false)
+        ViolationsUtil.printSummary(mapOf(), output, false, false)
         assertThat(output.getOutput()).isEqualTo("ArchRule Summary:\n")
     }
 }
@@ -102,4 +113,4 @@ class MockStyledTextOutput : StyledTextOutput {
         TODO("Not yet implemented")
     }
 
-}
+}