archRules should produce only runtime elements (not api)

this avoids variant selection confusion in consumers

Author: wakingrufus

nebula-archrules-gradle-plugin/gradle.lockfile

@@ -12,7 +12,7 @@ net.javacrumbs.json-unit:json-unit-core:5.0.0=integTestCompileClasspath,integTes
 net.javacrumbs.json-unit:json-unit-json-path:5.0.0=integTestCompileClasspath,integTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath
 net.minidev:accessors-smart:2.5.0=integTestRuntimeClasspath,testRuntimeClasspath
 net.minidev:json-smart:2.5.0=integTestRuntimeClasspath,testRuntimeClasspath
-org.apiguardian:apiguardian-api:1.1.2=integTestCompileClasspath,integTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.apiguardian:apiguardian-api:1.1.2=integTestCompileClasspath,testCompileClasspath
 org.assertj:assertj-core:3.27.6=integTestCompileClasspath,integTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath
 org.hamcrest:hamcrest-core:3.0=integTestCompileClasspath,integTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath
 org.hamcrest:hamcrest:3.0=integTestCompileClasspath,integTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath
@@ -36,17 +36,19 @@ org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.8.0=kotlinBuildToolsApiClass
 org.jetbrains:annotations:13.0=compileClasspath,integTestCompileClasspath,integTestRuntimeClasspath,kotlinBuildToolsApiClasspath,kotlinCompilerClasspath,kotlinCompilerPluginClasspathIntegTest,kotlinCompilerPluginClasspathMain,kotlinCompilerPluginClasspathTest,testCompileClasspath,testRuntimeClasspath
 org.json:json:20250517=integTestCompileClasspath,integTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath
 org.jspecify:jspecify:1.0.0=integTestCompileClasspath,integTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath
-org.junit.jupiter:junit-jupiter-api:5.12.2=integTestCompileClasspath,integTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath
-org.junit.jupiter:junit-jupiter-engine:5.12.2=integTestRuntimeClasspath,testRuntimeClasspath
-org.junit.jupiter:junit-jupiter-params:5.12.2=integTestCompileClasspath,integTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath
-org.junit.jupiter:junit-jupiter:5.12.2=integTestCompileClasspath,integTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.junit.jupiter:junit-jupiter-api:5.14.0=integTestCompileClasspath,integTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.junit.jupiter:junit-jupiter-engine:5.14.0=integTestRuntimeClasspath,testRuntimeClasspath
+org.junit.jupiter:junit-jupiter-params:5.14.0=integTestCompileClasspath,integTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.junit.jupiter:junit-jupiter:5.14.0=integTestCompileClasspath,integTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath
 org.junit.platform:junit-platform-commons:1.14.0=integTestCompileClasspath,integTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath
 org.junit.platform:junit-platform-engine:1.14.0=integTestCompileClasspath,integTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath
 org.junit.platform:junit-platform-launcher:1.14.0=integTestCompileClasspath,integTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.junit:junit-bom:5.14.0=integTestCompileClasspath,integTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath
 org.objenesis:objenesis:2.4=integTestRuntimeClasspath,testRuntimeClasspath
 org.opentest4j:opentest4j:1.3.0=integTestCompileClasspath,integTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath
 org.ow2.asm:asm:9.3=integTestRuntimeClasspath,testRuntimeClasspath
 org.slf4j:slf4j-api:2.0.17=compileClasspath,integTestCompileClasspath,integTestRuntimeClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
 tools.jackson.core:jackson-core:3.0.2=compileClasspath,integTestCompileClasspath,integTestRuntimeClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
 tools.jackson.core:jackson-databind:3.0.2=compileClasspath,integTestCompileClasspath,integTestRuntimeClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+tools.jackson:jackson-bom:3.0.2=compileClasspath,integTestCompileClasspath,integTestRuntimeClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
 empty=annotationProcessor,integTestAnnotationProcessor,integTestKotlinScriptDefExtensions,kotlinScriptDefExtensions,testAnnotationProcessor,testKotlinScriptDefExtensions

nebula-archrules-gradle-plugin/src/main/kotlin/com/netflix/nebula/archrules/gradle/ArchrulesLibraryPlugin.kt

@@ -3,11 +3,18 @@ package com.netflix.nebula.archrules.gradle
 import com.netflix.nebula.archrules.gradle.ArchRuleAttribute.ARCH_RULES
 import org.gradle.api.Plugin
 import org.gradle.api.Project
+import org.gradle.api.component.AdhocComponentWithVariants
+import org.gradle.api.internal.project.ProjectInternal
 import org.gradle.api.plugins.JavaPluginExtension
+import org.gradle.api.plugins.internal.DefaultJavaFeatureSpec
+import org.gradle.api.plugins.internal.JavaConfigurationVariantMapping
 import org.gradle.api.plugins.jvm.JvmTestSuite
+import org.gradle.api.tasks.SourceSet
+import org.gradle.jvm.component.internal.JvmSoftwareComponentInternal
 import org.gradle.kotlin.dsl.getByType
 import org.gradle.kotlin.dsl.invoke
 import org.gradle.kotlin.dsl.named
+import org.gradle.kotlin.dsl.withType
 import org.gradle.testing.base.TestingExtension
 
 class ArchrulesLibraryPlugin : Plugin<Project> {
@@ -20,10 +27,7 @@ class ArchrulesLibraryPlugin : Plugin<Project> {
                 archRulesSourceSet.implementationConfigurationName,
                 "com.netflix.nebula:nebula-archrules-core:$version"
             )
-            ext.registerFeature("archRules") {
-                usingSourceSet(archRulesSourceSet)
-                capability(project.group.toString(), project.name, project.version.toString())
-            }
+            registerRuntimeFeatureForSourceSet(project, archRulesSourceSet)
             project.configurations.named("archRulesRuntimeElements") {
                 attributes {
                     attribute(ArchRuleAttribute.ARCH_RULES_ATTRIBUTE, project.objects.named(ARCH_RULES))
@@ -53,4 +57,25 @@ class ArchrulesLibraryPlugin : Plugin<Project> {
             }
         }
     }
+
+    /**
+     * Stripped-down version of DefaultJavaPluginExtension.registerFeature which only registers runtime elements
+     */
+    fun registerRuntimeFeatureForSourceSet(project: Project, sourceSet: SourceSet) {
+        val spec = DefaultJavaFeatureSpec("archRules", project as ProjectInternal)
+        spec.usingSourceSet(sourceSet)
+        spec.capability(project.group.toString(), project.name, project.version.toString())
+        val feature = spec.create()
+        val component = project.components.withType<JvmSoftwareComponentInternal>().firstOrNull()
+        if (component != null) {
+            component.features.add(feature)
+            val adhocComponent = component as AdhocComponentWithVariants
+            if (spec.isPublished) {
+                adhocComponent.addVariantsFromConfiguration(
+                    project.configurations.getByName("archRulesRuntimeElements"),
+                    JavaConfigurationVariantMapping("runtime", true, feature.runtimeClasspathConfiguration)
+                )
+            }
+        }
+    }
 }

nebula-archrules-gradle-plugin/src/test/kotlin/com/netflix/nebula/archrules/gradle/ArchrulesLibraryPluginTest.kt

@@ -95,6 +95,12 @@ println(moduleMetadataJson)
             .first().isObject
             .containsEntry("name", "library-with-rules-0.0.1.jar")
 
+        assertThatJson(moduleMetadataJson)
+            .inPath("$.variants[?(@.name=='archRulesApiElements')].files[0]")
+            .`as`("apiElements is not produced for archRules")
+            .isArray()
+            .isEmpty()
+
         assertThatJson(moduleMetadataJson)
             .inPath("$.variants[?(@.name=='archRulesRuntimeElements')].files[0]")
             .isArray

nebula-archrules-gradle-plugin/src/test/kotlin/com/netflix/nebula/archrules/gradle/IntegrationTest.kt

@@ -60,7 +60,7 @@ internal class IntegrationTest {
         serviceFile.parentFile.mkdirs()
         serviceFile.writeText("com.example.library.LibraryArchRules")
 
-        val result = runner.run("check") {
+        val result = runner.run("check", "--stacktrace") {
             withGradleVersion(gradleVersion.version)
             forwardOutput()
         }