Skip to content

Commit 1e1dbf0

Browse files
committed
fix bug in getters predicate
1 parent ce3dfed commit 1e1dbf0

File tree

2 files changed

+14
-1
lines changed
  • archrules-gradle-plugin-development/src

2 files changed

+14
-1
lines changed

archrules-gradle-plugin-development/src/archRules/java/com/netflix/nebula/archrules/gradleplugins/Predicates.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public boolean test(JavaMethod input) {
3636
return false;
3737
}
3838
if (input.getName().startsWith("get")) {
39-
if (Character.isLowerCase(input.getName().charAt(3))) {
39+
if (input.getName().length() < 4 || Character.isLowerCase(input.getName().charAt(3))) {
4040
return false;
4141
}
4242
return true;

archrules-gradle-plugin-development/src/archRulesTest/java/com/netflix/nebula/archrules/gradleplugins/PredicatesTest.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,17 @@ public void test_annotatedWithFileInputAnnotation() {
3737
scan(GradleTaskCacheabilityRuleTest.CacheableTaskWithoutPathSensitive.class).getField("inputFile"))
3838
).isTrue();
3939
}
40+
41+
@Test
42+
public void test_getters_get() {
43+
assertThat(Predicates.getters.test(scan(AClass.class).getMethod("get"))).isFalse();
44+
}
45+
46+
47+
static class AClass {
48+
@SuppressWarnings("unused")
49+
public String get() {
50+
return "";
51+
}
52+
}
4053
}

0 commit comments

Comments
 (0)