mark rules as final

Author: rpalcolea

archrules-deprecation/src/archRules/java/com/netflix/nebula/archrules/deprecation/DeprecationRule.java

@@ -26,7 +26,7 @@ public class DeprecationRule implements ArchRulesService {
      * - Kotlin @Deprecated annotations
      * - Kotlin @DeprecatedSinceKotlin annotations
      */
-    public static ArchRule deprecationRule = ArchRuleDefinition.priority(Priority.LOW)
+    public static final ArchRule deprecationRule = ArchRuleDefinition.priority(Priority.LOW)
             .noClasses()
             // Java deprecated
             .should().dependOnClassesThat().areAnnotatedWith(Deprecated.class)
@@ -58,7 +58,7 @@ public boolean test(JavaAnnotation<?> annotation) {
                 }
             };
 
-    public static ArchRule deprecationForRemovalRule = ArchRuleDefinition.priority(Priority.MEDIUM)
+    public static final ArchRule deprecationForRemovalRule = ArchRuleDefinition.priority(Priority.MEDIUM)
             .noClasses()
             .should().dependOnClassesThat().areAnnotatedWith(deprecatedForRemoval)
             .orShould().accessTargetWhere(targetOwner(annotatedWith(deprecatedForRemoval)))

archrules-gradle-plugin-development/src/archRules/java/com/netflix/nebula/archrules/gradleplugins/GradleTaskActionRule.java

@@ -29,7 +29,7 @@ public class GradleTaskActionRule implements ArchRulesService {
      * cause runtime errors in Gradle 10+. Move Project access to configuration time
      * (constructor/initializer) and use task properties instead.
      */
-    public static ArchRule taskActionShouldNotAccessProject = createTaskActionRule(
+    public static final ArchRule taskActionShouldNotAccessProject = createTaskActionRule(
             notAccessProject(),
             "access the Project object",
             "Accessing Project in @TaskAction methods breaks configuration cache and will be removed in Gradle 10. " +
@@ -43,7 +43,7 @@ public class GradleTaskActionRule implements ArchRulesService {
      * Calling {@code getTaskDependencies()} in task actions breaks configuration cache and will
      * cause runtime errors in Gradle 10+. Task dependencies should be declared at configuration time.
      */
-    public static ArchRule taskActionShouldNotCallGetTaskDependencies = createTaskActionRule(
+    public static final ArchRule taskActionShouldNotCallGetTaskDependencies = createTaskActionRule(
             notCallGetTaskDependencies(),
             "call getTaskDependencies()",
             "Calling getTaskDependencies() in @TaskAction methods breaks configuration cache and will be removed in Gradle 10. " +

archrules-joda/src/archRules/java/com/netflix/nebula/archrules/joda/JodaRule.java

@@ -15,7 +15,7 @@ public class JodaRule implements ArchRulesService {
     /**
      * This rule is a stop-gap to find all usages of Joda.
      */
-    public static ArchRule jodaRule = ArchRuleDefinition.priority(Priority.MEDIUM)
+    public static final ArchRule jodaRule = ArchRuleDefinition.priority(Priority.MEDIUM)
             .noClasses()
             .should(GeneralCodingRules.USE_JODATIME)
             .allowEmptyShould(true)

archrules-testing-frameworks/src/archRules/java/com/netflix/nebula/archrules/testingframeworks/JUnit4Rule.java

@@ -17,7 +17,7 @@ public class JUnit4Rule implements ArchRulesService {
     /**
      * This rule is a stop-gap to find all usages of JUnit4.
      */
-    public static ArchRule junit4Rule = ArchRuleDefinition.priority(Priority.MEDIUM)
+    public static final ArchRule junit4Rule = ArchRuleDefinition.priority(Priority.MEDIUM)
             .noClasses()
             .should().dependOnClassesThat(resideInAPackage("org.junit..")
                     .and(resideOutsideOfPackage("org.junit.jupiter..")))

archrules-testing-frameworks/src/archRules/java/com/netflix/nebula/archrules/testingframeworks/Testcontainers1xRule.java

@@ -44,7 +44,7 @@ public class Testcontainers1xRule implements ArchRulesService {
      * <p>
      * <b>The fix:</b> Replace {@code DockerComposeContainer} with {@code ComposeContainer} everywhere.
      */
-    public static ArchRule dockerComposeContainerRule = ArchRuleDefinition.priority(Priority.MEDIUM)
+    public static final ArchRule dockerComposeContainerRule = ArchRuleDefinition.priority(Priority.MEDIUM)
             .noClasses()
             .should().dependOnClassesThat().haveSimpleName("DockerComposeContainer")
             .allowEmptyShould(true)
@@ -60,7 +60,7 @@ public class Testcontainers1xRule implements ArchRulesService {
      * <p>
      * <b>The fix:</b> Change {@code container.getContainerIpAddress()} to {@code container.getHost()}.
      */
-    public static ArchRule containerIpAddressMethodRule = ArchRuleDefinition.priority(Priority.MEDIUM)
+    public static final ArchRule containerIpAddressMethodRule = ArchRuleDefinition.priority(Priority.MEDIUM)
             .noClasses()
             .should().callMethod("org.testcontainers.containers.ContainerState", "getContainerIpAddress")
             .allowEmptyShould(true)
@@ -85,7 +85,7 @@ public class Testcontainers1xRule implements ArchRulesService {
      * </pre>
      * <p>
      */
-    public static ArchRule noArgConstructorRule = ArchRuleDefinition.priority(Priority.MEDIUM)
+    public static final ArchRule noArgConstructorRule = ArchRuleDefinition.priority(Priority.MEDIUM)
             .noClasses()
             .should().callConstructorWhere(target(new DescribedPredicate<AccessTarget>("no-arg Testcontainers container constructor") {
                 @Override

archrules-testing-frameworks/src/archRules/java/com/netflix/nebula/archrules/testingframeworks/Testcontainers2xRule.java

@@ -45,7 +45,7 @@ public class Testcontainers2xRule implements ArchRulesService {
      *
      * @see TestcontainersContainerModuleMapper for the full container-to-module mapping
      */
-    public static ArchRule legacyContainerPackageRule = ArchRuleDefinition.priority(Priority.LOW)
+    public static final ArchRule legacyContainerPackageRule = ArchRuleDefinition.priority(Priority.LOW)
             .classes()
             .should(notDependOnDeprecatedContainerPackages())
             .allowEmptyShould(true)