remove service provider META-INF files

wakingrufus · wakingrufus · commit c68df57ec721 · 2025-11-24T12:22:01.000-06:00
remove service provider META-INF files, as they are automatically generated by the archrules library plugin now
clean up violations of arch rules
diff --git a/README.md b/README.md
@@ -1,6 +1,6 @@
 # Nebula ArchRules
 
-This repository contains several libraries of ArchRules which can be used in projects by using the ArchRules Runner plugin.
+This repository contains several libraries of ArchRules which can be used in projects by using the [ArchRules Runner](https://github.com/nebula-plugins/nebula-archrules-plugin?tab=readme-ov-file#running-rules) plugin.
 
 
 ## Deprecation Rules
diff --git a/archrules-deprecation/build.gradle.kts b/archrules-deprecation/build.gradle.kts
@@ -7,6 +7,8 @@ repositories {
     mavenCentral()
 }
 dependencies {
+    archRulesImplementation(libs.jspecify)
+
     archRulesTestImplementation(libs.assertj)
     archRulesTestImplementation(libs.logback)
     archRulesTestImplementation("org.jetbrains.kotlin:kotlin-stdlib:2.2.0")
diff --git a/archrules-deprecation/gradle.lockfile b/archrules-deprecation/gradle.lockfile
@@ -3,15 +3,18 @@
 # This file is expected to be part of source control.
 ch.qos.logback:logback-classic:1.5.20=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 ch.qos.logback:logback-core:1.5.20=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
-com.netflix.nebula:archrules-joda:0.1.2=archRules
-com.netflix.nebula:archrules-testing-frameworks:0.1.2=archRules
-com.netflix.nebula:nebula-archrules-core:0.1.5=archRules,archRulesCompileClasspath,archRulesRuntimeClasspath,archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
+com.netflix.nebula:archrules-joda:0.1.3=archRules
+com.netflix.nebula:archrules-nullability:0.1.3=archRules
+com.netflix.nebula:archrules-testing-frameworks:0.1.3=archRules
+com.netflix.nebula:nebula-archrules-core:0.1.5=archRules
+com.netflix.nebula:nebula-archrules-core:0.2.2=archRulesCompileClasspath,archRulesRuntimeClasspath,archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 com.tngtech.archunit:archunit:1.4.1=archRules,archRulesCompileClasspath,archRulesRuntimeClasspath,archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 net.bytebuddy:byte-buddy:1.17.7=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 org.apiguardian:apiguardian-api:1.1.2=archRulesTestCompileClasspath
 org.assertj:assertj-core:3.27.6=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 org.jetbrains.kotlin:kotlin-stdlib:2.2.0=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 org.jetbrains:annotations:13.0=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
+org.jspecify:jspecify:1.0.0=archRulesCompileClasspath,archRulesRuntimeClasspath
 org.junit.jupiter:junit-jupiter-api:5.12.2=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 org.junit.jupiter:junit-jupiter-engine:5.12.2=archRulesTestRuntimeClasspath
 org.junit.jupiter:junit-jupiter-params:5.12.2=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
diff --git a/archrules-deprecation/src/archRules/java/com/netflix/nebula/archrules/deprecation/DeprecationRule.java b/archrules-deprecation/src/archRules/java/com/netflix/nebula/archrules/deprecation/DeprecationRule.java
@@ -4,6 +4,7 @@
 import com.tngtech.archunit.lang.ArchRule;
 import com.tngtech.archunit.lang.Priority;
 import com.tngtech.archunit.lang.syntax.ArchRuleDefinition;
+import org.jspecify.annotations.NullMarked;
 
 import java.util.Collections;
 import java.util.Map;
@@ -12,6 +13,7 @@
 import static com.tngtech.archunit.core.domain.JavaAccess.Predicates.targetOwner;
 import static com.tngtech.archunit.core.domain.properties.CanBeAnnotated.Predicates.annotatedWith;
 
+@NullMarked
 public class DeprecationRule implements ArchRulesService {
 
     /**
diff --git a/archrules-deprecation/src/archRules/resources/META-INF/services/com.netflix.nebula.archrules.core.ArchRulesService b/archrules-deprecation/src/archRules/resources/META-INF/services/com.netflix.nebula.archrules.core.ArchRulesService
diff --git a/archrules-joda/build.gradle.kts b/archrules-joda/build.gradle.kts
@@ -7,9 +7,10 @@ repositories {
     mavenCentral()
 }
 dependencies {
+    archRulesImplementation(libs.jspecify)
+
     archRulesTestImplementation(libs.assertj)
     archRulesTestImplementation(libs.logback)
-
     archRulesTestImplementation("joda-time:joda-time:2.14.0")
 }
 java {
diff --git a/archrules-joda/gradle.lockfile b/archrules-joda/gradle.lockfile
@@ -3,14 +3,17 @@
 # This file is expected to be part of source control.
 ch.qos.logback:logback-classic:1.5.20=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 ch.qos.logback:logback-core:1.5.20=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
-com.netflix.nebula:archrules-deprecation:0.1.2=archRules
-com.netflix.nebula:archrules-testing-frameworks:0.1.2=archRules
-com.netflix.nebula:nebula-archrules-core:0.1.5=archRules,archRulesCompileClasspath,archRulesRuntimeClasspath,archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
+com.netflix.nebula:archrules-deprecation:0.1.3=archRules
+com.netflix.nebula:archrules-nullability:0.1.3=archRules
+com.netflix.nebula:archrules-testing-frameworks:0.1.3=archRules
+com.netflix.nebula:nebula-archrules-core:0.1.5=archRules
+com.netflix.nebula:nebula-archrules-core:0.2.2=archRulesCompileClasspath,archRulesRuntimeClasspath,archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 com.tngtech.archunit:archunit:1.4.1=archRules,archRulesCompileClasspath,archRulesRuntimeClasspath,archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 joda-time:joda-time:2.14.0=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 net.bytebuddy:byte-buddy:1.17.7=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 org.apiguardian:apiguardian-api:1.1.2=archRulesTestCompileClasspath
 org.assertj:assertj-core:3.27.6=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
+org.jspecify:jspecify:1.0.0=archRulesCompileClasspath,archRulesRuntimeClasspath
 org.junit.jupiter:junit-jupiter-api:5.12.2=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 org.junit.jupiter:junit-jupiter-engine:5.12.2=archRulesTestRuntimeClasspath
 org.junit.jupiter:junit-jupiter-params:5.12.2=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
diff --git a/archrules-joda/src/archRules/java/com/netflix/nebula/archrules/joda/JodaRule.java b/archrules-joda/src/archRules/java/com/netflix/nebula/archrules/joda/JodaRule.java
@@ -5,10 +5,12 @@
 import com.tngtech.archunit.lang.Priority;
 import com.tngtech.archunit.lang.syntax.ArchRuleDefinition;
 import com.tngtech.archunit.library.GeneralCodingRules;
+import org.jspecify.annotations.NullMarked;
 
 import java.util.Collections;
 import java.util.Map;
 
+@NullMarked
 public class JodaRule implements ArchRulesService {
     /**
      * This rule is a stop-gap to find all usages of Joda.
diff --git a/archrules-joda/src/archRules/resources/META-INF/services/com.netflix.nebula.archrules.core.ArchRulesService b/archrules-joda/src/archRules/resources/META-INF/services/com.netflix.nebula.archrules.core.ArchRulesService
diff --git a/archrules-nullability/build.gradle.kts b/archrules-nullability/build.gradle.kts
@@ -7,6 +7,8 @@ repositories {
     mavenCentral()
 }
 dependencies {
+    archRulesImplementation(libs.jspecify)
+
     archRulesTestImplementation(libs.assertj)
     archRulesTestImplementation(libs.logback)
     archRulesTestImplementation("org.jspecify:jspecify:1.0.0")
diff --git a/archrules-nullability/gradle.lockfile b/archrules-nullability/gradle.lockfile
@@ -4,17 +4,18 @@
 ch.qos.logback:logback-classic:1.5.20=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 ch.qos.logback:logback-core:1.5.20=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 com.google.code.findbugs:jsr305:3.0.2=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
-com.netflix.nebula:archrules-deprecation:0.1.2=archRules
-com.netflix.nebula:archrules-joda:0.1.2=archRules
-com.netflix.nebula:archrules-testing-frameworks:0.1.2=archRules
-com.netflix.nebula:nebula-archrules-core:0.1.5=archRules,archRulesCompileClasspath,archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
-com.tngtech.archunit:archunit:1.4.1=archRules,archRulesCompileClasspath,archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
+com.netflix.nebula:archrules-deprecation:0.1.3=archRules
+com.netflix.nebula:archrules-joda:0.1.3=archRules
+com.netflix.nebula:archrules-testing-frameworks:0.1.3=archRules
+com.netflix.nebula:nebula-archrules-core:0.1.5=archRules
+com.netflix.nebula:nebula-archrules-core:0.2.2=archRulesCompileClasspath,archRulesRuntimeClasspath,archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
+com.tngtech.archunit:archunit:1.4.1=archRules,archRulesCompileClasspath,archRulesRuntimeClasspath,archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 jakarta.annotation:jakarta.annotation-api:3.0.0=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 net.bytebuddy:byte-buddy:1.17.7=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 org.apiguardian:apiguardian-api:1.1.2=archRulesTestCompileClasspath
 org.assertj:assertj-core:3.27.6=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 org.jetbrains:annotations:26.0.2-1=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
-org.jspecify:jspecify:1.0.0=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
+org.jspecify:jspecify:1.0.0=archRulesCompileClasspath,archRulesRuntimeClasspath,archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 org.junit.jupiter:junit-jupiter-api:5.12.2=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 org.junit.jupiter:junit-jupiter-engine:5.12.2=archRulesTestRuntimeClasspath
 org.junit.jupiter:junit-jupiter-params:5.12.2=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
@@ -24,5 +25,5 @@ org.junit.platform:junit-platform-engine:1.12.2=archRulesTestRuntimeClasspath
 org.junit.platform:junit-platform-launcher:1.12.2=archRulesTestRuntimeClasspath
 org.junit:junit-bom:5.12.2=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 org.opentest4j:opentest4j:1.3.0=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
-org.slf4j:slf4j-api:2.0.17=archRules,archRulesCompileClasspath,archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
+org.slf4j:slf4j-api:2.0.17=archRules,archRulesCompileClasspath,archRulesRuntimeClasspath,archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 empty=annotationProcessor,archRulesAnnotationProcessor,archRulesTestAnnotationProcessor,compileClasspath,runtimeClasspath,testAnnotationProcessor,testCompileClasspath,testRuntimeClasspath
diff --git a/archrules-nullability/src/archRules/java/com/netflix/nebula/archrules/nullability/NebulaNullabilityArchRules.java b/archrules-nullability/src/archRules/java/com/netflix/nebula/archrules/nullability/NebulaNullabilityArchRules.java
@@ -22,7 +22,7 @@ public class NebulaNullabilityArchRules implements ArchRulesService {
             .and().areNotAnnotatedWith("kotlin.Metadata")
             .should().beAnnotatedWith("org.jspecify.annotations.NullMarked")
             .allowEmptyShould(true)
-            .because("public classes should be null marked (if marked @Public)");
+            .because("public classes should be null marked");
     static final ArchRule UPGRADE_LEGACY_JETBRAINS = ArchRuleDefinition.priority(Priority.MEDIUM)
             .noClasses()
             .that().areAnnotatedWith("org.jspecify.annotations.NullMarked")
diff --git a/archrules-nullability/src/archRules/resources/META-INF/services/com.netflix.nebula.archrules.core.ArchRulesService b/archrules-nullability/src/archRules/resources/META-INF/services/com.netflix.nebula.archrules.core.ArchRulesService
diff --git a/archrules-testing-frameworks/build.gradle.kts b/archrules-testing-frameworks/build.gradle.kts
@@ -1,3 +1,6 @@
+import com.netflix.nebula.archrules.gradle.CheckRulesTask
+import com.netflix.nebula.archrules.gradle.PrintConsoleReportTask
+
 plugins {
     id("com.netflix.nebula.library")
     id("com.netflix.nebula.archrules.library")
@@ -7,9 +10,10 @@ repositories {
     mavenCentral()
 }
 dependencies {
+    archRulesImplementation(libs.jspecify)
+
     archRulesTestImplementation(libs.assertj)
     archRulesTestImplementation(libs.logback)
-
     archRulesTestImplementation("junit:junit:4.12")
 }
 java {
diff --git a/archrules-testing-frameworks/gradle.lockfile b/archrules-testing-frameworks/gradle.lockfile
@@ -3,16 +3,18 @@
 # This file is expected to be part of source control.
 ch.qos.logback:logback-classic:1.5.20=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 ch.qos.logback:logback-core:1.5.20=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
-com.netflix.nebula:archrules-deprecation:0.1.2=archRules
-com.netflix.nebula:archrules-joda:0.1.2=archRules
-com.netflix.nebula:nebula-archrules-core:0.1.2=archRulesRuntimeClasspath
-com.netflix.nebula:nebula-archrules-core:0.1.5=archRules,archRulesCompileClasspath,archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
+com.netflix.nebula:archrules-deprecation:0.1.3=archRules
+com.netflix.nebula:archrules-joda:0.1.3=archRules
+com.netflix.nebula:archrules-nullability:0.1.3=archRules
+com.netflix.nebula:nebula-archrules-core:0.1.5=archRules
+com.netflix.nebula:nebula-archrules-core:0.2.2=archRulesCompileClasspath,archRulesRuntimeClasspath,archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 com.tngtech.archunit:archunit:1.4.1=archRules,archRulesCompileClasspath,archRulesRuntimeClasspath,archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 junit:junit:4.12=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 net.bytebuddy:byte-buddy:1.17.7=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 org.apiguardian:apiguardian-api:1.1.2=archRulesTestCompileClasspath
 org.assertj:assertj-core:3.27.6=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 org.hamcrest:hamcrest-core:1.3=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
+org.jspecify:jspecify:1.0.0=archRulesCompileClasspath,archRulesRuntimeClasspath
 org.junit.jupiter:junit-jupiter-api:5.12.2=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
 org.junit.jupiter:junit-jupiter-engine:5.12.2=archRulesTestRuntimeClasspath
 org.junit.jupiter:junit-jupiter-params:5.12.2=archRulesTestCompileClasspath,archRulesTestRuntimeClasspath
diff --git a/archrules-testing-frameworks/src/archRules/java/com/netflix/nebula/archrules/testingframeworks/JUnit4Rule.java b/archrules-testing-frameworks/src/archRules/java/com/netflix/nebula/archrules/testingframeworks/JUnit4Rule.java
@@ -4,12 +4,15 @@
 import com.tngtech.archunit.lang.ArchRule;
 import com.tngtech.archunit.lang.Priority;
 import com.tngtech.archunit.lang.syntax.ArchRuleDefinition;
+import org.jspecify.annotations.NullMarked;
+
 import static com.tngtech.archunit.core.domain.JavaClass.Predicates.resideInAPackage;
 import static com.tngtech.archunit.core.domain.JavaClass.Predicates.resideOutsideOfPackage;
 
 import java.util.Collections;
 import java.util.Map;
 
+@NullMarked
 public class JUnit4Rule implements ArchRulesService {
     /**
      * This rule is a stop-gap to find all usages of JUnit4.
diff --git a/archrules-testing-frameworks/src/archRules/resources/META-INF/services/com.netflix.nebula.archrules.core.ArchRulesService b/archrules-testing-frameworks/src/archRules/resources/META-INF/services/com.netflix.nebula.archrules.core.ArchRulesService
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
@@ -1,3 +1,4 @@
 [libraries]
 assertj = { module = "org.assertj:assertj-core", version = "3.27.6" }
+jspecify = { module = "org.jspecify:jspecify", version = "1.0.0" }
 logback = { module = "ch.qos.logback:logback-classic", version = "1.5.20" }
diff --git a/settings.gradle.kts b/settings.gradle.kts
@@ -1,7 +1,7 @@
 pluginManagement {
     plugins {
-        id("com.netflix.nebula.root") version ("25.0.1")
-        id("com.netflix.nebula.library") version ("25.0.1")
+        id("com.netflix.nebula.root") version ("25.1.2")
+        id("com.netflix.nebula.library") version ("25.1.2")
     }
 }
 plugins {

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,8 @@ repositories {`
`7`	`7`	`mavenCentral()`
`8`	`8`	`}`
`9`	`9`	`dependencies {`
	`10`	`+ archRulesImplementation(libs.jspecify)`
	`11`	`+`
`10`	`12`	`archRulesTestImplementation(libs.assertj)`
`11`	`13`	`archRulesTestImplementation(libs.logback)`
`12`	`14`	`archRulesTestImplementation("org.jetbrains.kotlin:kotlin-stdlib:2.2.0")`
Original file line number	Diff line number	Diff line change
`@@ -7,9 +7,10 @@ repositories {`
`7`	`7`	`mavenCentral()`
`8`	`8`	`}`
`9`	`9`	`dependencies {`
	`10`	`+ archRulesImplementation(libs.jspecify)`
	`11`	`+`
`10`	`12`	`archRulesTestImplementation(libs.assertj)`
`11`	`13`	`archRulesTestImplementation(libs.logback)`
`12`		`-`
`13`	`14`	`archRulesTestImplementation("joda-time:joda-time:2.14.0")`
`14`	`15`	`}`
`15`	`16`	`java {`