Merge pull request #92 from nebula-plugins/fix-nebulaRecommenderBom-support

Fix nebula recommender bom support

Author: rpalcolea

src/main/groovy/netflix/nebula/dependency/recommender/DependencyRecommendationsPlugin.java

@@ -59,6 +59,7 @@ public void apply(final Project project) {
             logger.warn("coreBomSupport feature enabled");
             recommendationProviderContainer.excludeConfigurations("archives", NEBULA_RECOMMENDER_BOM, "provided",
                     "versionManagement", "resolutionRules", "bootArchives", "webapp");
+            bomConfiguration.setCanBeResolved(false);
             applyRecommendationsDirectly(project, bomConfiguration);
         } else {
             applyRecommendations(project);

src/main/groovy/netflix/nebula/dependency/recommender/provider/RecommendationProviderContainer.java

@@ -27,7 +27,9 @@
 import org.gradle.api.internal.DefaultNamedDomainObjectList;
 import org.gradle.util.ConfigureUtil;
 
+import java.io.File;
 import java.util.Arrays;
+import java.util.Collections;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Map;
@@ -57,10 +59,20 @@ public void execute(RecommendationProvider r) {
     public RecommendationProviderContainer(Project project) {
         super(RecommendationProvider.class, null, new RecommendationProviderNamer());
         this.project = project;
-        this.mavenBomProvider = new MavenBomRecommendationProvider(this.project, DependencyRecommendationsPlugin.NEBULA_RECOMMENDER_BOM, this.reasons);
+        this.mavenBomProvider = getMavenBomRecommendationProvider();
         this.add(this.mavenBomProvider);
     }
 
+    private MavenBomRecommendationProvider getMavenBomRecommendationProvider() {
+        MavenBomRecommendationProvider mavenBomRecommendationProvider;
+        if(DependencyRecommendationsPlugin.CORE_BOM_SUPPORT_ENABLED) {
+            mavenBomRecommendationProvider = new CoreBomSupportProvider(this.project, DependencyRecommendationsPlugin.NEBULA_RECOMMENDER_BOM, this.reasons);
+        } else {
+            mavenBomRecommendationProvider = new MavenBomRecommendationProvider(this.project, DependencyRecommendationsPlugin.NEBULA_RECOMMENDER_BOM, this.reasons);
+        }
+        return mavenBomRecommendationProvider;
+    }
+
     private static class RecommendationProviderNamer implements Namer<RecommendationProvider> {
         public String determineName(RecommendationProvider r) {
             return r.getName();
@@ -224,4 +236,22 @@ private static void ensureCoreBomSupportNotEnabled(String feature) {
             throw new GradleException("dependencyRecommender." + feature + " is not available with 'systemProp.nebula.features.coreBomSupport=true'");
         }
     }
+
+    //This is to prevent resolving files from nebulaRecommenderBom configuration
+    private static class CoreBomSupportProvider extends MavenBomRecommendationProvider {
+        public CoreBomSupportProvider(Project project, String configName, Set<String> reasons) {
+            super(project, configName, reasons);
+        }
+
+        @Override
+        public String getName() {
+            return "";
+        }
+
+        @Override
+        Set<File> getFilesOnConfiguration() {
+            return Collections.emptySet();
+        }
+    }
+
 }