Merge pull request #135 from nebula-plugins/address-is-boolean-deprecation

Replace isStrictMode to getStrictMode to address Declaring an 'is-' property with a Boolean type has been deprecated.

Author: rpalcolea

.github/workflows/nebula.yml

@@ -38,14 +38,14 @@ jobs:
             8
             ${{ matrix.java }}
           java-package: jdk
-      - uses: actions/cache@v1
+      - uses: actions/cache@v3
         id: gradle-cache
         with:
           path: ~/.gradle/caches
           key: ${{ runner.os }}-gradle-${{ hashFiles('**/gradle/dependency-locks/*.lockfile') }}
           restore-keys: |
             - ${{ runner.os }}-gradle-
-      - uses: actions/cache@v1
+      - uses: actions/cache@v3
         id: gradle-wrapper-cache
         with:
           path: ~/.gradle/wrapper
@@ -78,14 +78,14 @@ jobs:
             8
             21
           java-package: jdk
-      - uses: actions/cache@v1
+      - uses: actions/cache@v3
         id: gradle-cache
         with:
           path: ~/.gradle/caches
           key: ${{ runner.os }}-gradle-${{ hashFiles('**/gradle/dependency-locks/*.lockfile') }}
           restore-keys: |
             - ${{ runner.os }}-gradle-
-      - uses: actions/cache@v1
+      - uses: actions/cache@v3
         id: gradle-wrapper-cache
         with:
           path: ~/.gradle/wrapper
@@ -123,14 +123,14 @@ jobs:
             8
             21
           java-package: jdk
-      - uses: actions/cache@v1
+      - uses: actions/cache@v3
         id: gradle-cache
         with:
           path: ~/.gradle/caches
           key: ${{ runner.os }}-gradle-${{ hashFiles('**/gradle/dependency-locks/*.lockfile') }}
           restore-keys: |
             - ${{ runner.os }}-gradle-
-      - uses: actions/cache@v1
+      - uses: actions/cache@v3
         id: gradle-wrapper-cache
         with:
           path: ~/.gradle/wrapper

src/main/groovy/netflix/nebula/dependency/recommender/DependencyRecommendationsPlugin.java

@@ -129,7 +129,7 @@ public void execute(DependencyResolveDetails details) {
                                             details.because("Recommending version " + version + " for dependency " + coordinate + " via " + strategyText + "\n" +
                                                     "\twith reasons: " + StringUtils.join(getReasonsRecursive(project), ", "));
                                         } else {
-                                            if (recommendationProviderContainer.isStrictMode()) {
+                                            if (recommendationProviderContainer.getStrictMode()) {
                                                 String errorMessage = "Dependency " + details.getRequested().getGroup() + ":" + details.getRequested().getName() + " omitted version with no recommended version. General causes include a dependency being removed from the recommendation source or not applying a recommendation source to a project that depends on another project using a recommender.";
                                                 project.getLogger().error(errorMessage);
                                                 throw new GradleException(errorMessage);

src/main/groovy/netflix/nebula/dependency/recommender/provider/RecommendationProviderContainer.java

@@ -222,7 +222,12 @@ public void setStrategy(RecommendationStrategies strategy) {
         this.strategy = strategy;
     }
 
+    @Deprecated
     public Boolean isStrictMode() {
+        return getStrictMode();
+    }
+
+    public Boolean getStrictMode() {
         return strictMode;
     }