Merge pull request #111 from nebula-plugins/unique_copies_are_non_resolvable

OdysseusLives · web-flow · commit c94fa0951d35 · 2019-09-19T16:30:50.000-07:00
Mark copied configurations as non-resolvable so that we do not lock copies of BOM configurations
diff --git a/src/main/groovy/netflix/nebula/dependency/recommender/ExtendRecommenderConfigurationAction.java b/src/main/groovy/netflix/nebula/dependency/recommender/ExtendRecommenderConfigurationAction.java
@@ -32,6 +32,7 @@ public void execute(Configuration configuration) {
             if (!project.getRootProject().equals(project)) {
                 toExtend = bom.copy();
                 toExtend.setVisible(false);
+                toExtend.setCanBeResolved(false);
                 project.getConfigurations().add(toExtend);
             }
             configuration.extendsFrom(toExtend);

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,7 @@ public void execute(Configuration configuration) {`
`32`	`32`	`if (!project.getRootProject().equals(project)) {`
`33`	`33`	`toExtend = bom.copy();`
`34`	`34`	`toExtend.setVisible(false);`
	`35`	`+ toExtend.setCanBeResolved(false);`
`35`	`36`	`project.getConfigurations().add(toExtend);`
`36`	`37`	`}`
`37`	`38`	`configuration.extendsFrom(toExtend);`