Support excludeConfiguration with feature flag

Author: sghill

src/main/groovy/netflix/nebula/dependency/recommender/DependencyRecommendationsPlugin.java

@@ -67,12 +67,16 @@ public void apply(final Project project) {
     }
 
     private void applyRecommendationsDirectly(final Project project, final Configuration bomConfiguration) {
-        final Set<String> excluded = recommendationProviderContainer.getExcludedConfigurations();
-        project.getConfigurations().all(new ExtendRecommenderConfigurationAction(bomConfiguration, excluded, project));
-        project.subprojects(new Action<Project>() {
+        project.afterEvaluate(new Action<Project>() {
             @Override
-            public void execute(Project sub) {
-                sub.getConfigurations().all(new ExtendRecommenderConfigurationAction(bomConfiguration, excluded, sub));
+            public void execute(Project p) {
+                p.getConfigurations().all(new ExtendRecommenderConfigurationAction(bomConfiguration, p, recommendationProviderContainer));
+                p.subprojects(new Action<Project>() {
+                    @Override
+                    public void execute(Project sub) {
+                        sub.getConfigurations().all(new ExtendRecommenderConfigurationAction(bomConfiguration, sub, recommendationProviderContainer));
+                    }
+                });
             }
         });
     }

src/main/groovy/netflix/nebula/dependency/recommender/ExtendRecommenderConfigurationAction.java

@@ -1,25 +1,24 @@
 package netflix.nebula.dependency.recommender;
 
+import netflix.nebula.dependency.recommender.provider.RecommendationProviderContainer;
 import org.gradle.api.Action;
 import org.gradle.api.Project;
 import org.gradle.api.artifacts.Configuration;
 
-import java.util.Set;
-
 public class ExtendRecommenderConfigurationAction implements Action<Configuration> {
     private final Configuration bom;
-    private final Set<String> excludedConfigurationNames;
     private final Project project;
+    private final RecommendationProviderContainer container;
 
-    public ExtendRecommenderConfigurationAction(Configuration bom, Set<String> excludedConfigurationNames, Project project) {
+    public ExtendRecommenderConfigurationAction(Configuration bom, Project project, RecommendationProviderContainer container) {
         this.bom = bom;
-        this.excludedConfigurationNames = excludedConfigurationNames;
         this.project = project;
+        this.container = container;
     }
 
     @Override
     public void execute(Configuration configuration) {
-        if (excludedConfigurationNames.contains(configuration.getName())) {
+        if (container.getExcludedConfigurations().contains(configuration.getName())) {
             return;
         }
         Configuration toExtend = bom;

src/test/groovy/netflix/nebula/dependency/recommender/DependencyRecommendationsPluginCoreBomSupportSpec.groovy

@@ -42,13 +42,16 @@ class DependencyRecommendationsPluginCoreBomSupportSpec extends IntegrationSpec
         pom.addManagementDependency('test.nebula', 'bar', '2.0.0')
         pom.addManagementDependency('test.nebula', 'baz', '2.5.0')
         pom.addManagementDependency('test.nebula', 'lib', '3.9.9')
+        pom.addManagementDependency('test.nebula', 'app', '8.0.0')
         repo.poms.add(pom)
         repo.generate()
         def graph = new DependencyGraphBuilder()
                 .addModule('test.nebula:foo:1.0.0')
                 .addModule('test.nebula:bar:2.0.0')
                 .addModule('test.nebula:baz:2.5.0')
                 .addModule('test.nebula:lib:3.9.9')
+                .addModule('test.nebula:app:7.0.0')
+                .addModule('test.nebula:app:8.0.0')
                 .build()
         generator = new GradleDependencyGenerator(graph)
         generator.generateTestMavenRepo()
@@ -66,6 +69,7 @@ class DependencyRecommendationsPluginCoreBomSupportSpec extends IntegrationSpec
             }
 
             dependencyRecommendations {
+                excludeConfigurations('compileOnly')
                 mavenBom module: 'test.nebula.bom:testbom:latest.release'
             }
 
@@ -74,17 +78,23 @@ class DependencyRecommendationsPluginCoreBomSupportSpec extends IntegrationSpec
                 compile 'test.nebula:foo'
                 providedCompile 'test.nebula:lib'
                 runtimeOnly 'test.nebula:baz'
+                compileOnly 'test.nebula:app:7.0.0' // bom recommends 8, but config excluded
             }
             """.stripIndent()
 
         when:
         def result = runTasksSuccessfully('dependencies')
+        def compileOnlyResult = runTasksSuccessfully('dependencies', '--configuration', 'compileOnly')
 
         then:
         result.standardOutput.contains("+--- test.nebula:foo -> 1.0.0")
         result.standardOutput.contains("+--- test.nebula:bar -> 2.0.0")
         result.standardOutput.contains("\\--- test.nebula:baz -> 2.5.0")
         result.standardOutput.contains("\\--- test.nebula:lib -> 3.9.9")
+
+        compileOnlyResult.standardOutput.contains("compileOnly - Compile only dependencies for source set 'main'.\n" +
+                "\\--- test.nebula:app:7.0.0")
+        !compileOnlyResult.standardOutput.contains('test.nebula.bom:testbom:latest.release')
     }
 
     @Unroll