Enable GMM when shadow plugin is used (this works now) (#87)

update to latest version of plugin-plugin (self) and gradle plugin publish plugin

Author: wakingrufus

build.gradle.kts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 plugins {
-    id("com.netflix.nebula.plugin-plugin") version "23.+"
+    id("com.netflix.nebula.plugin-plugin") version "24.+"
     `kotlin-dsl`
 }
 
@@ -23,34 +23,29 @@ description = "Project plugin for Nebula plugins"
 contacts {
     addPerson("nebula-plugins-oss@netflix.com") {
         moniker = "Nebula Plugins Maintainers"
-        github =  "nebula-plugins"
+        github = "nebula-plugins"
     }
 }
 
-repositories {
-    mavenCentral()
-    gradlePluginPortal()
-}
-
 dependencies {
     compileOnly("io.github.gradle-nexus:publish-plugin:2.0.0")
-    implementation ("com.netflix.nebula:nebula-oss-publishing-plugin:latest.release")
-    implementation ("com.netflix.nebula:gradle-contacts-plugin:latest.release")
-    implementation ("com.netflix.nebula:gradle-dependency-lock-plugin:latest.release")
-    implementation ("com.netflix.nebula:gradle-info-plugin:latest.release")
-    implementation ("com.netflix.nebula:gradle-java-cross-compile-plugin:latest.release")
-    implementation ("com.netflix.nebula:nebula-publishing-plugin:latest.release")
-    implementation ("com.netflix.nebula:nebula-project-plugin:latest.release")
-    implementation ("com.netflix.nebula:nebula-release-plugin:latest.release")
-    implementation ("com.netflix.nebula:nebula-gradle-interop:latest.release")
+    implementation("com.netflix.nebula:nebula-oss-publishing-plugin:latest.release")
+    implementation("com.netflix.nebula:gradle-contacts-plugin:latest.release")
+    implementation("com.netflix.nebula:gradle-dependency-lock-plugin:latest.release")
+    implementation("com.netflix.nebula:gradle-info-plugin:latest.release")
+    implementation("com.netflix.nebula:gradle-java-cross-compile-plugin:latest.release")
+    implementation("com.netflix.nebula:nebula-publishing-plugin:latest.release")
+    implementation("com.netflix.nebula:nebula-project-plugin:latest.release")
+    implementation("com.netflix.nebula:nebula-release-plugin:latest.release")
+    implementation("com.netflix.nebula:nebula-gradle-interop:latest.release")
     implementation("com.netflix.nebula:gradle-info-plugin:latest.release")
-    implementation (platform("com.fasterxml.jackson:jackson-bom:2.14.+"))
+    implementation(platform("com.fasterxml.jackson:jackson-bom:2.14.+"))
 
-    implementation ("com.gradle.publish:plugin-publish-plugin:1.3.1")
+    implementation("com.gradle.publish:plugin-publish-plugin:2.+")
 
     testImplementation("com.netflix.nebula:nebula-test:latest.release")
     testImplementation("org.ajoberstar.grgit:grgit-core:4.1.1") {
-        exclude (group= "org.codehaus.groovy", module= "groovy")
+        exclude(group = "org.codehaus.groovy", module = "groovy")
     }
     testImplementation("org.mock-server:mockserver-netty:5.15.0")
 }
@@ -88,7 +83,7 @@ java {
 }
 testing {
     suites {
-        named<JvmTestSuite>("test"){
+        named<JvmTestSuite>("test") {
             useJUnitJupiter()
             targets.all {
                 testTask.configure {

gradle.lockfile

@@ -29,7 +29,8 @@ com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava=inte
 com.google.j2objc:j2objc-annotations:1.3=integTestCompileClasspath,integTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath
 com.googlecode.javaewah:JavaEWAH:1.1.12=integTestCompileClasspath,integTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath
 com.googlecode.libphonenumber:libphonenumber:8.11.1=integTestCompileClasspath,integTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath
-com.gradle.publish:plugin-publish-plugin:1.3.1=compileClasspath,integTestCompileClasspath,integTestRuntimeClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+com.gradle.publish:plugin-publish-plugin:1.3.1=integTestCompileClasspath,integTestRuntimeClasspath
+com.gradle.publish:plugin-publish-plugin:2.0.0=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
 com.jayway.jsonpath:json-path:2.7.0=integTestCompileClasspath,integTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath
 com.jcraft:jzlib:1.1.2=runtimeClasspath
 com.jcraft:jzlib:1.1.3=integTestCompileClasspath,integTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath

src/main/groovy/nebula/plugin/plugin/NebulaPluginPlugin.groovy

@@ -90,11 +90,6 @@ class NebulaPluginPlugin implements Plugin<Project> {
             repositories {
                 maven {
                     url = 'https://plugins.gradle.org/m2/'
-                    metadataSources {
-                        mavenPom()
-                        artifact()
-                        ignoreGradleMetadataRedirection()
-                    }
                 }
                 mavenCentral()
             }
@@ -170,10 +165,6 @@ class NebulaPluginPlugin implements Plugin<Project> {
                     }
                 }
             }
-
-            plugins.withId('com.github.johnrengelman.shadow') {
-                disableGradleModuleMetadataTask(project)
-            }
         }
 
         project.afterEvaluate {
@@ -203,13 +194,4 @@ class NebulaPluginPlugin implements Plugin<Project> {
         }
 
     }
-
-    private void disableGradleModuleMetadataTask(Project project) {
-        project.tasks.withType(GenerateModuleMetadata).configureEach(new Action<GenerateModuleMetadata>() {
-            @Override
-            void execute(GenerateModuleMetadata generateModuleMetadataTask) {
-                generateModuleMetadataTask.enabled = false
-            }
-        })
-    }
 }