update publish action to use environment

Author: wakingrufus

.github/workflows/publish.yml

@@ -6,38 +6,13 @@ on:
       - v*.*.*-rc.*
 
 jobs:
-  validatepluginpublication:
-    runs-on: ubuntu-latest
-    name: Gradle Plugin Publication Validation
-    env:
-      NETFLIX_OSS_SONATYPE_USERNAME: ${{ secrets.ORG_SONATYPE_USERNAME }}
-      NETFLIX_OSS_SONATYPE_PASSWORD: ${{ secrets.ORG_SONATYPE_PASSWORD }}
-    steps:
-      - uses: actions/checkout@v4
-      - name: Setup git user
-        run: |
-          git config --global user.name "Nebula Plugin Maintainers"
-          git config --global user.email "nebula-plugins-oss@netflix.com"
-      - name: Set up JDKs
-        uses: actions/setup-java@v4
-        with:
-          distribution: 'zulu'
-          java-version: |
-            17
-            21
-          java-package: jdk
-      - name: Setup Gradle
-        uses: gradle/actions/setup-gradle@v5
-        with:
-          cache-overwrite-existing: true
-      - name: Verify plugin publication
-        if: (!contains(github.ref, '-rc.'))
-        run: ./gradlew  --stacktrace -Dgradle.publish.key=${{ secrets.gradlePublishKey }} -Dgradle.publish.secret=${{ secrets.gradlePublishSecret }}  -Prelease.useLastTag=true final publishPlugin --validate-only -x check
   publish:
     if: github.event.base_ref == 'refs/heads/main' # tags must be pushed to main
-    needs: validatepluginpublication
     runs-on: ubuntu-latest
     name: Gradle Build and Publish
+    environment:
+      name: Publish
+      url: "https://plugins.gradle.org/plugin/com.netflix.nebula.plugin-plugin"
     env:
       NETFLIX_OSS_SONATYPE_USERNAME: ${{ secrets.ORG_SONATYPE_USERNAME }}
       NETFLIX_OSS_SONATYPE_PASSWORD: ${{ secrets.ORG_SONATYPE_PASSWORD }}
@@ -65,6 +40,9 @@ jobs:
           cache-overwrite-existing: true
       - name: Gradle build
         run: ./gradlew --stacktrace build
+      - name: Verify plugin publication
+        if: (!contains(github.ref, '-rc.'))
+        run: ./gradlew  --stacktrace -Dgradle.publish.key=${{ secrets.gradlePublishKey }} -Dgradle.publish.secret=${{ secrets.gradlePublishSecret }}  -Prelease.useLastTag=true final publishPlugin --validate-only -x check
       - name: Publish candidate
         if: contains(github.ref, '-rc.')
         run: ./gradlew --stacktrace -Prelease.useLastTag=true candidate

gradle.lockfile

@@ -35,12 +35,12 @@ com.jayway.jsonpath:json-path:2.7.0=testCompileClasspath,testRuntimeClasspath
 com.jcraft:jzlib:1.1.2=runtimeClasspath
 com.jcraft:jzlib:1.1.3=testCompileClasspath,testRuntimeClasspath
 com.lmax:disruptor:3.4.4=testCompileClasspath,testRuntimeClasspath
-com.netflix.nebula:gradle-contacts-plugin:8.0.0=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+com.netflix.nebula:gradle-contacts-plugin:8.1.0=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
 com.netflix.nebula:gradle-dependency-lock-plugin:16.1.0=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
 com.netflix.nebula:gradle-info-plugin:16.0.0=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
 com.netflix.nebula:gradle-java-cross-compile-plugin:8.0.0=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
-com.netflix.nebula:nebula-archrules-core:0.2.3=runtimeClasspath,testRuntimeClasspath
-com.netflix.nebula:nebula-archrules-gradle-plugin:0.2.3=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+com.netflix.nebula:nebula-archrules-core:0.3.0=runtimeClasspath,testRuntimeClasspath
+com.netflix.nebula:nebula-archrules-gradle-plugin:0.3.0=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
 com.netflix.nebula:nebula-dependencies-comparison:0.2.1=runtimeClasspath,testRuntimeClasspath
 com.netflix.nebula:nebula-gradle-interop:3.1.0=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
 com.netflix.nebula:nebula-oss-publishing-plugin:4.1.1=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath