cascade delete triggers and face recognition test fix

Add migration 051 with cascade delete triggers for all parent-child
relationships (movies→medias, books→medias, series→episodes, tags→children,
people→faces/mappings, channels→variants). Includes one-time orphan cleanup.

Fix face recognition test to use relative paths (test_data/face1.jpg and
face2.webp) so it works cross-platform, and assert on similarity score.

Author: neckaros

src/model/medias.rs

@@ -2309,25 +2309,7 @@ impl ModelController {
     ) -> crate::error::Result<Vec<u8>> {
         requesting_user.check_file_role(library_id, media_id, LibraryRole::Read)?;
 
-        let store = self.store.get_library_store(library_id)?;
-        let source =
-            store
-                .get_media_source(&media_id)
-                .await?
-                .ok_or(SourcesError::UnableToFindSource(
-                    library_id.to_string(),
-                    media_id.to_string(),
-                    format!("mediaid: {}", media_id),
-                    "get_video_thumb".to_string(),
-                ))?;
-
-        let m = self.source_for_library(&library_id).await?;
-        let local_path = m.local_path(&source.source);
-        let uri = if let Some(local_path) = local_path {
-            local_path.to_str().unwrap().to_string()
-        } else {
-            ModelController::get_temporary_local_read_url(library_id, media_id, None).await?
-        };
+        let uri = self.get_media_uri(library_id, media_id, None).await?;
         let thumb = video_tools::thumb_video(&uri, time).await?;
         let mut cursor = std::io::Cursor::new(thumb);
         let thumb = resize_image_reader(Box::pin(cursor), 512, format, quality, false).await?;
@@ -2390,6 +2372,110 @@ impl ModelController {
         Ok(uri)
     }
 
+    /// Returns a local file path (for local sources) or a temporary authenticated URL
+    /// (for plugin/virtual sources) that can be used as FFmpeg input.
+    pub async fn get_media_uri(
+        &self,
+        library_id: &str,
+        media_id: &str,
+        delay: Option<u64>,
+    ) -> crate::error::Result<String> {
+        let store = self.store.get_library_store(library_id)?;
+        let source =
+            store
+                .get_media_source(&media_id)
+                .await?
+                .ok_or(SourcesError::UnableToFindSource(
+                    library_id.to_string(),
+                    media_id.to_string(),
+                    format!("mediaid: {}", media_id),
+                    "get_media_uri".to_string(),
+                ))?;
+
+        let m = self.source_for_library(library_id).await?;
+        let local_path = m.local_path(&source.source);
+        if let Some(local_path) = local_path {
+            Ok(local_path.to_string_lossy().to_string())
+        } else {
+            Ok(ModelController::get_temporary_local_read_url(library_id, media_id, delay).await?)
+        }
+    }
+
+    // -- Media HLS session management --
+
+    pub async fn get_or_create_media_hls_session(
+        &self,
+        library_id: &str,
+        media_id: &str,
+        convert_request: Option<VideoConvertRequest>,
+        requesting_user: &ConnectedUser,
+    ) -> RsResult<String> {
+        requesting_user.check_file_role(library_id, media_id, LibraryRole::Read)?;
+
+        // Crypt libraries are not supported for HLS
+        if self.cache_get_library_crypt(library_id).await {
+            return Err(crate::Error::UnavailableForCryptedLibraries);
+        }
+
+        // Compute session key
+        let convert_hash = if let Some(ref req) = convert_request {
+            use std::collections::hash_map::DefaultHasher;
+            use std::hash::{Hash, Hasher};
+            let json = serde_json::to_string(req).unwrap_or_default();
+            let mut hasher = DefaultHasher::new();
+            json.hash(&mut hasher);
+            format!("{:x}", hasher.finish())
+        } else {
+            "default".to_string()
+        };
+        let key = format!("{}:{}:{}", library_id, media_id, convert_hash);
+
+        // Fast path: check if session already exists
+        {
+            let sessions = self.media_hls_sessions.read().await;
+            if let Some(session) = sessions.get(&key) {
+                session.touch();
+                return Ok(key);
+            }
+        }
+
+        // Resolve input: local path or temp URL (12 hours for movie sessions)
+        let uri = self.get_media_uri(library_id, media_id, Some(43200)).await?;
+
+        // Create and start the session
+        crate::tools::media_hls_session::start_media_hls_session(
+            key.clone(),
+            library_id.to_string(),
+            media_id.to_string(),
+            &uri,
+            convert_request,
+            self.media_hls_sessions.clone(),
+        )
+        .await?;
+
+        Ok(key)
+    }
+
+    pub async fn stop_media_hls_session(
+        &self,
+        library_id: &str,
+        media_id: &str,
+    ) -> RsResult<()> {
+        let keys_to_stop: Vec<String> = {
+            let sessions = self.media_hls_sessions.read().await;
+            sessions
+                .keys()
+                .filter(|k| k.starts_with(&format!("{}:{}:", library_id, media_id)))
+                .cloned()
+                .collect()
+        };
+
+        for key in &keys_to_stop {
+            crate::tools::media_hls_session::stop_session(key, &self.media_hls_sessions).await;
+        }
+        Ok(())
+    }
+
     pub async fn get_file_share_token(
         &self,
         library_id: &str,
@@ -3275,25 +3361,7 @@ impl ModelController {
     ) -> crate::Result<()> {
         requesting_user.check_file_role(library_id, media_id, LibraryRole::Read)?;
 
-        let store = self.store.get_library_store(library_id)?;
-        let source =
-            store
-                .get_media_source(&media_id)
-                .await?
-                .ok_or(SourcesError::UnableToFindSource(
-                    library_id.to_string(),
-                    media_id.to_string(),
-                    format!("mediaid: {}", media_id),
-                    "update_video_infos".to_string(),
-                ))?;
-
-        let m = self.source_for_library(&library_id).await?;
-        let local_path = m.local_path(&source.source);
-        let uri = if let Some(local_path) = local_path {
-            local_path.to_str().unwrap().to_string()
-        } else {
-            ModelController::get_temporary_local_read_url(library_id, media_id, Some(240)).await?
-        };
+        let uri = self.get_media_uri(library_id, media_id, Some(240)).await?;
 
         let videos_infos = probe_video(&uri).await?;
 

src/model/mod.rs

@@ -144,6 +144,9 @@ pub struct ModelController {
     pub hls_sessions: Arc<RwLock<HashMap<String, crate::tools::hls_session::HlsSession>>>,
     /// Active IPTV streams per library: library_id → set of channel_ids currently streaming
     pub active_streams: Arc<RwLock<HashMap<String, HashSet<String>>>>,
+
+    /// Media HLS sessions: key = "library:media:convert_hash"
+    pub media_hls_sessions: Arc<RwLock<HashMap<String, crate::tools::media_hls_session::MediaHlsSession>>>,
 }
 
 // Constructor
@@ -171,6 +174,8 @@ impl ModelController {
 
             hls_sessions: Arc::new(RwLock::new(HashMap::new())),
             active_streams: Arc::new(RwLock::new(HashMap::new())),
+
+            media_hls_sessions: Arc::new(RwLock::new(HashMap::new())),
         };
 
         let pm_forload = mc.plugin_manager.clone();
@@ -224,7 +229,7 @@ impl ModelController {
             crate::tools::hls_session::cleanup_orphaned_dirs().await;
         });
 
-        // Spawn HLS session cleanup loop
+        // Spawn HLS session cleanup loop (channels)
         let mc_cleanup = mc.clone();
         tokio::spawn(async move {
             loop {
@@ -236,6 +241,15 @@ impl ModelController {
             }
         });
 
+        // Spawn media HLS session cleanup loop
+        let mc_media_cleanup = mc.clone();
+        tokio::spawn(async move {
+            loop {
+                tokio::time::sleep(std::time::Duration::from_secs(30)).await;
+                crate::tools::media_hls_session::cleanup_stale_sessions(&mc_media_cleanup.media_hls_sessions).await;
+            }
+        });
+
         Ok(mc)
     }
 }

src/model/store/sql/library/051 - CASCADE DELETE.sql

@@ -0,0 +1,129 @@
+-- ================================================
+-- Migration 051: CASCADE DELETE TRIGGERS
+-- Replaces manual cleanup with trigger-based cascades
+-- ================================================
+
+-- 1. MEDIA CHILDREN CASCADE
+-- When a media is deleted, remove all referencing records
+CREATE TRIGGER cascade_delete_media_children AFTER DELETE ON medias
+BEGIN
+    DELETE FROM media_tag_mapping WHERE media_ref = OLD.id;
+    DELETE FROM media_serie_mapping WHERE media_ref = OLD.id;
+    DELETE FROM media_people_mapping WHERE media_ref = OLD.id;
+    DELETE FROM shares WHERE media_ref = OLD.id;
+    DELETE FROM unassigned_faces WHERE media_ref = OLD.id;
+    DELETE FROM people_faces WHERE media_ref = OLD.id;
+    DELETE FROM ratings WHERE type = 'media' AND ref = OLD.id;
+    DELETE FROM media_progress WHERE media_ref = OLD.id;
+    UPDATE request_processing SET media_ref = NULL WHERE media_ref = OLD.id;
+END;
+
+-- 2. MOVIE → MEDIAS CASCADE DELETE
+DROP TRIGGER IF EXISTS modified_modified_movie_delete;
+CREATE TRIGGER cascade_delete_movie_medias AFTER DELETE ON movies
+BEGIN
+    DELETE FROM medias WHERE movie = OLD.id;
+END;
+
+-- 3. BOOK CASCADE DELETE
+-- When a book is deleted, remove its medias and mappings
+DROP TRIGGER IF EXISTS modified_medias_book_delete;
+CREATE TRIGGER cascade_delete_book_children AFTER DELETE ON books
+BEGIN
+    DELETE FROM medias WHERE book = OLD.id;
+    DELETE FROM book_tag_mapping WHERE book_ref = OLD.id;
+    DELETE FROM book_people_mapping WHERE book_ref = OLD.id;
+END;
+
+-- 4. SERIES CASCADE DELETE
+-- When a series is deleted, remove episodes, mappings, and detach books
+CREATE TRIGGER cascade_delete_serie_children AFTER DELETE ON series
+BEGIN
+    DELETE FROM episodes WHERE serie_ref = OLD.id;
+    DELETE FROM media_serie_mapping WHERE serie_ref = OLD.id;
+    UPDATE books SET serie_ref = NULL, chapter = NULL WHERE serie_ref = OLD.id;
+END;
+
+-- 5. EPISODE CASCADE DELETE
+-- When an episode is deleted, remove its media mappings
+CREATE TRIGGER cascade_delete_episode_children AFTER DELETE ON episodes
+BEGIN
+    DELETE FROM media_serie_mapping
+        WHERE serie_ref = OLD.serie_ref AND season = OLD.season AND episode = OLD.number;
+END;
+
+-- 6. TAG CASCADE DELETE (path-based to catch all descendants without recursive triggers)
+CREATE TRIGGER cascade_delete_tag_children AFTER DELETE ON tags
+BEGIN
+    -- Clean up mappings for all descendant tags first
+    DELETE FROM media_tag_mapping WHERE tag_ref IN (SELECT id FROM tags WHERE path LIKE OLD.path || OLD.name || '/%');
+    DELETE FROM book_tag_mapping WHERE tag_ref IN (SELECT id FROM tags WHERE path LIKE OLD.path || OLD.name || '/%');
+    DELETE FROM channel_tag_mapping WHERE tag_ref IN (SELECT id FROM tags WHERE path LIKE OLD.path || OLD.name || '/%');
+    -- Delete all descendant tags
+    DELETE FROM tags WHERE path LIKE OLD.path || OLD.name || '/%';
+    -- Clean up mappings for this tag itself
+    DELETE FROM media_tag_mapping WHERE tag_ref = OLD.id;
+    DELETE FROM book_tag_mapping WHERE tag_ref = OLD.id;
+    DELETE FROM channel_tag_mapping WHERE tag_ref = OLD.id;
+END;
+
+-- 7. PEOPLE CASCADE DELETE
+CREATE TRIGGER cascade_delete_people_children AFTER DELETE ON people
+BEGIN
+    DELETE FROM media_people_mapping WHERE people_ref = OLD.id;
+    DELETE FROM book_people_mapping WHERE people_ref = OLD.id;
+    DELETE FROM people_faces WHERE people_ref = OLD.id;
+END;
+
+-- 8. CHANNEL CASCADE DELETE
+CREATE TRIGGER cascade_delete_channel_children AFTER DELETE ON channels
+BEGIN
+    DELETE FROM channel_variants WHERE channel_ref = OLD.id;
+    DELETE FROM channel_tag_mapping WHERE channel_ref = OLD.id;
+END;
+
+-- 9. PEOPLE FACES → media_people_mapping CASCADE
+CREATE TRIGGER cascade_delete_face_refs AFTER DELETE ON people_faces
+BEGIN
+    UPDATE media_people_mapping SET people_face_ref = NULL WHERE people_face_ref = OLD.id;
+END;
+
+-- 10. CLEAN UP ALL EXISTING ORPHANED RECORDS
+-- Medias pointing to non-existent parents
+DELETE FROM medias WHERE movie IS NOT NULL AND movie NOT IN (SELECT id FROM movies);
+DELETE FROM medias WHERE book IS NOT NULL AND book NOT IN (SELECT id FROM books);
+-- Orphaned episodes
+DELETE FROM episodes WHERE serie_ref NOT IN (SELECT id FROM series);
+-- Detach books from non-existent series
+UPDATE books SET serie_ref = NULL, chapter = NULL WHERE serie_ref IS NOT NULL AND serie_ref NOT IN (SELECT id FROM series);
+-- Orphaned media mappings
+DELETE FROM media_tag_mapping WHERE media_ref NOT IN (SELECT id FROM medias);
+DELETE FROM media_tag_mapping WHERE tag_ref NOT IN (SELECT id FROM tags);
+DELETE FROM media_serie_mapping WHERE media_ref NOT IN (SELECT id FROM medias);
+DELETE FROM media_serie_mapping WHERE serie_ref NOT IN (SELECT id FROM series);
+DELETE FROM media_people_mapping WHERE media_ref NOT IN (SELECT id FROM medias);
+DELETE FROM media_people_mapping WHERE people_ref NOT IN (SELECT id FROM people);
+-- Orphaned book mappings
+DELETE FROM book_tag_mapping WHERE book_ref NOT IN (SELECT id FROM books);
+DELETE FROM book_tag_mapping WHERE tag_ref NOT IN (SELECT id FROM tags);
+DELETE FROM book_people_mapping WHERE book_ref NOT IN (SELECT id FROM books);
+DELETE FROM book_people_mapping WHERE people_ref NOT IN (SELECT id FROM people);
+-- Orphaned channel mappings
+DELETE FROM channel_tag_mapping WHERE channel_ref NOT IN (SELECT id FROM channels);
+DELETE FROM channel_tag_mapping WHERE tag_ref NOT IN (SELECT id FROM tags);
+-- Orphaned channel variants
+DELETE FROM channel_variants WHERE channel_ref NOT IN (SELECT id FROM channels);
+-- Orphaned face data
+DELETE FROM people_faces WHERE media_ref IS NOT NULL AND media_ref NOT IN (SELECT id FROM medias);
+DELETE FROM people_faces WHERE people_ref NOT IN (SELECT id FROM people);
+DELETE FROM unassigned_faces WHERE media_ref NOT IN (SELECT id FROM medias);
+-- Orphaned shares, ratings, progress
+DELETE FROM shares WHERE media_ref NOT IN (SELECT id FROM medias);
+DELETE FROM ratings WHERE type = 'media' AND ref NOT IN (SELECT id FROM medias);
+DELETE FROM media_progress WHERE media_ref NOT IN (SELECT id FROM medias);
+-- Orphaned request_processing
+UPDATE request_processing SET media_ref = NULL WHERE media_ref IS NOT NULL AND media_ref NOT IN (SELECT id FROM medias);
+-- Orphaned tag parent references
+DELETE FROM tags WHERE parent IS NOT NULL AND parent NOT IN (SELECT id FROM tags);
+-- Orphaned people_face_ref in media_people_mapping
+UPDATE media_people_mapping SET people_face_ref = NULL WHERE people_face_ref IS NOT NULL AND people_face_ref NOT IN (SELECT id FROM people_faces);