Skip to content

Commit a34c431

Browse files
committed
wip: remove defensive code fixed by 111963
1 parent eb5d728 commit a34c431

File tree

1 file changed

+1
-14
lines changed

1 file changed

+1
-14
lines changed

coverage/sysmon.py

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33

44
"""Callback functions and support for sys.monitoring data collection."""
55

6-
# TODO: https://github.com/python/cpython/issues/111963#issuecomment-2386584080
7-
# commented out stuff with 111963 below...
8-
96
from __future__ import annotations
107

118
import dis
@@ -327,9 +324,6 @@ def __init__(self, tool_id: int) -> None:
327324
# A list of code_objects, just to keep them alive so that id's are
328325
# useful as identity.
329326
self.code_objects: list[CodeType] = []
330-
# 111963:
331-
# # Map id(code_object) -> code_object
332-
# self.local_event_codes: dict[int, CodeType] = {}
333327
self.sysmon_on = False
334328
self.lock = threading.Lock()
335329

@@ -383,12 +377,7 @@ def stop(self) -> None:
383377
return
384378
assert sys_monitoring is not None
385379
sys_monitoring.set_events(self.myid, 0)
386-
with self.lock:
387-
self.sysmon_on = False
388-
# 111963:
389-
# for code in self.local_event_codes.values():
390-
# sys_monitoring.set_local_events(self.myid, code, 0)
391-
# self.local_event_codes = {}
380+
self.sysmon_on = False
392381
sys_monitoring.free_tool_id(self.myid)
393382

394383
@panopticon()
@@ -474,8 +463,6 @@ def sysmon_py_start( # pylint: disable=useless-return
474463
| events.BRANCH_LEFT # type:ignore[attr-defined]
475464
)
476465
sys_monitoring.set_local_events(self.myid, code, local_events)
477-
# 111963:
478-
# self.local_event_codes[id(code)] = code
479466

480467
return None
481468

0 commit comments

Comments
 (0)