Skip to content

Commit b436f44

Browse files
committed
Provide more information in the fail-under message
1 parent 221caf0 commit b436f44

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

coverage/cmdline.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -629,7 +629,10 @@ def command_line(self, argv):
629629
fail_under = self.coverage.get_option("report:fail_under")
630630
precision = self.coverage.get_option("report:precision")
631631
if should_fail_under(total, fail_under, precision):
632-
print("fail-under has failed")
632+
msg = "total of {total:.{p}f} is less than fail-under={fail_under:.{p}f}".format(
633+
total=total, fail_under=fail_under, p=precision,
634+
)
635+
print("Coverage failure:", msg)
633636
return FAIL_UNDER
634637

635638
return OK

tests/test_process.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1236,13 +1236,19 @@ def test_report_43_is_ok(self):
12361236
def test_report_43_is_not_ok(self):
12371237
st, out = self.run_command_status("coverage report --fail-under=44")
12381238
self.assertEqual(st, 2)
1239-
self.assertEqual(self.last_line_squeezed(out), "fail-under has failed")
1239+
self.assertEqual(
1240+
self.last_line_squeezed(out),
1241+
"Coverage failure: total of 43 is less than fail-under=44"
1242+
)
12401243

12411244
def test_report_42p86_is_not_ok(self):
12421245
self.make_file(".coveragerc", "[report]\nprecision = 2")
12431246
st, out = self.run_command_status("coverage report --fail-under=42.88")
12441247
self.assertEqual(st, 2)
1245-
self.assertEqual(self.last_line_squeezed(out), "fail-under has failed")
1248+
self.assertEqual(
1249+
self.last_line_squeezed(out),
1250+
"Coverage failure: total of 42.86 is less than fail-under=42.88"
1251+
)
12461252

12471253

12481254
class FailUnderNoFilesTest(CoverageTest):

0 commit comments

Comments
 (0)