Skip to content

Commit 738d3a4

Browse files
author
Pamela McA'Nulty
committed
Fix django 2.0 support issues
1 parent bc66bb0 commit 738d3a4

File tree

1 file changed

+15
-4
lines changed

1 file changed

+15
-4
lines changed

tests/test_integration.py

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def target_view(request):
6060
6161
class TestViews(TestCase):
6262
def test_view_target_view(self):
63-
from django.core.urlresolvers import reverse
63+
%(import_reverse)s
6464
6565
%(define_target_view)s
6666
@@ -197,12 +197,19 @@ def _create_django_project(self, project_name, app_name):
197197
# print f.read()
198198
self.config_file = self._add_project_file(COVERAGE_CFG_FILE_TEXT, "coverage.cfg")
199199
self.template_file = self._add_project_file(TEMPLATE_FILE_TEXT, app_name, "templates", "target_template.html")
200+
200201
if django.VERSION < (1, 8):
201202
define_target_view = '"app_template_render.views.target_view"'
202203
else:
203204
define_target_view = 'from app_template_render.views import target_view'
205+
if django.VERSION < (1, 10):
206+
import_reverse = "from django.core.urlresolvers import reverse"
207+
else:
208+
import_reverse = "from django.urls import reverse"
209+
204210
test_views_text = TEST_VIEWS_FILE_TEXT % locals()
205211
self.test_views_file = self._add_project_file(test_views_text, app_name, "test_views.py")
212+
206213
self.views_file = os.path.join(self.project_dir, app_name, "views.py")
207214
self.urls_file = os.path.join(self.project_dir, project_name, "urls.py")
208215
self.test_views_file = self._add_project_file("", app_name, "templatetags", "__init__.py")
@@ -259,10 +266,14 @@ def test_template_render(self):
259266
self.assertIsCovered(coverage_report, "integration_template_render/__init__.py")
260267
self.assertIsCovered(coverage_report, "integration_template_render/urls.py")
261268

262-
if django.VERSION >= (1, 10):
269+
if django.VERSION < (1, 10):
270+
expect_missing, expect_pct = 0, 100
271+
elif django.VERSION < (2, 0):
263272
expect_missing, expect_pct = 6, 54
264273
else:
265-
expect_missing, expect_pct = 0, 100
274+
# This is django-tip, so it's likely to change over time.
275+
expect_missing, expect_pct = 2, 78
276+
266277
self.assertIsCovered(coverage_report, "manage.py", expect_missing, expect_pct)
267278
self.assertIsCovered(coverage_report, "app_template_render/__init__.py")
268279
self.assertIsCovered(coverage_report, "app_template_render/views.py")
@@ -307,7 +318,7 @@ def missing_line_numbers(self):
307318
continue
308319
elif "-" in chunk:
309320
start, end = chunk.split("-", 1)
310-
for i in range(int(start), int(end)):
321+
for i in range(int(start), int(end+1)):
311322
yield i
312323
else:
313324
yield int(chunk)

0 commit comments

Comments
 (0)