@@ -60,7 +60,7 @@ def target_view(request):
60
60
61
61
class TestViews(TestCase):
62
62
def test_view_target_view(self):
63
- from django.core.urlresolvers import reverse
63
+ %(import_reverse)s
64
64
65
65
%(define_target_view)s
66
66
@@ -197,12 +197,19 @@ def _create_django_project(self, project_name, app_name):
197
197
# print f.read()
198
198
self .config_file = self ._add_project_file (COVERAGE_CFG_FILE_TEXT , "coverage.cfg" )
199
199
self .template_file = self ._add_project_file (TEMPLATE_FILE_TEXT , app_name , "templates" , "target_template.html" )
200
+
200
201
if django .VERSION < (1 , 8 ):
201
202
define_target_view = '"app_template_render.views.target_view"'
202
203
else :
203
204
define_target_view = 'from app_template_render.views import target_view'
205
+ if django .VERSION < (1 , 10 ):
206
+ import_reverse = "from django.core.urlresolvers import reverse"
207
+ else :
208
+ import_reverse = "from django.urls import reverse"
209
+
204
210
test_views_text = TEST_VIEWS_FILE_TEXT % locals ()
205
211
self .test_views_file = self ._add_project_file (test_views_text , app_name , "test_views.py" )
212
+
206
213
self .views_file = os .path .join (self .project_dir , app_name , "views.py" )
207
214
self .urls_file = os .path .join (self .project_dir , project_name , "urls.py" )
208
215
self .test_views_file = self ._add_project_file ("" , app_name , "templatetags" , "__init__.py" )
@@ -259,10 +266,14 @@ def test_template_render(self):
259
266
self .assertIsCovered (coverage_report , "integration_template_render/__init__.py" )
260
267
self .assertIsCovered (coverage_report , "integration_template_render/urls.py" )
261
268
262
- if django .VERSION >= (1 , 10 ):
269
+ if django .VERSION < (1 , 10 ):
270
+ expect_missing , expect_pct = 0 , 100
271
+ elif django .VERSION < (2 , 0 ):
263
272
expect_missing , expect_pct = 6 , 54
264
273
else :
265
- expect_missing , expect_pct = 0 , 100
274
+ # This is django-tip, so it's likely to change over time.
275
+ expect_missing , expect_pct = 2 , 78
276
+
266
277
self .assertIsCovered (coverage_report , "manage.py" , expect_missing , expect_pct )
267
278
self .assertIsCovered (coverage_report , "app_template_render/__init__.py" )
268
279
self .assertIsCovered (coverage_report , "app_template_render/views.py" )
@@ -307,7 +318,7 @@ def missing_line_numbers(self):
307
318
continue
308
319
elif "-" in chunk :
309
320
start , end = chunk .split ("-" , 1 )
310
- for i in range (int (start ), int (end )):
321
+ for i in range (int (start ), int (end + 1 )):
311
322
yield i
312
323
else :
313
324
yield int (chunk )
0 commit comments