Skip to content

Commit c2098b4

Browse files
author
Pamela McA'Nulty
committed
Fixes for DJ 1.8
1 parent 4aeebe3 commit c2098b4

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

tests/test_integration.py

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import subprocess
88
import shutil
99

10-
from .plugin_test import DjangoPluginTestCase
10+
from .plugin_test import DjangoPluginTestCase, django_start_at
1111

1212
import django
1313

@@ -124,8 +124,13 @@ def _add_installed_app(self, app_name):
124124
settings_data = f.read()
125125
#self._print_file(settings_data, self.settings_file)
126126

127-
sep_open, sep_close = ("(", ")") if django.VERSION <= (1, 8) else ("[", "]")
128-
before, after = settings_data.split("INSTALLED_APPS = %s" % sep_open, 1)
127+
sep_open, sep_close = ("(", ")") if django.VERSION < (1, 9) else ("[", "]")
128+
try:
129+
before, after = settings_data.split("INSTALLED_APPS = %s" % sep_open, 1)
130+
except Exception:
131+
self._print_file(settings_data, self.settings_file)
132+
raise
133+
129134
apps, after = after.split(sep_close, 1)
130135
apps = "%s\n '%s',\n" % (apps, app_name)
131136
settings_data = "%sINSTALLED_APPS = %s%s%s%s" % (before, sep_open, apps, sep_close, after)
@@ -218,10 +223,8 @@ def _add_url(self, project_name, app_name, view_func, view_name):
218223
urls_data = urls_data.replace("]", fmt % locals())
219224
self._save_py_file(self.urls_file, urls_data)
220225

226+
@django_start_at(1, 8)
221227
def test_template_render(self):
222-
if django.VERSION <= (1, 7):
223-
return
224-
225228
self._create_django_project("integration_template_render", "app_template_render")
226229

227230
output, coverage_report = self._run_coverage("manage.py", "test", "app_template_render")
@@ -238,7 +241,7 @@ def test_template_render(self):
238241
if django.VERSION >= (1, 10):
239242
expect_missing, expect_pct = 6, 54
240243
else:
241-
expect_missing, expect_pct = 0, 0
244+
expect_missing, expect_pct = 0, 100
242245
self.assertIsCovered(coverage_report, "manage.py", expect_missing, expect_pct)
243246
self.assertIsCovered(coverage_report, "app_template_render/__init__.py")
244247
self.assertIsCovered(coverage_report, "app_template_render/views.py")

0 commit comments

Comments
 (0)