Fix warnings for unused variables

Author: avit

lib/ice_cube/time_util.rb

@@ -170,7 +170,7 @@ def self.sym_to_wday(sym)
 
     # Convert wday number to day symbol
     def self.wday_to_sym(wday)
-      return sym = wday if DAYS.keys.include? wday
+      return wday if DAYS.keys.include? wday
       DAYS.invert.fetch(wday) do |i|
         raise ArgumentError, "Expecting Integer value for weekday. " \
                              "No such wday number: #{i.inspect}"

spec/examples/active_support_spec.rb

@@ -22,7 +22,7 @@ module IceCube
     end
 
     it 'works with a monthly recurrence rule starting from a TimeWithZone' do
-      schedule = Schedule.new(t0 = Time.zone.parse("2010-02-05 05:00:00"))
+      schedule = Schedule.new(Time.zone.parse("2010-02-05 05:00:00"))
       schedule.add_recurrence_rule Rule.monthly
       expect(schedule.first(10)).to eq([
         Time.zone.parse("2010-02-05 05:00"), Time.zone.parse("2010-03-05 05:00"),
@@ -35,7 +35,7 @@ module IceCube
 
     it 'works with a monthly schedule converting to UTC across DST' do
       Time.zone = 'Eastern Time (US & Canada)'
-      schedule = Schedule.new(t0 = Time.zone.parse("2009-10-28 19:30:00"))
+      schedule = Schedule.new(Time.zone.parse("2009-10-28 19:30:00"))
       schedule.add_recurrence_rule Rule.monthly
       expect(schedule.first(7).map { |d| d.getutc }).to eq([
         Time.utc(2009, 10, 28, 23, 30, 0), Time.utc(2009, 11, 29,  0, 30, 0),
@@ -53,13 +53,13 @@ module IceCube
     end
 
     it 'uses local zone from start time to determine occurs_on? from the beginning of day' do
-      schedule = Schedule.new(t0 = Time.local(2009, 2, 7, 23, 59, 59))
+      schedule = Schedule.new(Time.local(2009, 2, 7, 23, 59, 59))
       schedule.add_recurrence_rule Rule.daily
       expect(schedule.occurs_on?(Date.new(2009, 2, 7))).to be_truthy
     end
 
     it 'uses local zone from start time to determine occurs_on? to the end of day' do
-      schedule = Schedule.new(t0 = Time.local(2009, 2, 7, 0, 0, 0))
+      schedule = Schedule.new(Time.local(2009, 2, 7, 0, 0, 0))
       schedule.add_recurrence_rule Rule.daily
       expect(schedule.occurs_on?(Date.new(2009, 2, 7))).to be_truthy
     end

spec/examples/daily_rule_spec.rb

@@ -14,13 +14,13 @@ module IceCube
 
     it 'raises an argument error when a bad value is passed using the interval method' do
       expect {
-        rule = Rule.daily.interval("invalid")
+        Rule.daily.interval("invalid")
       }.to raise_error(ArgumentError, "'invalid' is not a valid input for interval. Please pass a postive integer.")
     end
 
     it 'raises an argument error when a bad value is passed' do
       expect {
-        rule = Rule.daily("invalid")
+        Rule.daily("invalid")
       }.to raise_error(ArgumentError, "'invalid' is not a valid input for interval. Please pass a postive integer.")
     end
   end
@@ -30,7 +30,7 @@ module IceCube
     describe 'in Vancouver time', :system_time_zone => 'America/Vancouver' do
 
       it 'should include nearest time in DST start hour' do
-        schedule = Schedule.new(t0 = Time.local(2013, 3, 9, 2, 30, 0))
+        schedule = Schedule.new(Time.local(2013, 3, 9, 2, 30, 0))
         schedule.add_recurrence_rule Rule.daily
         expect(schedule.first(3)).to eq([
           Time.local(2013, 3,  9, 2, 30, 0), # -0800
@@ -40,7 +40,7 @@ module IceCube
       end
 
       it 'should not skip times in DST end hour' do
-        schedule = Schedule.new(t0 = Time.local(2013, 11, 2, 2, 30, 0))
+        schedule = Schedule.new(Time.local(2013, 11, 2, 2, 30, 0))
         schedule.add_recurrence_rule Rule.daily
         expect(schedule.first(3)).to eq([
           Time.local(2013, 11, 2, 2, 30, 0), # -0700
@@ -50,7 +50,7 @@ module IceCube
       end
 
       it 'should include nearest time to DST start when locking hour_of_day' do
-        schedule = Schedule.new(t0 = Time.local(2013, 3, 9, 2, 0, 0))
+        schedule = Schedule.new(Time.local(2013, 3, 9, 2, 0, 0))
         schedule.add_recurrence_rule Rule.daily.hour_of_day(2)
         expect(schedule.first(3)).to eq([
           Time.local(2013, 3,  9, 2, 0, 0), # -0800

spec/examples/dst_spec.rb

@@ -37,10 +37,8 @@ module IceCube
       schedule.add_recurrence_rule Rule.daily
       # each occurrence MUST occur at 5pm, then we win
       dates = schedule.occurrences(start_time + 20 * ONE_DAY)
-      last = start_time
       dates.each do |date|
         expect(date.hour).to eq(5)
-        last = date
       end
     end
 

spec/examples/hourly_rule_spec.rb

@@ -15,21 +15,21 @@ module IceCube
 
       it 'raises an argument error when a bad value is passed' do
         expect {
-          rule = Rule.hourly("invalid")
+          Rule.hourly("invalid")
         }.to raise_error(ArgumentError, "'invalid' is not a valid input for interval. Please pass a postive integer.")
       end
 
       it 'raises an argument error when a bad value is passed using the interval method' do
         expect {
-          rule = Rule.hourly.interval("invalid")
+          Rule.hourly.interval("invalid")
         }.to raise_error(ArgumentError, "'invalid' is not a valid input for interval. Please pass a postive integer.")
       end
     end
 
     context 'in Vancouver time', :system_time_zone => 'America/Vancouver' do
 
       it 'should work across DST start hour' do
-        schedule = Schedule.new(t0 = Time.local(2013, 3, 10, 1, 0, 0))
+        schedule = Schedule.new(Time.local(2013, 3, 10, 1, 0, 0))
         schedule.add_recurrence_rule Rule.hourly
         expect(schedule.first(3)).to eq([
           Time.local(2013, 3, 10, 1, 0, 0), # -0800
@@ -39,7 +39,7 @@ module IceCube
       end
 
       it 'should not skip times in DST end hour' do
-        schedule = Schedule.new(t0 = Time.local(2013, 11, 3, 0, 0, 0))
+        schedule = Schedule.new(Time.local(2013, 11, 3, 0, 0, 0))
         schedule.add_recurrence_rule Rule.hourly
         expect(schedule.first(4)).to eq([
           Time.local(2013, 11, 3, 0, 0, 0),             # -0700

spec/examples/minutely_rule_spec.rb

@@ -14,13 +14,13 @@ module IceCube
 
     it 'raises an argument error when a bad value is passed' do
       expect {
-        rule = Rule.minutely("invalid")
+        Rule.minutely("invalid")
       }.to raise_error(ArgumentError, "'invalid' is not a valid input for interval. Please pass a postive integer.")
     end
 
     it 'raises an argument error when a bad value is passed when using the interval method' do
       expect {
-        rule = Rule.minutely.interval("invalid")
+        Rule.minutely.interval("invalid")
       }.to raise_error(ArgumentError, "'invalid' is not a valid input for interval. Please pass a postive integer.")
     end
 

spec/examples/monthly_rule_spec.rb

@@ -19,13 +19,13 @@ module IceCube
 
     it 'raises an argument error when a bad value is passed' do
       expect {
-        rule = Rule.monthly("invalid")
+        Rule.monthly("invalid")
       }.to raise_error(ArgumentError, "'invalid' is not a valid input for interval. Please pass a postive integer.")
     end
 
     it 'raises an argument error when a bad value is passed using the interval method' do
       expect {
-        rule = Rule.monthly.interval("invalid")
+        Rule.monthly.interval("invalid")
       }.to raise_error(ArgumentError, "'invalid' is not a valid input for interval. Please pass a postive integer.")
     end
   end
@@ -92,8 +92,9 @@ module IceCube
     [:sunday, :monday, :tuesday, :wednesday, :thursday, :friday, :saturday].each_with_index do |weekday, wday|
       context "for every first #{weekday} of a month" do
         let(:schedule) {
-          schedule = Schedule.new(t0 = Time.local(2011, 8, 1))
-          schedule.add_recurrence_rule Rule.monthly.day_of_week(weekday => [1])
+          Schedule.new(Time.local(2011, 8, 1)) do |s|
+            s.add_recurrence_rule Rule.monthly.day_of_week(weekday => [1])
+          end
         }
 
         it "should not skip a month when DST ends" do
@@ -120,7 +121,7 @@ module IceCube
     end
 
     it 'should produce dates on a monthly interval for the last day of the month' do
-      schedule = Schedule.new(t0 = Time.utc(2010, 3, 31, 0, 0, 0))
+      schedule = Schedule.new(Time.utc(2010, 3, 31, 0, 0, 0))
       schedule.add_recurrence_rule Rule.monthly
       expect(schedule.first(10)).to eq([
         Time.utc(2010,  3, 31, 0, 0, 0), Time.utc(2010,  4, 30, 0, 0, 0),
@@ -132,7 +133,7 @@ module IceCube
     end
 
     it 'should produce dates on a monthly interval for latter days in the month near February' do
-      schedule = Schedule.new(t0 = Time.utc(2010, 1, 29, 0, 0, 0))
+      schedule = Schedule.new(Time.utc(2010, 1, 29, 0, 0, 0))
       schedule.add_recurrence_rule Rule.monthly
       expect(schedule.first(3)).to eq([
         Time.utc(2010, 1, 29, 0, 0, 0),
@@ -142,7 +143,7 @@ module IceCube
     end
 
     it 'should restrict to available days of month when specified' do
-      schedule = Schedule.new(t0 = Time.utc(2013,1,31))
+      schedule = Schedule.new(Time.utc(2013,1,31))
       schedule.add_recurrence_rule Rule.monthly.day_of_month(31)
       expect(schedule.first(3)).to eq([
         Time.utc(2013, 1, 31),

spec/examples/regression_spec.rb

@@ -12,15 +12,15 @@ module IceCube
         end
 
         it 'should consider recurrence times properly in find_occurreces [#43]' do
-          schedule = Schedule.new(t0 = Time.local(2011, 10, 1, 18, 25))
+          schedule = Schedule.new(Time.local(2011, 10, 1, 18, 25))
           schedule.add_recurrence_time Time.local(2011, 12, 3, 15, 0, 0)
           schedule.add_recurrence_time Time.local(2011, 12, 3, 10, 0, 0)
           schedule.add_recurrence_time Time.local(2011, 12, 4, 10, 0, 0)
           expect(schedule.occurs_at?(Time.local(2011, 12, 3, 15, 0, 0))).to be_truthy
         end
 
         it 'should work well with occurrences_between [#33]' do
-          schedule = Schedule.new(t0 = Time.local(2011, 10, 11, 12))
+          schedule = Schedule.new(Time.local(2011, 10, 11, 12))
           schedule.add_recurrence_rule Rule.weekly.day(1).hour_of_day(12).minute_of_hour(0)
           schedule.add_recurrence_rule Rule.weekly.day(2).hour_of_day(15).minute_of_hour(0)
           schedule.add_exception_time Time.local(2011, 10, 13, 21)
@@ -37,13 +37,13 @@ module IceCube
         end
 
         it 'should not regress [#40]' do
-          schedule = Schedule.new(t0 = Time.local(2011, 11, 16, 11, 31, 58), :duration => 3600)
+          schedule = Schedule.new(Time.local(2011, 11, 16, 11, 31, 58), :duration => 3600)
           schedule.add_recurrence_rule Rule.minutely(60).day(4).hour_of_day(14, 15, 16).minute_of_hour(0)
           expect(schedule.occurring_at?(Time.local(2011, 11, 17, 15, 30))).to be_falsey
         end
 
         it 'should not choke on parsing [#26]' do
-          schedule = Schedule.new(t0 = Time.local(2011, 8, 9, 14, 52, 14))
+          schedule = Schedule.new(Time.local(2011, 8, 9, 14, 52, 14))
           schedule.rrule Rule.weekly(1).day(1, 2, 3, 4, 5)
           expect { Schedule.from_yaml(schedule.to_yaml) }.to_not raise_error
         end
@@ -77,7 +77,7 @@ module IceCube
         end
 
         it 'should produce all occurrences between dates, not breaking on exceptions [#82]' do
-          schedule = Schedule.new(t0 = Time.new(2012, 5, 1))
+          schedule = Schedule.new(Time.new(2012, 5, 1))
           schedule.add_recurrence_rule Rule.daily.day(:sunday, :tuesday, :wednesday, :thursday, :friday, :saturday)
           times = schedule.occurrences_between(Time.new(2012, 5, 19), Time.new(2012, 5, 24))
           expect(times).to eq([
@@ -98,7 +98,7 @@ module IceCube
         end
 
         it 'should produce occurrences regardless of time being specified [#81]' do
-          schedule = Schedule.new(t0 = Time.new(2012, 5, 1))
+          schedule = Schedule.new(Time.new(2012, 5, 1))
           schedule.add_recurrence_rule Rule.daily.hour_of_day(8)
           times = schedule.occurrences_between(Time.new(2012, 05, 20), Time.new(2012, 05, 22))
           expect(times).to eq([
@@ -138,7 +138,7 @@ module IceCube
           :rtimes: []
           :extimes: []
           EOS
-          times = schedule.occurrences(Date.new(2013, 07, 13).to_time)
+          expect(schedule.occurrences(Date.new(2013, 07, 13).to_time)).to be_a Array
         end
 
         it 'should still include date over DST boundary [#98]', expect_warnings: true do # set local to Sweden
@@ -187,7 +187,7 @@ module IceCube
         end
 
         it 'should not infinite loop [#109]' do
-          schedule = Schedule.new(t0 = Time.new(2012, 4, 27, 0, 0, 0))
+          schedule = Schedule.new(Time.new(2012, 4, 27, 0, 0, 0))
           schedule.rrule Rule.weekly.day(:monday, :tuesday, :wednesday, :thursday, :friday, :saturday, :sunday).hour_of_day(0).minute_of_hour(0).second_of_minute(0)
           schedule.duration = 3600
           t1 = Time.new(2012, 10, 20, 0, 0, 0)
@@ -196,7 +196,7 @@ module IceCube
         end
 
         it 'should return next_occurrence in utc if start_time is utc [#115]' do
-          schedule = Schedule.new(t0 = Time.utc(2012, 10, 10, 20, 15, 0))
+          schedule = Schedule.new(Time.utc(2012, 10, 10, 20, 15, 0))
           schedule.rrule Rule.daily
           expect(schedule.next_occurrence).to be_utc
         end

spec/examples/rfc_spec.rb

@@ -66,8 +66,7 @@
   it 'should ~ weekly until december 24, 1997' do
     schedule = IceCube::Schedule.new(Time.utc(1997, 9, 2))
     schedule.add_recurrence_rule IceCube::Rule.weekly.until(Time.utc(1997, 12, 24))
-    dates = schedule.occurrences(Time.utc(1997, 12, 24))
-    #test expectations
+
     test_expectations(schedule, {1997 => {9 => [2, 9, 16, 23, 30], 10 => [7, 14, 21, 28], 11 => [4, 11, 18, 25], 12 => [2, 9, 16, 23]}})
   end
 
@@ -84,7 +83,6 @@
     end
   end
 
-  #
   it 'should ~ weekly on tuesday and thursday for 5 weeks (a)' do
     start_time = Time.utc(1997, 9, 2)
     schedule = IceCube::Schedule.new(start_time)
@@ -107,7 +105,6 @@
     expect(dates).to eq(expectation.flatten)
   end
 
-  #
   it 'should ~ every other week on monday, wednesday and friday until december 24, 1997 but starting on tuesday september 2, 1997' do
     start_time = Time.utc(1997, 9, 2)
     schedule = IceCube::Schedule.new(start_time)

spec/examples/secondly_rule_spec.rb

@@ -14,13 +14,13 @@ module IceCube
 
     it 'raises an argument error when a bad value is passed' do
       expect {
-        rule = Rule.secondly("invalid")
+        Rule.secondly("invalid")
       }.to raise_error(ArgumentError, "'invalid' is not a valid input for interval. Please pass a postive integer.")
     end
 
     it 'raises an argument error when a bad value is passed using the interval method' do
       expect {
-        rule = Rule.secondly.interval("invalid")
+        Rule.secondly.interval("invalid")
       }.to raise_error(ArgumentError, "'invalid' is not a valid input for interval. Please pass a postive integer.")
     end
   end