Skip to content

Commit cd94434

Browse files
authored
Remove broken tests (#1357)
In PHPUnit 11, all closures are considered equal, so those test assertions are passing even if we replace the closure with an unrelated one. In PHPUnit 12, closures are compared by identity. This is incompatible with the deep cloning of parameters. See sebastianbergmann/comparator#129
1 parent b799cb5 commit cd94434

File tree

2 files changed

+0
-5
lines changed

2 files changed

+0
-5
lines changed

tests/Generator/Resolver/ParameterResolverIntegrationTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,6 @@ public static function provideParameters(): iterable
110110
'int_param' => 2000,
111111
'float_param' => -.89,
112112
'object_param' => new stdClass(),
113-
'closure_param' => static function (): void {
114-
},
115113
'class_param' => 'App\Test\Dummy',
116114
'array_value' => [
117115
'dummy',

tests/ParameterTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,6 @@ public static function provideValues(): iterable
6565
'string' => ['foo'],
6666
'null' => [null],
6767
'object' => [new stdClass()],
68-
'closure' => [
69-
static function (): void {
70-
}],
7168
'array' => [[new stdClass()]],
7269
];
7370
}

0 commit comments

Comments
 (0)