fix bug for yarn update single (#7)

Author: nemanjajojic

TODO.md

@@ -11,4 +11,6 @@
 - [x] Update all packages
 - [x] Update single package
 - [x] Add health check command
+- [] Add tests
+- [] Add list of updated packages after update command
 - [] Support PyPi

lua/package-version/command.lua

@@ -17,31 +17,19 @@ end
 M.register_commands = function(config)
 	create_command("PackageVersionInstalled", function()
 		strategy.installed(config)
-	end, "Toggle instaled package version")
+	end, "Toggle installed package version")
 
 	create_command("PackageVersionOutdated", function()
 		strategy.outdated(config)
-	end, "Togglge outdated package version")
+	end, "Toggle outdated package version")
 
 	create_command("PackageVersionUpdateAll", function()
 		strategy.update_all(config)
 	end, "Update all packages")
 
-	create_command("PackageVersionUpdateOne", function()
+	create_command("PackageVersionUpdateSingle", function()
 		strategy.update_single(config)
-	end, "Update singgle packages")
+	end, "Update single package")
 end
 
--- M.register_autocmds = function()
--- 	vim.api.nvim_create_augroup("InstlledGroup", { clear = true })
---
--- 	vim.api.nvim_create_autocmd({ "BufReadPost" }, {
--- 		group = "InstlledGroup",
--- 		pattern = "composer.json",
--- 		callback = function()
--- 			vim.api.nvim_command("PackageVersionInstalled")
--- 			vim.api.nvim_command("PackageVersionInstalled")
--- 		end,
--- 	})
--- end
 return M

lua/package-version/health.lua

@@ -35,7 +35,7 @@ local executable_managers = function()
 	else
 		vim.health.warn(
 			"Local Pnpm is not found in your system PATH.",
-			"In case you are using Pnpm, or using it via docker, you can ignore this warning"
+			"In case you are not using Pnpm, or using it via docker, you can ignore this warning"
 		)
 	end
 
@@ -46,12 +46,12 @@ local executable_managers = function()
 	else
 		vim.health.warn(
 			"Local Yarn is not found in your system PATH.",
-			"In case you are using Yarn, or using it via docker, you can ignore this warning"
+			"In case you are not using Yarn, or using it via docker, you can ignore this warning"
 		)
 	end
 
 	if count_of_available_managers == 0 then
-		vim.health.error("No package managers found localay", {
+		vim.health.error("No package managers found locally", {
 			"You have to install at least one of the supported package managers: Composer, Npm, Pnpm, Yarn.",
 			"Or you can use via docker by setting up the docker configuration.",
 		})
@@ -66,14 +66,14 @@ function M.check()
 	vim.health.info("Depends on on your project you'll not have to have all package managers.")
 
 	if vim.fn.executable("docker") == 1 then
-		vim.health.ok("Docker is not installed.")
+		vim.health.ok("Docker is installed.")
 
 		local docker = plugin.config.docker
 
 		if not docker then
 			vim.health.warn(
 				"Docker configuration is not set.",
-				"In case you have plugin manager installed localy you can ignore this warning"
+				"In case you have plugin manager installed locally you can ignore this warning"
 			)
 
 			executable_managers()
@@ -85,7 +85,7 @@ function M.check()
 			else
 				vim.health.warn(
 					"Composer Docker container name is not set.",
-					"If you are not using composer, or you are using localy, you can ignore this warning"
+					"If you are not using composer, or you are using locally, you can ignore this warning"
 				)
 			end
 
@@ -96,7 +96,7 @@ function M.check()
 			else
 				vim.health.warn(
 					"Npm Docker container name is not set.",
-					"If you are not using npm, or you are using localy, you can ignore this warning"
+					"If you are not using npm, or you are using locally, you can ignore this warning"
 				)
 			end
 
@@ -107,7 +107,7 @@ function M.check()
 			else
 				vim.health.warn(
 					"Pnpm Docker container name is not set.",
-					"If you are not using pnpm, or you are using localy, you can ignore this warning"
+					"If you are not using pnpm, or you are using locally, you can ignore this warning"
 				)
 			end
 
@@ -118,14 +118,14 @@ function M.check()
 			else
 				vim.health.warn(
 					"Yarn Docker container name is not set.",
-					"If you are not using yarn, or you are using localy, you can ignore this warning"
+					"If you are not using yarn, or you are using locally, you can ignore this warning"
 				)
 			end
 
 			if count_of_containers == 0 then
-				vim.health.error("Docke config is detected without any container set.", {
+				vim.health.error("Docker config is detected without any container set.", {
 					"You have to set at least one of the supported package manager container names: composer_container_name, npm_container_name, pnpm_container_name, yarn_container_name",
-					"In case you wanna use from local, you have to remove docker config entirelly",
+					"In case you wanna use from local, you have to remove docker config entirely",
 				})
 
 				executable_managers()

lua/package-version/package-manager/composer.lua

@@ -64,7 +64,10 @@ M.installed = function(package_config)
 
 	local on_exit = function(job_id, code, event)
 		if code ~= 0 then
-			logger.error("Command 'composer outdated' failed with code: " .. code)
+			logger.error("Command 'composer show' failed with code: " .. code)
+
+			spinner.hide()
+			is_installed_command_running = false
 
 			return
 		end
@@ -138,7 +141,7 @@ M.installed = function(package_config)
 end
 
 ---@param package_config? PackageVersionConfig
-M.outated = function(package_config)
+M.outdated = function(package_config)
 	if is_outdated_command_running then
 		logger.warning("Composer outdated command is already running.")
 
@@ -169,6 +172,9 @@ M.outated = function(package_config)
 		if code ~= 0 then
 			logger.error("Command 'composer outdated' failed with code: " .. code)
 
+			spinner.hide()
+			is_outdated_command_running = false
+
 			return
 		end
 
@@ -275,7 +281,7 @@ M.update_all = function(package_config)
 			return
 		end
 
-		spinner.hide("Composer packages updated sucessuflly!")
+		spinner.hide("Composer packages updated successfully!")
 
 		is_update_all_command_running = false
 	end
@@ -335,7 +341,7 @@ M.update_single = function(package_config)
 		if is_package_up_to_date then
 			spinner.hide("Package " .. package_name .. " is already up to date!")
 		else
-			spinner.hide("Package " .. package_name .. " updated sucessuflly!")
+			spinner.hide("Package " .. package_name .. " updated successfully!")
 		end
 
 		is_update_single_command_running = false

lua/package-version/package-manager/npm.lua

@@ -58,11 +58,14 @@ M.installed = function(package_config)
 	local installed = {}
 
 	local on_exit = function(code)
-		-- if code ~= 0 then
-		-- 	logger.error("Command NPM installed' failed with code: " .. code)
-		--
-		-- 	return
-		-- end
+		if code ~= 0 then
+			logger.error("Command 'npm list' failed with code: " .. code)
+
+			spinner.hide()
+			is_installed_command_running = false
+
+			return
+		end
 
 		local json_str = table.concat(installed, "\n")
 
@@ -150,7 +153,17 @@ M.outdated = function(package_config)
 
 	local outdated = {}
 
-	local on_exit = function()
+	local on_exit = function(code)
+		-- npm outdated returns exit code 1 when outdated packages exist, which is expected
+		if code ~= 0 and code ~= 1 then
+			logger.error("Command 'npm outdated' failed with code: " .. code)
+
+			spinner.hide()
+			is_outdated_command_running = false
+
+			return
+		end
+
 		local json_str = table.concat(outdated, "\n")
 
 		local ok
@@ -263,7 +276,7 @@ M.update_all = function(package_config)
 			return
 		end
 
-		spinner.hide("NPM packages updated sucessuflly!")
+		spinner.hide("NPM packages updated successfully!")
 
 		is_update_all_command_running = false
 	end
@@ -337,7 +350,7 @@ M.update_single = function(package_config)
 		if result.changed == 0 then
 			spinner.hide("Package " .. package_name .. " is already up to date!")
 		else
-			spinner.hide("Package " .. package_name .. " updated sucessuflly!")
+			spinner.hide("Package " .. package_name .. " updated successfully!")
 		end
 
 		is_update_single_command_running = false

lua/package-version/package-manager/pnpm.lua

@@ -59,7 +59,10 @@ M.installed = function(package_config)
 
 	local on_exit = function(job_id, code, event)
 		if code ~= 0 then
-			logger.error("Command PNPM installed' failed with code: " .. code)
+			logger.error("Command 'pnpm list' failed with code: " .. code)
+
+			spinner.hide()
+			is_installed_command_running = false
 
 			return
 		end
@@ -155,6 +158,16 @@ M.outdated = function(package_config)
 	local outdated = {}
 
 	local on_exit = function(job_id, code, event)
+		-- pnpm outdated returns exit code 1 when outdated packages exist, which is expected
+		if code ~= 0 and code ~= 1 then
+			logger.error("Command 'pnpm outdated' failed with code: " .. code)
+
+			spinner.hide()
+			is_outdated_command_running = false
+
+			return
+		end
+
 		local json_str = table.concat(outdated, "\n")
 
 		local ok
@@ -270,7 +283,7 @@ M.update_all = function(package_config)
 			return
 		end
 
-		spinner.hide("PNPM packages updated sucessuflly!")
+		spinner.hide("PNPM packages updated successfully!")
 
 		is_update_all_command_running = false
 	end
@@ -329,7 +342,7 @@ M.update_single = function(package_config)
 		if is_package_up_to_date then
 			spinner.hide("Package " .. package_name .. " is already up to date!")
 		else
-			spinner.hide("Package " .. package_name .. " updated sucessuflly!")
+			spinner.hide("Package " .. package_name .. " updated successfully!")
 		end
 
 		is_update_single_command_running = false