Skip to content

Commit 2fa9d83

Browse files
committed
remove link- from Link variants
1 parent 7f1b0e8 commit 2fa9d83

File tree

9 files changed

+19
-18
lines changed

9 files changed

+19
-18
lines changed

src/components/Footer.astro

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ const trimmedMessage = limitString(message, messageLength);
4848
rel="me noreferrer noopener"
4949
title="@nemanjam on Github"
5050
class="flex items-center gap-2 text-base xs:text-lg"
51-
variant="link-nav"
51+
variant="nav"
5252
>
5353
<Icon name="mdi:github" class="h-6 w-6 fill-current" />
5454
<span>Github</span>
@@ -61,7 +61,7 @@ const trimmedMessage = limitString(message, messageLength);
6161
rel="me noreferrer noopener"
6262
title="Nemanja on LinkedIn"
6363
class="flex items-center gap-2 text-base xs:text-lg"
64-
variant="link-nav"
64+
variant="nav"
6565
>
6666
<Icon name="mdi:linkedin" class="h-6 w-6 fill-current" />
6767
<span>LinkedIn</span>
@@ -72,7 +72,7 @@ const trimmedMessage = limitString(message, messageLength);
7272
href={ROUTES.API.FEED_RSS}
7373
title={`RSS feed for ${domain}`}
7474
class="flex items-center gap-2 text-base xs:text-lg"
75-
variant="link-nav"
75+
variant="nav"
7676
>
7777
<Icon name="mdi:rss" class="h-6 w-6 fill-current" />
7878
<span>RSS Feed</span>

src/components/HeaderLink.astro

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ export interface Props extends astroHTML.JSX.AnchorHTMLAttributes {
1010
const { slot, isActive = false, class: className, ...props } = Astro.props as Props;
1111
---
1212

13-
<Link {...props} variant="link-nav" class={cn({ 'underline text-links': isActive }, className)}>
13+
<Link {...props} variant="nav" class={cn({ 'underline text-links': isActive }, className)}>
1414
<slot />
1515
</Link>

src/components/Link.astro

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ const linkVariants = cva('link-default', {
99
variant: {
1010
link: 'link',
1111
'no-underline': 'link-no-underline',
12-
'link-heading': 'link-heading',
13-
'link-nav': 'link-nav',
14-
'link-markdown': 'link-markdown',
12+
heading: 'link-heading',
13+
nav: 'link-nav',
14+
markdown: 'link link-markdown',
1515
},
1616
disabled: { true: 'link-disabled' },
1717
},

src/components/PostCard.astro

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ const getTransitionNameFromElementId = setTransitionSlug({ pageSlug: slug });
103103
elementId: TRANSITION_ELEMENT_IDS.POST_CARD.TITLE,
104104
})}
105105
>
106-
<Link href={`${ROUTES.BLOG}${slug}`} variant="link-heading">
106+
<Link href={`${ROUTES.BLOG}${slug}`} variant="heading">
107107
{title}
108108
{draft && <sup class="text-sm text-red-500 ml-1">{DRAFT_TEXT}</sup>}
109109
</Link>

src/components/PostCardMore.astro

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ const { title, heroImage, heroAlt, description, draft } = data;
2525
class="max-h-40 object-cover rounded-t-box"
2626
/>
2727
<h4 class="b-h4 break-words line-clamp-2 mt-3 mb-2">
28-
<Link variant="link-heading" href={`${ROUTES.BLOG}${slug}`}>
28+
<Link variant="heading" href={`${ROUTES.BLOG}${slug}`}>
2929
{title}
3030
{draft && <sup class="text-sm text-red-500 ml-1">{DRAFT_TEXT}</sup>}
3131
</Link>

src/components/PostCardSmall.astro

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ const getTransitionNameFromElementId = setTransitionSlug({ pageSlug: slug });
5454
elementId: TRANSITION_ELEMENT_IDS.POST_CARD.TITLE,
5555
})}
5656
>
57-
<Link variant="link-heading" href={`${ROUTES.BLOG}${slug}`}>
57+
<Link variant="heading" href={`${ROUTES.BLOG}${slug}`}>
5858
{draft && <sup class="text-sm text-red-500 mr-1">{DRAFT_TEXT}</sup>}
5959
{title}
6060
</Link>

src/components/ProjectCard.astro

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ const { lastAccessDate, isUpdatedDate } = getPublishedOrUpdatedDate({
3434
/>
3535

3636
<h4 class="b-h4 break-words line-clamp-2 mb-0">
37-
<Link href={`${ROUTES.PROJECTS}${slug}`} variant="link-heading">
37+
<Link href={`${ROUTES.PROJECTS}${slug}`} variant="heading">
3838
{title}
3939
</Link>
4040
</h4>

src/content/project/2024/12-09-hackernews-new-jobs/index.mdx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ This is a Next.js server side rendered app with default ShadcnUI components. Alg
4545

4646
The app requires zero maintenance, the only insert query to parse a new month is automated using a `node-cron` scheduled task. The app is packed as a Docker image, either in Github Actions or locally, and is available for both `linux/amd64` and `linux/arm64` platforms. It also has Winston logger and Plausible analytics.
4747

48-
You can find more implementation details in the <Link href="https://github.com/nemanjam/hn-new-jobs/tree/main#implementation-details" variant="link-markdown" target="_blank" title="README.md file">README.md</Link> file on Github.
48+
You can find more implementation details in the <Link href="https://github.com/nemanjam/hn-new-jobs/tree/main#implementation-details" variant="markdown" target="_blank" title="README.md file">README.md</Link> file on Github.
4949

5050
## Lessons learned
5151

@@ -57,8 +57,8 @@ You can find more implementation details in the <Link href="https://github.com/n
5757
## Links
5858

5959

60-
- **HackerNews:** <Link href="https://news.ycombinator.com/item?id=42373936" variant="link-markdown" target="_blank" title="HackerNews ShowHN thread" />
61-
- **Demo:** <Link href="https://hackernews-new-jobs.arm1.nemanjamitic.com" variant="link-markdown" target="_blank" title="HackerNews new jobs demo" />
62-
- **Repository:** <Link href="https://github.com/nemanjam/hn-new-jobs" variant="link-markdown" target="_blank" title="HackerNews new jobs repository" />
60+
- **HackerNews:** <Link href="https://news.ycombinator.com/item?id=42373936" variant="markdown" target="_blank" title="HackerNews ShowHN thread" />
61+
- **Demo:** <Link href="https://hackernews-new-jobs.arm1.nemanjamitic.com" variant="markdown" target="_blank" title="HackerNews new jobs demo" />
62+
- **Repository:** <Link href="https://github.com/nemanjam/hn-new-jobs" variant="markdown" target="_blank" title="HackerNews new jobs repository" />
6363

6464

src/pages/design/buttons.mdx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,9 @@ export const links = {
5959
variant: [
6060
{ variant: 'link' },
6161
{ variant: 'no-underline' },
62-
{ variant: 'link-heading' },
63-
{ variant: 'link-nav' },
62+
{ variant: 'heading' },
63+
{ variant: 'nav' },
64+
{ variant: 'markdown' },
6465
],
6566
disabled: [{ disabled: true }, { disabled: false }],
6667
};
@@ -74,7 +75,7 @@ export const links = {
7475
{values.map((props) => {
7576
const text = `${Object.values(props)[0]}`;
7677

77-
return <Link {...props}>{text}</Link>;
78+
return <Link {...props} href="#">{text}</Link>;
7879
})}
7980

8081
</div>

0 commit comments

Comments
 (0)